CC: [email protected] In-Reply-To: <[email protected]> References: <[email protected]> TO: Joerg Roedel <[email protected]> TO: Joerg Roedel <[email protected]> CC: David Woodhouse <[email protected]> CC: Lu Baolu <[email protected]> CC: Suravee Suthikulpanit <[email protected]> CC: Jerry Snitselaar <[email protected]> CC: Qian Cai <[email protected]> CC: [email protected] CC: [email protected]
Hi Joerg, I love your patch! Perhaps something to improve: [auto build test WARNING on iommu/next] [also build test WARNING on linus/master next-20200609] [cannot apply to v5.7] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system. BTW, we also suggest to use '--base' option to specify the base tree in git format-patch, please see https://stackoverflow.com/a/37406982] url: https://github.com/0day-ci/linux/commits/Joerg-Roedel/iommu-Move-Intel-and-AMD-drivers-into-their-own-subdirectory/20200609-210928 base: https://git.kernel.org/pub/scm/linux/kernel/git/joro/iommu.git next :::::: branch date: 5 hours ago :::::: commit date: 5 hours ago config: x86_64-randconfig-m001-20200607 (attached as .config) compiler: gcc-9 (Debian 9.3.0-13) 9.3.0 If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot <[email protected]> Reported-by: Dan Carpenter <[email protected]> smatch warnings: drivers/iommu/amd/iommu.c:733 amd_iommu_int_thread() warn: this loop depends on readl() succeeding # https://github.com/0day-ci/linux/commit/99df47ff4503fa8f819966f0d3882d979ad83fab git remote add linux-review https://github.com/0day-ci/linux git remote update linux-review git checkout 99df47ff4503fa8f819966f0d3882d979ad83fab vim +733 drivers/iommu/amd/iommu.c bd6fcefc66f6d0 drivers/iommu/amd_iommu.c Suravee Suthikulpanit 2016-08-23 722 bd6fcefc66f6d0 drivers/iommu/amd_iommu.c Suravee Suthikulpanit 2016-08-23 723 #define AMD_IOMMU_INT_MASK \ bd6fcefc66f6d0 drivers/iommu/amd_iommu.c Suravee Suthikulpanit 2016-08-23 724 (MMIO_STATUS_EVT_INT_MASK | \ bd6fcefc66f6d0 drivers/iommu/amd_iommu.c Suravee Suthikulpanit 2016-08-23 725 MMIO_STATUS_PPR_INT_MASK | \ bd6fcefc66f6d0 drivers/iommu/amd_iommu.c Suravee Suthikulpanit 2016-08-23 726 MMIO_STATUS_GALOG_INT_MASK) bd6fcefc66f6d0 drivers/iommu/amd_iommu.c Suravee Suthikulpanit 2016-08-23 727 72fe00f01f9a32 arch/x86/kernel/amd_iommu.c Joerg Roedel 2011-05-10 728 irqreturn_t amd_iommu_int_thread(int irq, void *data) a80dc3e0e0dc83 arch/x86/kernel/amd_iommu.c Joerg Roedel 2008-09-11 729 { 3f398bc7762adc drivers/iommu/amd_iommu.c Suravee Suthikulpanit 2013-04-22 730 struct amd_iommu *iommu = (struct amd_iommu *) data; 3f398bc7762adc drivers/iommu/amd_iommu.c Suravee Suthikulpanit 2013-04-22 731 u32 status = readl(iommu->mmio_base + MMIO_STATUS_OFFSET); 90008ee4b811c9 arch/x86/kernel/amd_iommu.c Joerg Roedel 2008-09-09 732 bd6fcefc66f6d0 drivers/iommu/amd_iommu.c Suravee Suthikulpanit 2016-08-23 @733 while (status & AMD_IOMMU_INT_MASK) { bd6fcefc66f6d0 drivers/iommu/amd_iommu.c Suravee Suthikulpanit 2016-08-23 734 /* Enable EVT and PPR and GA interrupts again */ bd6fcefc66f6d0 drivers/iommu/amd_iommu.c Suravee Suthikulpanit 2016-08-23 735 writel(AMD_IOMMU_INT_MASK, 3f398bc7762adc drivers/iommu/amd_iommu.c Suravee Suthikulpanit 2013-04-22 736 iommu->mmio_base + MMIO_STATUS_OFFSET); 90008ee4b811c9 arch/x86/kernel/amd_iommu.c Joerg Roedel 2008-09-09 737 3f398bc7762adc drivers/iommu/amd_iommu.c Suravee Suthikulpanit 2013-04-22 738 if (status & MMIO_STATUS_EVT_INT_MASK) { 101fa0371478aa drivers/iommu/amd_iommu.c Joerg Roedel 2018-11-27 739 pr_devel("Processing IOMMU Event Log\n"); 90008ee4b811c9 arch/x86/kernel/amd_iommu.c Joerg Roedel 2008-09-09 740 iommu_poll_events(iommu); 3f398bc7762adc drivers/iommu/amd_iommu.c Suravee Suthikulpanit 2013-04-22 741 } 3f398bc7762adc drivers/iommu/amd_iommu.c Suravee Suthikulpanit 2013-04-22 742 3f398bc7762adc drivers/iommu/amd_iommu.c Suravee Suthikulpanit 2013-04-22 743 if (status & MMIO_STATUS_PPR_INT_MASK) { 101fa0371478aa drivers/iommu/amd_iommu.c Joerg Roedel 2018-11-27 744 pr_devel("Processing IOMMU PPR Log\n"); 72e1dcc4192288 drivers/iommu/amd_iommu.c Joerg Roedel 2011-11-10 745 iommu_poll_ppr_log(iommu); 72e1dcc4192288 drivers/iommu/amd_iommu.c Joerg Roedel 2011-11-10 746 } 90008ee4b811c9 arch/x86/kernel/amd_iommu.c Joerg Roedel 2008-09-09 747 :::::: The code at line 733 was first introduced by commit :::::: bd6fcefc66f6d038406e38edf96a95d9842f819d iommu/amd: Adding GALOG interrupt handler :::::: TO: Suravee Suthikulpanit <[email protected]> :::::: CC: Joerg Roedel <[email protected]> --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/[email protected]
.config.gz
Description: application/gzip
_______________________________________________ kbuild mailing list -- [email protected] To unsubscribe send an email to [email protected]
