CC: [email protected] CC: [email protected] TO: YueHaibing <[email protected]> CC: "Greg Kroah-Hartman" <[email protected]> CC: Stephen Boyd <[email protected]>
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master head: 5b14671be58d0084e7e2d1cc9c2c36a94467f6e0 commit: ca7ce5a2710ad2a57bf7d0c4c712590bb69a5e1c coccinelle: platform_get_irq: Fix parse error date: 9 months ago :::::: branch date: 12 hours ago :::::: commit date: 9 months ago config: x86_64-randconfig-c002-20200607 (attached as .config) compiler: gcc-9 (Debian 9.3.0-13) 9.3.0 If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot <[email protected]> Reported-by: Julia Lawall <[email protected]> coccinelle warnings: (new ones prefixed by >>) >> drivers/power/supply/axp288_charger.c:829:3-10: line 829 is redundant >> because platform_get_irq() already prints an error # https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=ca7ce5a2710ad2a57bf7d0c4c712590bb69a5e1c git remote add linus https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git git remote update linus git checkout ca7ce5a2710ad2a57bf7d0c4c712590bb69a5e1c vim +829 drivers/power/supply/axp288_charger.c 165c2357744e41 drivers/power/supply/axp288_charger.c Hans de Goede 2017-12-26 735 843735b788a4e4 drivers/power/axp288_charger.c Ramakrishna Pallala 2015-05-04 736 static int axp288_charger_probe(struct platform_device *pdev) 843735b788a4e4 drivers/power/axp288_charger.c Ramakrishna Pallala 2015-05-04 737 { 843735b788a4e4 drivers/power/axp288_charger.c Ramakrishna Pallala 2015-05-04 738 int ret, i, pirq; 843735b788a4e4 drivers/power/axp288_charger.c Ramakrishna Pallala 2015-05-04 739 struct axp288_chrg_info *info; e3668e37f9078c drivers/power/supply/axp288_charger.c Hans de Goede 2016-12-21 740 struct device *dev = &pdev->dev; 843735b788a4e4 drivers/power/axp288_charger.c Ramakrishna Pallala 2015-05-04 741 struct axp20x_dev *axp20x = dev_get_drvdata(pdev->dev.parent); 843735b788a4e4 drivers/power/axp288_charger.c Ramakrishna Pallala 2015-05-04 742 struct power_supply_config charger_cfg = {}; efb440ecc15610 drivers/power/supply/axp288_charger.c Hans de Goede 2018-04-18 743 unsigned int val; efb440ecc15610 drivers/power/supply/axp288_charger.c Hans de Goede 2018-04-18 744 efb440ecc15610 drivers/power/supply/axp288_charger.c Hans de Goede 2018-04-18 745 /* efb440ecc15610 drivers/power/supply/axp288_charger.c Hans de Goede 2018-04-18 746 * On some devices the fuelgauge and charger parts of the axp288 are efb440ecc15610 drivers/power/supply/axp288_charger.c Hans de Goede 2018-04-18 747 * not used, check that the fuelgauge is enabled (CC_CTRL != 0). efb440ecc15610 drivers/power/supply/axp288_charger.c Hans de Goede 2018-04-18 748 */ efb440ecc15610 drivers/power/supply/axp288_charger.c Hans de Goede 2018-04-18 749 ret = regmap_read(axp20x->regmap, AXP20X_CC_CTRL, &val); efb440ecc15610 drivers/power/supply/axp288_charger.c Hans de Goede 2018-04-18 750 if (ret < 0) efb440ecc15610 drivers/power/supply/axp288_charger.c Hans de Goede 2018-04-18 751 return ret; efb440ecc15610 drivers/power/supply/axp288_charger.c Hans de Goede 2018-04-18 752 if (val == 0) efb440ecc15610 drivers/power/supply/axp288_charger.c Hans de Goede 2018-04-18 753 return -ENODEV; efb440ecc15610 drivers/power/supply/axp288_charger.c Hans de Goede 2018-04-18 754 843735b788a4e4 drivers/power/axp288_charger.c Ramakrishna Pallala 2015-05-04 755 info = devm_kzalloc(&pdev->dev, sizeof(*info), GFP_KERNEL); 843735b788a4e4 drivers/power/axp288_charger.c Ramakrishna Pallala 2015-05-04 756 if (!info) 843735b788a4e4 drivers/power/axp288_charger.c Ramakrishna Pallala 2015-05-04 757 return -ENOMEM; 843735b788a4e4 drivers/power/axp288_charger.c Ramakrishna Pallala 2015-05-04 758 843735b788a4e4 drivers/power/axp288_charger.c Ramakrishna Pallala 2015-05-04 759 info->pdev = pdev; 843735b788a4e4 drivers/power/axp288_charger.c Ramakrishna Pallala 2015-05-04 760 info->regmap = axp20x->regmap; 843735b788a4e4 drivers/power/axp288_charger.c Ramakrishna Pallala 2015-05-04 761 info->regmap_irqc = axp20x->regmap_irqc; 843735b788a4e4 drivers/power/axp288_charger.c Ramakrishna Pallala 2015-05-04 762 843735b788a4e4 drivers/power/axp288_charger.c Ramakrishna Pallala 2015-05-04 763 info->cable.edev = extcon_get_extcon_dev(AXP288_EXTCON_DEV_NAME); 843735b788a4e4 drivers/power/axp288_charger.c Ramakrishna Pallala 2015-05-04 764 if (info->cable.edev == NULL) { 843735b788a4e4 drivers/power/axp288_charger.c Ramakrishna Pallala 2015-05-04 765 dev_dbg(&pdev->dev, "%s is not ready, probe deferred\n", 843735b788a4e4 drivers/power/axp288_charger.c Ramakrishna Pallala 2015-05-04 766 AXP288_EXTCON_DEV_NAME); 843735b788a4e4 drivers/power/axp288_charger.c Ramakrishna Pallala 2015-05-04 767 return -EPROBE_DEFER; 843735b788a4e4 drivers/power/axp288_charger.c Ramakrishna Pallala 2015-05-04 768 } 843735b788a4e4 drivers/power/axp288_charger.c Ramakrishna Pallala 2015-05-04 769 6c4c9a9a4a294a drivers/power/supply/axp288_charger.c Hans de Goede 2017-04-19 770 if (acpi_dev_present(USB_HOST_EXTCON_HID, NULL, -1)) { 6c4c9a9a4a294a drivers/power/supply/axp288_charger.c Hans de Goede 2017-04-19 771 info->otg.cable = extcon_get_extcon_dev(USB_HOST_EXTCON_NAME); 7508f44129ca3d drivers/power/supply/axp288_charger.c Hans de Goede 2016-12-21 772 if (info->otg.cable == NULL) { 7508f44129ca3d drivers/power/supply/axp288_charger.c Hans de Goede 2016-12-21 773 dev_dbg(dev, "EXTCON_USB_HOST is not ready, probe deferred\n"); 7508f44129ca3d drivers/power/supply/axp288_charger.c Hans de Goede 2016-12-21 774 return -EPROBE_DEFER; 7508f44129ca3d drivers/power/supply/axp288_charger.c Hans de Goede 2016-12-21 775 } 6c4c9a9a4a294a drivers/power/supply/axp288_charger.c Hans de Goede 2017-04-19 776 dev_info(&pdev->dev, 6c4c9a9a4a294a drivers/power/supply/axp288_charger.c Hans de Goede 2017-04-19 777 "Using " USB_HOST_EXTCON_HID " extcon for usb-id\n"); 6c4c9a9a4a294a drivers/power/supply/axp288_charger.c Hans de Goede 2017-04-19 778 } 7508f44129ca3d drivers/power/supply/axp288_charger.c Hans de Goede 2016-12-21 779 843735b788a4e4 drivers/power/axp288_charger.c Ramakrishna Pallala 2015-05-04 780 platform_set_drvdata(pdev, info); 843735b788a4e4 drivers/power/axp288_charger.c Ramakrishna Pallala 2015-05-04 781 d96e07350ab912 drivers/power/supply/axp288_charger.c Hans de Goede 2016-12-21 782 ret = charger_init_hw_regs(info); d96e07350ab912 drivers/power/supply/axp288_charger.c Hans de Goede 2016-12-21 783 if (ret) d96e07350ab912 drivers/power/supply/axp288_charger.c Hans de Goede 2016-12-21 784 return ret; d96e07350ab912 drivers/power/supply/axp288_charger.c Hans de Goede 2016-12-21 785 843735b788a4e4 drivers/power/axp288_charger.c Ramakrishna Pallala 2015-05-04 786 /* Register with power supply class */ 843735b788a4e4 drivers/power/axp288_charger.c Ramakrishna Pallala 2015-05-04 787 charger_cfg.drv_data = info; e3668e37f9078c drivers/power/supply/axp288_charger.c Hans de Goede 2016-12-21 788 info->psy_usb = devm_power_supply_register(dev, &axp288_charger_desc, 843735b788a4e4 drivers/power/axp288_charger.c Ramakrishna Pallala 2015-05-04 789 &charger_cfg); 843735b788a4e4 drivers/power/axp288_charger.c Ramakrishna Pallala 2015-05-04 790 if (IS_ERR(info->psy_usb)) { 843735b788a4e4 drivers/power/axp288_charger.c Ramakrishna Pallala 2015-05-04 791 ret = PTR_ERR(info->psy_usb); e3668e37f9078c drivers/power/supply/axp288_charger.c Hans de Goede 2016-12-21 792 dev_err(dev, "failed to register power supply: %d\n", ret); e3668e37f9078c drivers/power/supply/axp288_charger.c Hans de Goede 2016-12-21 793 return ret; 843735b788a4e4 drivers/power/axp288_charger.c Ramakrishna Pallala 2015-05-04 794 } 843735b788a4e4 drivers/power/axp288_charger.c Ramakrishna Pallala 2015-05-04 795 165c2357744e41 drivers/power/supply/axp288_charger.c Hans de Goede 2017-12-26 796 /* Cancel our work on cleanup, register this before the notifiers */ 165c2357744e41 drivers/power/supply/axp288_charger.c Hans de Goede 2017-12-26 797 ret = devm_add_action(dev, axp288_charger_cancel_work, info); 165c2357744e41 drivers/power/supply/axp288_charger.c Hans de Goede 2017-12-26 798 if (ret) 165c2357744e41 drivers/power/supply/axp288_charger.c Hans de Goede 2017-12-26 799 return ret; 165c2357744e41 drivers/power/supply/axp288_charger.c Hans de Goede 2017-12-26 800 42e2008a66a7e1 drivers/power/supply/axp288_charger.c Hans de Goede 2016-12-21 801 /* Register for extcon notification */ 42e2008a66a7e1 drivers/power/supply/axp288_charger.c Hans de Goede 2016-12-21 802 INIT_WORK(&info->cable.work, axp288_charger_extcon_evt_worker); 8c0a0a2959565d drivers/power/supply/axp288_charger.c Hans de Goede 2017-12-26 803 info->cable.nb.notifier_call = axp288_charger_handle_cable_evt; 8c0a0a2959565d drivers/power/supply/axp288_charger.c Hans de Goede 2017-12-26 804 ret = devm_extcon_register_notifier_all(dev, info->cable.edev, 8c0a0a2959565d drivers/power/supply/axp288_charger.c Hans de Goede 2017-12-26 805 &info->cable.nb); 42e2008a66a7e1 drivers/power/supply/axp288_charger.c Hans de Goede 2016-12-21 806 if (ret) { 8c0a0a2959565d drivers/power/supply/axp288_charger.c Hans de Goede 2017-12-26 807 dev_err(dev, "failed to register cable extcon notifier\n"); 42e2008a66a7e1 drivers/power/supply/axp288_charger.c Hans de Goede 2016-12-21 808 return ret; 42e2008a66a7e1 drivers/power/supply/axp288_charger.c Hans de Goede 2016-12-21 809 } 5c5bcb8c576c5c drivers/power/supply/axp288_charger.c Hans de Goede 2016-12-21 810 schedule_work(&info->cable.work); 42e2008a66a7e1 drivers/power/supply/axp288_charger.c Hans de Goede 2016-12-21 811 843735b788a4e4 drivers/power/axp288_charger.c Ramakrishna Pallala 2015-05-04 812 /* Register for OTG notification */ 843735b788a4e4 drivers/power/axp288_charger.c Ramakrishna Pallala 2015-05-04 813 INIT_WORK(&info->otg.work, axp288_charger_otg_evt_worker); 843735b788a4e4 drivers/power/axp288_charger.c Ramakrishna Pallala 2015-05-04 814 info->otg.id_nb.notifier_call = axp288_charger_handle_otg_evt; 6c4c9a9a4a294a drivers/power/supply/axp288_charger.c Hans de Goede 2017-04-19 815 if (info->otg.cable) { c31480348fcfba drivers/power/supply/axp288_charger.c Chanwoo Choi 2016-11-30 816 ret = devm_extcon_register_notifier(&pdev->dev, info->otg.cable, c31480348fcfba drivers/power/supply/axp288_charger.c Chanwoo Choi 2016-11-30 817 EXTCON_USB_HOST, &info->otg.id_nb); 7508f44129ca3d drivers/power/supply/axp288_charger.c Hans de Goede 2016-12-21 818 if (ret) { 7508f44129ca3d drivers/power/supply/axp288_charger.c Hans de Goede 2016-12-21 819 dev_err(dev, "failed to register EXTCON_USB_HOST notifier\n"); 7508f44129ca3d drivers/power/supply/axp288_charger.c Hans de Goede 2016-12-21 820 return ret; 7508f44129ca3d drivers/power/supply/axp288_charger.c Hans de Goede 2016-12-21 821 } 5c5bcb8c576c5c drivers/power/supply/axp288_charger.c Hans de Goede 2016-12-21 822 schedule_work(&info->otg.work); 6c4c9a9a4a294a drivers/power/supply/axp288_charger.c Hans de Goede 2017-04-19 823 } 843735b788a4e4 drivers/power/axp288_charger.c Ramakrishna Pallala 2015-05-04 824 843735b788a4e4 drivers/power/axp288_charger.c Ramakrishna Pallala 2015-05-04 825 /* Register charger interrupts */ 843735b788a4e4 drivers/power/axp288_charger.c Ramakrishna Pallala 2015-05-04 826 for (i = 0; i < CHRG_INTR_END; i++) { 843735b788a4e4 drivers/power/axp288_charger.c Ramakrishna Pallala 2015-05-04 827 pirq = platform_get_irq(info->pdev, i); c3422ad5f84a66 drivers/power/supply/axp288_charger.c Gustavo A. R. Silva 2019-03-18 828 if (pirq < 0) { c3422ad5f84a66 drivers/power/supply/axp288_charger.c Gustavo A. R. Silva 2019-03-18 @829 dev_err(&pdev->dev, "Failed to get IRQ: %d\n", pirq); c3422ad5f84a66 drivers/power/supply/axp288_charger.c Gustavo A. R. Silva 2019-03-18 830 return pirq; c3422ad5f84a66 drivers/power/supply/axp288_charger.c Gustavo A. R. Silva 2019-03-18 831 } 843735b788a4e4 drivers/power/axp288_charger.c Ramakrishna Pallala 2015-05-04 832 info->irq[i] = regmap_irq_get_virq(info->regmap_irqc, pirq); 843735b788a4e4 drivers/power/axp288_charger.c Ramakrishna Pallala 2015-05-04 833 if (info->irq[i] < 0) { 843735b788a4e4 drivers/power/axp288_charger.c Ramakrishna Pallala 2015-05-04 834 dev_warn(&info->pdev->dev, 843735b788a4e4 drivers/power/axp288_charger.c Ramakrishna Pallala 2015-05-04 835 "failed to get virtual interrupt=%d\n", pirq); e3668e37f9078c drivers/power/supply/axp288_charger.c Hans de Goede 2016-12-21 836 return info->irq[i]; 843735b788a4e4 drivers/power/axp288_charger.c Ramakrishna Pallala 2015-05-04 837 } 843735b788a4e4 drivers/power/axp288_charger.c Ramakrishna Pallala 2015-05-04 838 ret = devm_request_threaded_irq(&info->pdev->dev, info->irq[i], 843735b788a4e4 drivers/power/axp288_charger.c Ramakrishna Pallala 2015-05-04 839 NULL, axp288_charger_irq_thread_handler, 843735b788a4e4 drivers/power/axp288_charger.c Ramakrishna Pallala 2015-05-04 840 IRQF_ONESHOT, info->pdev->name, info); 843735b788a4e4 drivers/power/axp288_charger.c Ramakrishna Pallala 2015-05-04 841 if (ret) { 843735b788a4e4 drivers/power/axp288_charger.c Ramakrishna Pallala 2015-05-04 842 dev_err(&pdev->dev, "failed to request interrupt=%d\n", 843735b788a4e4 drivers/power/axp288_charger.c Ramakrishna Pallala 2015-05-04 843 info->irq[i]); e3668e37f9078c drivers/power/supply/axp288_charger.c Hans de Goede 2016-12-21 844 return ret; 843735b788a4e4 drivers/power/axp288_charger.c Ramakrishna Pallala 2015-05-04 845 } 843735b788a4e4 drivers/power/axp288_charger.c Ramakrishna Pallala 2015-05-04 846 } 843735b788a4e4 drivers/power/axp288_charger.c Ramakrishna Pallala 2015-05-04 847 843735b788a4e4 drivers/power/axp288_charger.c Ramakrishna Pallala 2015-05-04 848 return 0; 843735b788a4e4 drivers/power/axp288_charger.c Ramakrishna Pallala 2015-05-04 849 } 843735b788a4e4 drivers/power/axp288_charger.c Ramakrishna Pallala 2015-05-04 850 :::::: The code at line 829 was first introduced by commit :::::: c3422ad5f84a66739ec6a37251ca27638c85b6be power: supply: axp288_charger: Fix unchecked return value :::::: TO: Gustavo A. R. Silva <[email protected]> :::::: CC: Sebastian Reichel <[email protected]> --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/[email protected]
.config.gz
Description: application/gzip
_______________________________________________ kbuild mailing list -- [email protected] To unsubscribe send an email to [email protected]
