CC: [email protected] CC: [email protected] TO: Peter Chen <[email protected]> CC: Felipe Balbi <[email protected]>
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master head: 84fc461db99b2dc19e019c0a97725a3653687981 commit: 1a1c851bbd706ea9f3a9756c2d3db28523506d3b usb: gadget: configfs: fix concurrent issue between composite APIs date: 8 months ago :::::: branch date: 82 minutes ago :::::: commit date: 8 months ago config: x86_64-randconfig-m001-20200611 (attached as .config) compiler: gcc-9 (Debian 9.3.0-13) 9.3.0 If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot <[email protected]> Reported-by: Dan Carpenter <[email protected]> New smatch warnings: drivers/usb/gadget/configfs.c:1400 configfs_composite_unbind() error: double unlocked 'gi->spinlock' (orig line 1390) Old smatch warnings: drivers/usb/gadget/configfs.c:769 os_desc_b_vendor_code_show() warn: argument 3 to %02x specifier has type 'char' # https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=1a1c851bbd706ea9f3a9756c2d3db28523506d3b git remote add linus https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git git remote update linus git checkout 1a1c851bbd706ea9f3a9756c2d3db28523506d3b vim +1400 drivers/usb/gadget/configfs.c 88af8bbe4ef781 Sebastian Andrzej Siewior 2012-12-23 1377 88af8bbe4ef781 Sebastian Andrzej Siewior 2012-12-23 1378 static void configfs_composite_unbind(struct usb_gadget *gadget) 88af8bbe4ef781 Sebastian Andrzej Siewior 2012-12-23 1379 { 88af8bbe4ef781 Sebastian Andrzej Siewior 2012-12-23 1380 struct usb_composite_dev *cdev; 88af8bbe4ef781 Sebastian Andrzej Siewior 2012-12-23 1381 struct gadget_info *gi; 1a1c851bbd706e Peter Chen 2019-08-26 1382 unsigned long flags; 88af8bbe4ef781 Sebastian Andrzej Siewior 2012-12-23 1383 88af8bbe4ef781 Sebastian Andrzej Siewior 2012-12-23 1384 /* the gi->lock is hold by the caller */ 88af8bbe4ef781 Sebastian Andrzej Siewior 2012-12-23 1385 88af8bbe4ef781 Sebastian Andrzej Siewior 2012-12-23 1386 cdev = get_gadget_data(gadget); 88af8bbe4ef781 Sebastian Andrzej Siewior 2012-12-23 1387 gi = container_of(cdev, struct gadget_info, cdev); 1a1c851bbd706e Peter Chen 2019-08-26 1388 spin_lock_irqsave(&gi->spinlock, flags); 1a1c851bbd706e Peter Chen 2019-08-26 1389 gi->unbind = 1; 1a1c851bbd706e Peter Chen 2019-08-26 @1390 spin_unlock_irqrestore(&gi->spinlock, flags); 88af8bbe4ef781 Sebastian Andrzej Siewior 2012-12-23 1391 41ce84c86d0a04 Li Jun 2015-07-09 1392 kfree(otg_desc[0]); 41ce84c86d0a04 Li Jun 2015-07-09 1393 otg_desc[0] = NULL; 88af8bbe4ef781 Sebastian Andrzej Siewior 2012-12-23 1394 purge_configs_funcs(gi); 88af8bbe4ef781 Sebastian Andrzej Siewior 2012-12-23 1395 composite_dev_cleanup(cdev); 88af8bbe4ef781 Sebastian Andrzej Siewior 2012-12-23 1396 usb_ep_autoconfig_reset(cdev->gadget); 1a1c851bbd706e Peter Chen 2019-08-26 1397 spin_lock_irqsave(&gi->spinlock, flags); 88af8bbe4ef781 Sebastian Andrzej Siewior 2012-12-23 1398 cdev->gadget = NULL; 88af8bbe4ef781 Sebastian Andrzej Siewior 2012-12-23 1399 set_gadget_data(gadget, NULL); 1a1c851bbd706e Peter Chen 2019-08-26 @1400 spin_unlock_irqrestore(&gi->spinlock, flags); 1a1c851bbd706e Peter Chen 2019-08-26 1401 } 1a1c851bbd706e Peter Chen 2019-08-26 1402 --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/[email protected]
.config.gz
Description: application/gzip
_______________________________________________ kbuild mailing list -- [email protected] To unsubscribe send an email to [email protected]
