CC: [email protected] CC: [email protected] TO: Can Guo <[email protected]> CC: "Martin K. Petersen" <[email protected]> CC: Stanley Chu <[email protected]>
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master head: b791d1bdf9212d944d749a5c7ff6febdba241771 commit: be7594a424b4de7473b3d726635c3bf6aa19a86e scsi: ufs: Fix possible unclocked access to auto hibern8 timer register date: 3 months ago :::::: branch date: 5 hours ago :::::: commit date: 3 months ago config: x86_64-randconfig-m001-20200612 (attached as .config) compiler: gcc-9 (Debian 9.3.0-13) 9.3.0 If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot <[email protected]> Reported-by: Dan Carpenter <[email protected]> New smatch warnings: drivers/scsi/ufs/ufshcd.c:3903 ufshcd_auto_hibern8_update() error: double unlocked '*hba->host->host_lock' (orig line 3897) Old smatch warnings: drivers/scsi/ufs/ufshcd.c:1370 ufshcd_suspend_clkscaling() error: double unlocked '*hba->host->host_lock' (orig line 1367) drivers/scsi/ufs/ufshcd.c:1639 ufshcd_gate_work() error: double unlocked '*hba->host->host_lock' (orig line 1602) drivers/scsi/ufs/ufshcd.c:2067 ufshcd_send_uic_cmd() error: double unlocked '*hba->host->host_lock' (orig line 2065) drivers/scsi/ufs/ufshcd.c:2067 ufshcd_send_uic_cmd() error: double unlocked '*hba->host->host_lock' (orig line 2065) drivers/scsi/ufs/ufshcd.c:2071 ufshcd_send_uic_cmd() error: double unlocked '*hba->host->host_lock' (orig line 2065) drivers/scsi/ufs/ufshcd.c:2447 ufshcd_queuecommand() error: double unlocked '*hba->host->host_lock' (orig line 2420) drivers/scsi/ufs/ufshcd.c:2458 ufshcd_queuecommand() error: double unlocked '*hba->host->host_lock' (orig line 2420) drivers/scsi/ufs/ufshcd.c:2580 ufshcd_wait_for_dev_cmd() error: double unlocked '*hba->host->host_lock' (orig line 2574) drivers/scsi/ufs/ufshcd.c:2580 ufshcd_wait_for_dev_cmd() error: double unlocked '*hba->host->host_lock' (orig line 2574) drivers/scsi/ufs/ufshcd.c:3736 ufshcd_uic_pwr_ctrl() error: double unlocked '*hba->host->host_lock' (orig line 3700) drivers/scsi/ufs/ufshcd.c:3795 ufshcd_link_recovery() error: double unlocked '*hba->host->host_lock' (orig line 3784) drivers/scsi/ufs/ufshcd.c:5256 ufshcd_quirk_dl_nac_errors() error: double unlocked '*hba->host->host_lock' (orig line 5236) drivers/scsi/ufs/ufshcd.c:5274 ufshcd_quirk_dl_nac_errors() error: double unlocked '*hba->host->host_lock' (orig line 5256) drivers/scsi/ufs/ufshcd.c:5334 ufshcd_err_handler() error: double unlocked '*hba->host->host_lock' (orig line 5310) drivers/scsi/ufs/ufshcd.c:5337 ufshcd_err_handler() error: double unlocked '*hba->host->host_lock' (orig line 5334) drivers/scsi/ufs/ufshcd.c:5337 ufshcd_err_handler() error: double unlocked '*hba->host->host_lock' (orig line 5334) drivers/scsi/ufs/ufshcd.c:5376 ufshcd_err_handler() error: double unlocked '*hba->host->host_lock' (orig line 5310) drivers/scsi/ufs/ufshcd.c:5404 ufshcd_err_handler() error: double unlocked '*hba->host->host_lock' (orig line 5376) drivers/scsi/ufs/ufshcd.c:5406 ufshcd_err_handler() error: double unlocked '*hba->host->host_lock' (orig line 5404) drivers/scsi/ufs/ufshcd.c:5795 __ufshcd_issue_tm_cmd() error: double unlocked '*hba->host->host_lock' (orig line 5791) drivers/scsi/ufs/ufshcd.c:6391 ufshcd_eh_host_reset_handler() error: double unlocked '*hba->host->host_lock' (orig line 6378) drivers/scsi/ufs/ufshcd.c:6393 ufshcd_eh_host_reset_handler() error: double unlocked '*hba->host->host_lock' (orig line 6391) drivers/scsi/ufs/ufshcd.c:7611 ufshcd_hba_exit() error: double unlocked '*hba->host->host_lock' (orig line 7608) drivers/scsi/ufs/ufshcd.c:7970 ufshcd_suspend() error: double unlocked '*hba->host->host_lock' (orig line 7890) drivers/scsi/ufs/ufshcd.c:7981 ufshcd_suspend() error: double unlocked '*hba->host->host_lock' (orig line 7890) drivers/scsi/ufs/ufshcd.c:7983 ufshcd_suspend() error: double unlocked '*hba->host->host_lock' (orig line 7890) drivers/scsi/ufs/ufshcd.c:8068 ufshcd_resume() error: double unlocked '*hba->host->host_lock' (orig line 8065) drivers/scsi/ufs/ufshcd.c:8071 ufshcd_resume() error: double unlocked '*hba->host->host_lock' (orig line 8065) # https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=be7594a424b4de7473b3d726635c3bf6aa19a86e git remote add linus https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git git remote update linus git checkout be7594a424b4de7473b3d726635c3bf6aa19a86e vim +3903 drivers/scsi/ufs/ufshcd.c 57d104c153d3d6 Subhash Jadavani 2014-09-25 3883 ba7af5ec5126dc Stanley Chu 2019-12-30 3884 void ufshcd_auto_hibern8_update(struct ufs_hba *hba, u32 ahit) ba7af5ec5126dc Stanley Chu 2019-12-30 3885 { ba7af5ec5126dc Stanley Chu 2019-12-30 3886 unsigned long flags; be7594a424b4de Can Guo 2020-03-05 3887 bool update = false; ba7af5ec5126dc Stanley Chu 2019-12-30 3888 be7594a424b4de Can Guo 2020-03-05 3889 if (!ufshcd_is_auto_hibern8_supported(hba)) ba7af5ec5126dc Stanley Chu 2019-12-30 3890 return; ba7af5ec5126dc Stanley Chu 2019-12-30 3891 ba7af5ec5126dc Stanley Chu 2019-12-30 3892 spin_lock_irqsave(hba->host->host_lock, flags); be7594a424b4de Can Guo 2020-03-05 3893 if (hba->ahit != ahit) { ba7af5ec5126dc Stanley Chu 2019-12-30 3894 hba->ahit = ahit; be7594a424b4de Can Guo 2020-03-05 3895 update = true; be7594a424b4de Can Guo 2020-03-05 3896 } ba7af5ec5126dc Stanley Chu 2019-12-30 @3897 spin_unlock_irqrestore(hba->host->host_lock, flags); be7594a424b4de Can Guo 2020-03-05 3898 be7594a424b4de Can Guo 2020-03-05 3899 if (update && !pm_runtime_suspended(hba->dev)) { be7594a424b4de Can Guo 2020-03-05 3900 pm_runtime_get_sync(hba->dev); be7594a424b4de Can Guo 2020-03-05 3901 ufshcd_hold(hba, false); be7594a424b4de Can Guo 2020-03-05 3902 ufshcd_auto_hibern8_enable(hba); be7594a424b4de Can Guo 2020-03-05 @3903 ufshcd_release(hba); be7594a424b4de Can Guo 2020-03-05 3904 pm_runtime_put(hba->dev); be7594a424b4de Can Guo 2020-03-05 3905 } ba7af5ec5126dc Stanley Chu 2019-12-30 3906 } ba7af5ec5126dc Stanley Chu 2019-12-30 3907 EXPORT_SYMBOL_GPL(ufshcd_auto_hibern8_update); ba7af5ec5126dc Stanley Chu 2019-12-30 3908 --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/[email protected]
.config.gz
Description: application/gzip
_______________________________________________ kbuild mailing list -- [email protected] To unsubscribe send an email to [email protected]
