CC: [email protected] TO: Keerthy <[email protected]> CC: Tero Kristo <[email protected]> CC: Herbert Xu <[email protected]> CC: [email protected] CC: [email protected]
From: kernel test robot <[email protected]> drivers/crypto/sa2ul.c:1253:5-11: inconsistent IS_ERR and PTR_ERR on line 1255. drivers/crypto/sa2ul.c:1261:5-11: inconsistent IS_ERR and PTR_ERR on line 1262. PTR_ERR should access the value just tested by IS_ERR Semantic patch information: There can be false positives in the patch case, where it is the call to IS_ERR that is wrong. Generated by: scripts/coccinelle/tests/odd_ptr_err.cocci Fixes: 5b8516f3bedb ("crypto: sa2ul: Add crypto driver") CC: Keerthy <[email protected]> Signed-off-by: kernel test robot <[email protected]> --- tree: git://git.ti.com/ti-linux-kernel/ti-linux-kernel.git ti-linux-5.4.y head: 134a1b1f8814115e2dd115b67082321bf9e63cc1 commit: 5b8516f3bedb3e1c273e7747b6e4a85c6e47907a [2369/7050] crypto: sa2ul: Add crypto driver :::::: branch date: 3 hours ago :::::: commit date: 5 months ago Please take the patch only if it's a positive warning. Thanks! sa2ul.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) --- a/drivers/crypto/sa2ul.c +++ b/drivers/crypto/sa2ul.c @@ -1252,14 +1252,14 @@ static int sa_dma_init(struct sa_crypto_ dd->dma_rx2 = dma_request_chan(dd->dev, "rx2"); if (IS_ERR(dd->dma_rx2)) { dma_release_channel(dd->dma_rx1); - if (PTR_ERR(dd->dma_rx1) != -EPROBE_DEFER) + if (PTR_ERR(dd->dma_rx2) != -EPROBE_DEFER) dev_err(dd->dev, "Unable to request rx2 DMA channel\n"); return PTR_ERR(dd->dma_rx2); } dd->dma_tx = dma_request_chan(dd->dev, "tx"); if (IS_ERR(dd->dma_tx)) { - if (PTR_ERR(dd->dma_rx1) != -EPROBE_DEFER) + if (PTR_ERR(dd->dma_tx) != -EPROBE_DEFER) dev_err(dd->dev, "Unable to request tx DMA channel\n"); ret = PTR_ERR(dd->dma_tx); goto err_dma_tx; _______________________________________________ kbuild mailing list -- [email protected] To unsubscribe send an email to [email protected]
