CC: [email protected] CC: [email protected] TO: Samuel Holland <[email protected]> CC: Sebastian Reichel <[email protected]> CC: "Chen-Yu Tsai" <[email protected]>
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master head: 96144c58abe7ff767e754b5b80995f7b8846d49b commit: 09aaaec5f658a7cf04c6318ac794eafdb23fa240 power: supply: axp20x_usb_power: Add wakeup control date: 5 months ago :::::: branch date: 13 hours ago :::::: commit date: 5 months ago config: parisc-randconfig-c003-20200614 (attached as .config) compiler: hppa-linux-gcc (GCC) 9.3.0 If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot <[email protected]> Reported-by: Julia Lawall <[email protected]> coccinelle warnings: (new ones prefixed by >>) >> drivers/power/supply/axp20x_usb_power.c:621:3-10: line 621 is redundant >> because platform_get_irq() already prints an error # https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=09aaaec5f658a7cf04c6318ac794eafdb23fa240 git remote add linus https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git git remote update linus git checkout 09aaaec5f658a7cf04c6318ac794eafdb23fa240 vim +621 drivers/power/supply/axp20x_usb_power.c 33863c938caa25 drivers/power/supply/axp20x_usb_power.c Quentin Schulz 2017-01-27 554 69fb4dcada7704 drivers/power/axp20x_usb_power.c Hans de Goede 2015-08-01 555 static int axp20x_usb_power_probe(struct platform_device *pdev) 69fb4dcada7704 drivers/power/axp20x_usb_power.c Hans de Goede 2015-08-01 556 { 69fb4dcada7704 drivers/power/axp20x_usb_power.c Hans de Goede 2015-08-01 557 struct axp20x_dev *axp20x = dev_get_drvdata(pdev->dev.parent); 69fb4dcada7704 drivers/power/axp20x_usb_power.c Hans de Goede 2015-08-01 558 struct power_supply_config psy_cfg = {}; 69fb4dcada7704 drivers/power/axp20x_usb_power.c Hans de Goede 2015-08-01 559 struct axp20x_usb_power *power; 56900d4541a9e2 drivers/power/supply/axp20x_usb_power.c Samuel Holland 2020-01-14 560 const struct axp_data *axp_data; 69fb4dcada7704 drivers/power/axp20x_usb_power.c Hans de Goede 2015-08-01 561 int i, irq, ret; 69fb4dcada7704 drivers/power/axp20x_usb_power.c Hans de Goede 2015-08-01 562 69fb4dcada7704 drivers/power/axp20x_usb_power.c Hans de Goede 2015-08-01 563 if (!of_device_is_available(pdev->dev.of_node)) 69fb4dcada7704 drivers/power/axp20x_usb_power.c Hans de Goede 2015-08-01 564 return -ENODEV; 69fb4dcada7704 drivers/power/axp20x_usb_power.c Hans de Goede 2015-08-01 565 69fb4dcada7704 drivers/power/axp20x_usb_power.c Hans de Goede 2015-08-01 566 if (!axp20x) { 69fb4dcada7704 drivers/power/axp20x_usb_power.c Hans de Goede 2015-08-01 567 dev_err(&pdev->dev, "Parent drvdata not set\n"); 69fb4dcada7704 drivers/power/axp20x_usb_power.c Hans de Goede 2015-08-01 568 return -EINVAL; 69fb4dcada7704 drivers/power/axp20x_usb_power.c Hans de Goede 2015-08-01 569 } 69fb4dcada7704 drivers/power/axp20x_usb_power.c Hans de Goede 2015-08-01 570 09aaaec5f658a7 drivers/power/supply/axp20x_usb_power.c Samuel Holland 2020-01-14 571 axp_data = of_device_get_match_data(&pdev->dev); 09aaaec5f658a7 drivers/power/supply/axp20x_usb_power.c Samuel Holland 2020-01-14 572 09aaaec5f658a7 drivers/power/supply/axp20x_usb_power.c Samuel Holland 2020-01-14 573 power = devm_kzalloc(&pdev->dev, 09aaaec5f658a7 drivers/power/supply/axp20x_usb_power.c Samuel Holland 2020-01-14 574 struct_size(power, irqs, axp_data->num_irq_names), 09aaaec5f658a7 drivers/power/supply/axp20x_usb_power.c Samuel Holland 2020-01-14 575 GFP_KERNEL); 69fb4dcada7704 drivers/power/axp20x_usb_power.c Hans de Goede 2015-08-01 576 if (!power) 69fb4dcada7704 drivers/power/axp20x_usb_power.c Hans de Goede 2015-08-01 577 return -ENOMEM; 69fb4dcada7704 drivers/power/axp20x_usb_power.c Hans de Goede 2015-08-01 578 97ec136e7124fa drivers/power/supply/axp20x_usb_power.c Chen-Yu Tsai 2019-04-16 579 platform_set_drvdata(pdev, power); 0dcc70ca864408 drivers/power/supply/axp20x_usb_power.c Quentin Schulz 2016-12-09 580 56900d4541a9e2 drivers/power/supply/axp20x_usb_power.c Samuel Holland 2020-01-14 581 power->axp20x_id = axp_data->axp20x_id; 69fb4dcada7704 drivers/power/axp20x_usb_power.c Hans de Goede 2015-08-01 582 power->regmap = axp20x->regmap; 09aaaec5f658a7 drivers/power/supply/axp20x_usb_power.c Samuel Holland 2020-01-14 583 power->num_irqs = axp_data->num_irq_names; 69fb4dcada7704 drivers/power/axp20x_usb_power.c Hans de Goede 2015-08-01 584 0dcc70ca864408 drivers/power/supply/axp20x_usb_power.c Quentin Schulz 2016-12-09 585 if (power->axp20x_id == AXP202_ID) { 69fb4dcada7704 drivers/power/axp20x_usb_power.c Hans de Goede 2015-08-01 586 /* Enable vbus valid checking */ 69fb4dcada7704 drivers/power/axp20x_usb_power.c Hans de Goede 2015-08-01 587 ret = regmap_update_bits(power->regmap, AXP20X_VBUS_MON, cecbf8d52e6c7f drivers/power/axp20x_usb_power.c Hans de Goede 2016-06-02 588 AXP20X_VBUS_MON_VBUS_VALID, cecbf8d52e6c7f drivers/power/axp20x_usb_power.c Hans de Goede 2016-06-02 589 AXP20X_VBUS_MON_VBUS_VALID); 69fb4dcada7704 drivers/power/axp20x_usb_power.c Hans de Goede 2015-08-01 590 if (ret) 69fb4dcada7704 drivers/power/axp20x_usb_power.c Hans de Goede 2015-08-01 591 return ret; 69fb4dcada7704 drivers/power/axp20x_usb_power.c Hans de Goede 2015-08-01 592 33863c938caa25 drivers/power/supply/axp20x_usb_power.c Quentin Schulz 2017-01-27 593 if (IS_ENABLED(CONFIG_AXP20X_ADC)) 33863c938caa25 drivers/power/supply/axp20x_usb_power.c Quentin Schulz 2017-01-27 594 ret = configure_iio_channels(pdev, power); 33863c938caa25 drivers/power/supply/axp20x_usb_power.c Quentin Schulz 2017-01-27 595 else 33863c938caa25 drivers/power/supply/axp20x_usb_power.c Quentin Schulz 2017-01-27 596 ret = configure_adc_registers(power); 33863c938caa25 drivers/power/supply/axp20x_usb_power.c Quentin Schulz 2017-01-27 597 69fb4dcada7704 drivers/power/axp20x_usb_power.c Hans de Goede 2015-08-01 598 if (ret) 69fb4dcada7704 drivers/power/axp20x_usb_power.c Hans de Goede 2015-08-01 599 return ret; cecbf8d52e6c7f drivers/power/axp20x_usb_power.c Hans de Goede 2016-06-02 600 } cecbf8d52e6c7f drivers/power/axp20x_usb_power.c Hans de Goede 2016-06-02 601 f2e5c49d221bd4 drivers/power/supply/axp20x_usb_power.c Icenowy Zheng 2019-10-02 602 if (power->axp20x_id == AXP813_ID) { f2e5c49d221bd4 drivers/power/supply/axp20x_usb_power.c Icenowy Zheng 2019-10-02 603 /* Enable USB Battery Charging specification detection */ f2e5c49d221bd4 drivers/power/supply/axp20x_usb_power.c Icenowy Zheng 2019-10-02 604 regmap_update_bits(axp20x->regmap, AXP288_BC_GLOBAL, f2e5c49d221bd4 drivers/power/supply/axp20x_usb_power.c Icenowy Zheng 2019-10-02 605 AXP813_BC_EN, AXP813_BC_EN); f2e5c49d221bd4 drivers/power/supply/axp20x_usb_power.c Icenowy Zheng 2019-10-02 606 } f2e5c49d221bd4 drivers/power/supply/axp20x_usb_power.c Icenowy Zheng 2019-10-02 607 69fb4dcada7704 drivers/power/axp20x_usb_power.c Hans de Goede 2015-08-01 608 psy_cfg.of_node = pdev->dev.of_node; 69fb4dcada7704 drivers/power/axp20x_usb_power.c Hans de Goede 2015-08-01 609 psy_cfg.drv_data = power; 69fb4dcada7704 drivers/power/axp20x_usb_power.c Hans de Goede 2015-08-01 610 56900d4541a9e2 drivers/power/supply/axp20x_usb_power.c Samuel Holland 2020-01-14 611 power->supply = devm_power_supply_register(&pdev->dev, 56900d4541a9e2 drivers/power/supply/axp20x_usb_power.c Samuel Holland 2020-01-14 612 axp_data->power_desc, cecbf8d52e6c7f drivers/power/axp20x_usb_power.c Hans de Goede 2016-06-02 613 &psy_cfg); 69fb4dcada7704 drivers/power/axp20x_usb_power.c Hans de Goede 2015-08-01 614 if (IS_ERR(power->supply)) 69fb4dcada7704 drivers/power/axp20x_usb_power.c Hans de Goede 2015-08-01 615 return PTR_ERR(power->supply); 69fb4dcada7704 drivers/power/axp20x_usb_power.c Hans de Goede 2015-08-01 616 69fb4dcada7704 drivers/power/axp20x_usb_power.c Hans de Goede 2015-08-01 617 /* Request irqs after registering, as irqs may trigger immediately */ 09aaaec5f658a7 drivers/power/supply/axp20x_usb_power.c Samuel Holland 2020-01-14 618 for (i = 0; i < axp_data->num_irq_names; i++) { 56900d4541a9e2 drivers/power/supply/axp20x_usb_power.c Samuel Holland 2020-01-14 619 irq = platform_get_irq_byname(pdev, axp_data->irq_names[i]); 69fb4dcada7704 drivers/power/axp20x_usb_power.c Hans de Goede 2015-08-01 620 if (irq < 0) { 09aaaec5f658a7 drivers/power/supply/axp20x_usb_power.c Samuel Holland 2020-01-14 @621 dev_err(&pdev->dev, "No IRQ for %s: %d\n", 56900d4541a9e2 drivers/power/supply/axp20x_usb_power.c Samuel Holland 2020-01-14 622 axp_data->irq_names[i], irq); 09aaaec5f658a7 drivers/power/supply/axp20x_usb_power.c Samuel Holland 2020-01-14 623 return irq; 09aaaec5f658a7 drivers/power/supply/axp20x_usb_power.c Samuel Holland 2020-01-14 624 } 09aaaec5f658a7 drivers/power/supply/axp20x_usb_power.c Samuel Holland 2020-01-14 625 power->irqs[i] = regmap_irq_get_virq(axp20x->regmap_irqc, irq); 09aaaec5f658a7 drivers/power/supply/axp20x_usb_power.c Samuel Holland 2020-01-14 626 ret = devm_request_any_context_irq(&pdev->dev, power->irqs[i], 09aaaec5f658a7 drivers/power/supply/axp20x_usb_power.c Samuel Holland 2020-01-14 627 axp20x_usb_power_irq, 0, 09aaaec5f658a7 drivers/power/supply/axp20x_usb_power.c Samuel Holland 2020-01-14 628 DRVNAME, power); 09aaaec5f658a7 drivers/power/supply/axp20x_usb_power.c Samuel Holland 2020-01-14 629 if (ret < 0) { 09aaaec5f658a7 drivers/power/supply/axp20x_usb_power.c Samuel Holland 2020-01-14 630 dev_err(&pdev->dev, "Error requesting %s IRQ: %d\n", 56900d4541a9e2 drivers/power/supply/axp20x_usb_power.c Samuel Holland 2020-01-14 631 axp_data->irq_names[i], ret); 09aaaec5f658a7 drivers/power/supply/axp20x_usb_power.c Samuel Holland 2020-01-14 632 return ret; 09aaaec5f658a7 drivers/power/supply/axp20x_usb_power.c Samuel Holland 2020-01-14 633 } 69fb4dcada7704 drivers/power/axp20x_usb_power.c Hans de Goede 2015-08-01 634 } 69fb4dcada7704 drivers/power/axp20x_usb_power.c Hans de Goede 2015-08-01 635 97ec136e7124fa drivers/power/supply/axp20x_usb_power.c Chen-Yu Tsai 2019-04-16 636 INIT_DELAYED_WORK(&power->vbus_detect, axp20x_usb_power_poll_vbus); 97ec136e7124fa drivers/power/supply/axp20x_usb_power.c Chen-Yu Tsai 2019-04-16 637 if (axp20x_usb_vbus_needs_polling(power)) 97ec136e7124fa drivers/power/supply/axp20x_usb_power.c Chen-Yu Tsai 2019-04-16 638 queue_delayed_work(system_wq, &power->vbus_detect, 0); 97ec136e7124fa drivers/power/supply/axp20x_usb_power.c Chen-Yu Tsai 2019-04-16 639 97ec136e7124fa drivers/power/supply/axp20x_usb_power.c Chen-Yu Tsai 2019-04-16 640 return 0; 97ec136e7124fa drivers/power/supply/axp20x_usb_power.c Chen-Yu Tsai 2019-04-16 641 } 97ec136e7124fa drivers/power/supply/axp20x_usb_power.c Chen-Yu Tsai 2019-04-16 642 --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/[email protected]
.config.gz
Description: application/gzip
_______________________________________________ kbuild mailing list -- [email protected] To unsubscribe send an email to [email protected]
