CC: [email protected]
TO: Christoph Hellwig <[email protected]>

tree:   git://git.infradead.org/users/hch/misc.git quota-compat
head:   50cfd16ee025f4dab73eccc8e159cef8a46b6e23
commit: 50cfd16ee025f4dab73eccc8e159cef8a46b6e23 [1/1] quota: simplify the 
quotactl compat handling
:::::: branch date: 17 hours ago
:::::: commit date: 17 hours ago
config: i386-randconfig-m021-20200723 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-14) 9.3.0

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <[email protected]>
Reported-by: Dan Carpenter <[email protected]>

smatch warnings:
fs/quota/quota.c:417 compat_copy_fs_quota_stat() error: copy_to_user() '&from' 
too small (4 vs 8)

git remote add hch-misc git://git.infradead.org/users/hch/misc.git
git remote update hch-misc
git checkout 50cfd16ee025f4dab73eccc8e159cef8a46b6e23
vim +417 fs/quota/quota.c

50cfd16ee025f4 Christoph Hellwig 2020-07-22  412  
50cfd16ee025f4 Christoph Hellwig 2020-07-22  413  static int 
compat_copy_fs_quota_stat(struct compat_fs_quota_stat __user *to,
50cfd16ee025f4 Christoph Hellwig 2020-07-22  414                struct 
fs_quota_stat *from)
50cfd16ee025f4 Christoph Hellwig 2020-07-22  415  {
50cfd16ee025f4 Christoph Hellwig 2020-07-22  416        /* Copying qs_version, 
qs_flags, qs_pad */
50cfd16ee025f4 Christoph Hellwig 2020-07-22 @417        if (copy_to_user(to, 
&from, offsetof(typeof(*to), qs_uquota)))
50cfd16ee025f4 Christoph Hellwig 2020-07-22  418                return -EFAULT;
50cfd16ee025f4 Christoph Hellwig 2020-07-22  419        /* Copying qs_uquota 
and qs_gquota */
50cfd16ee025f4 Christoph Hellwig 2020-07-22  420        if 
(compat_copy_fs_qfilestat(&to->qs_uquota, &from->qs_uquota) ||
50cfd16ee025f4 Christoph Hellwig 2020-07-22  421            
compat_copy_fs_qfilestat(&to->qs_gquota, &from->qs_gquota))
50cfd16ee025f4 Christoph Hellwig 2020-07-22  422                return -EFAULT;
50cfd16ee025f4 Christoph Hellwig 2020-07-22  423        /* Copying the rest */
50cfd16ee025f4 Christoph Hellwig 2020-07-22  424        if 
(copy_to_user(&to->qs_incoredqs, &from->qs_incoredqs,
50cfd16ee025f4 Christoph Hellwig 2020-07-22  425                         
sizeof(*to) - offsetof(typeof(*to), qs_incoredqs)) ||
50cfd16ee025f4 Christoph Hellwig 2020-07-22  426            
put_user(from->qs_iwarnlimit, &to->qs_iwarnlimit))
50cfd16ee025f4 Christoph Hellwig 2020-07-22  427                return -EFAULT;
50cfd16ee025f4 Christoph Hellwig 2020-07-22  428        return 0;
50cfd16ee025f4 Christoph Hellwig 2020-07-22  429  }
50cfd16ee025f4 Christoph Hellwig 2020-07-22  430  

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/[email protected]

Attachment: .config.gz
Description: application/gzip

_______________________________________________
kbuild mailing list -- [email protected]
To unsubscribe send an email to [email protected]

Reply via email to