CC: [email protected] CC: [email protected] CC: [email protected] CC: [email protected] TO: "Rafael J. Wysocki" <[email protected]>
tree: https://git.kernel.org/pub/scm/linux/kernel/git/rafael/linux-pm.git testing head: 78b38a56af0ffa05ba414ce6be1123f7c799aafd commit: 819b477e22f8600b25abcdd15ed5b8e8b148caee [3/8] Merge branches 'pm-em', 'pm-sleep' and 'pm-domains' into linux-next :::::: branch date: 6 hours ago :::::: commit date: 3 days ago config: x86_64-randconfig-m001-20200729 (attached as .config) compiler: gcc-9 (Debian 9.3.0-14) 9.3.0 If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot <[email protected]> Reported-by: Dan Carpenter <[email protected]> New smatch warnings: drivers/staging/axis-fifo/axis-fifo.c:864 axis_fifo_probe() warn: could not determine type of argument 5 Old smatch warnings: drivers/staging/axis-fifo/axis-fifo.c:941 axis_fifo_probe() warn: could not determine type of argument 3 drivers/staging/axis-fifo/axis-fifo.c:941 axis_fifo_probe() error: '%pa' expects argument of type 'phys_addr_t*', argument 4 has type 'void**' # https://git.kernel.org/pub/scm/linux/kernel/git/rafael/linux-pm.git/commit/?id=819b477e22f8600b25abcdd15ed5b8e8b148caee git remote add pm https://git.kernel.org/pub/scm/linux/kernel/git/rafael/linux-pm.git git remote update pm git checkout 819b477e22f8600b25abcdd15ed5b8e8b148caee vim +864 drivers/staging/axis-fifo/axis-fifo.c ed6daf2b2832d9 Quentin Deslandes 2019-11-01 808 4a965c5f89decd Jacob Feder 2018-07-22 809 static int axis_fifo_probe(struct platform_device *pdev) 4a965c5f89decd Jacob Feder 2018-07-22 810 { 4a965c5f89decd Jacob Feder 2018-07-22 811 struct resource *r_irq; /* interrupt resources */ 4a965c5f89decd Jacob Feder 2018-07-22 812 struct resource *r_mem; /* IO mem resources */ 4a965c5f89decd Jacob Feder 2018-07-22 813 struct device *dev = &pdev->dev; /* OS device (from device tree) */ 4a965c5f89decd Jacob Feder 2018-07-22 814 struct axis_fifo *fifo = NULL; 4a965c5f89decd Jacob Feder 2018-07-22 815 4a965c5f89decd Jacob Feder 2018-07-22 816 char device_name[32]; 4a965c5f89decd Jacob Feder 2018-07-22 817 4a965c5f89decd Jacob Feder 2018-07-22 818 int rc = 0; /* error return value */ 4a965c5f89decd Jacob Feder 2018-07-22 819 4a965c5f89decd Jacob Feder 2018-07-22 820 /* ---------------------------- 4a965c5f89decd Jacob Feder 2018-07-22 821 * init wrapper device 4a965c5f89decd Jacob Feder 2018-07-22 822 * ---------------------------- 4a965c5f89decd Jacob Feder 2018-07-22 823 */ 4a965c5f89decd Jacob Feder 2018-07-22 824 4a965c5f89decd Jacob Feder 2018-07-22 825 /* allocate device wrapper memory */ 4a965c5f89decd Jacob Feder 2018-07-22 826 fifo = devm_kmalloc(dev, sizeof(*fifo), GFP_KERNEL); 4a965c5f89decd Jacob Feder 2018-07-22 827 if (!fifo) 4a965c5f89decd Jacob Feder 2018-07-22 828 return -ENOMEM; 4a965c5f89decd Jacob Feder 2018-07-22 829 4a965c5f89decd Jacob Feder 2018-07-22 830 dev_set_drvdata(dev, fifo); 4a965c5f89decd Jacob Feder 2018-07-22 831 fifo->dt_device = dev; 4a965c5f89decd Jacob Feder 2018-07-22 832 4a965c5f89decd Jacob Feder 2018-07-22 833 init_waitqueue_head(&fifo->read_queue); 4a965c5f89decd Jacob Feder 2018-07-22 834 init_waitqueue_head(&fifo->write_queue); 4a965c5f89decd Jacob Feder 2018-07-22 835 0443b3f4436321 Quentin Deslandes 2020-01-21 836 mutex_init(&fifo->read_lock); 0443b3f4436321 Quentin Deslandes 2020-01-21 837 mutex_init(&fifo->write_lock); 4a965c5f89decd Jacob Feder 2018-07-22 838 4a965c5f89decd Jacob Feder 2018-07-22 839 /* ---------------------------- 4a965c5f89decd Jacob Feder 2018-07-22 840 * init device memory space 4a965c5f89decd Jacob Feder 2018-07-22 841 * ---------------------------- 4a965c5f89decd Jacob Feder 2018-07-22 842 */ 4a965c5f89decd Jacob Feder 2018-07-22 843 4a965c5f89decd Jacob Feder 2018-07-22 844 /* get iospace for the device */ 4a965c5f89decd Jacob Feder 2018-07-22 845 r_mem = platform_get_resource(pdev, IORESOURCE_MEM, 0); 4a965c5f89decd Jacob Feder 2018-07-22 846 if (!r_mem) { 4a965c5f89decd Jacob Feder 2018-07-22 847 dev_err(fifo->dt_device, "invalid address\n"); 4a965c5f89decd Jacob Feder 2018-07-22 848 rc = -ENODEV; 4a965c5f89decd Jacob Feder 2018-07-22 849 goto err_initial; 4a965c5f89decd Jacob Feder 2018-07-22 850 } 4a965c5f89decd Jacob Feder 2018-07-22 851 4a965c5f89decd Jacob Feder 2018-07-22 852 /* request physical memory */ 354e27a86b4c64 Quentin Deslandes 2019-11-01 853 fifo->base_addr = devm_ioremap_resource(fifo->dt_device, r_mem); 6a20d283ed6867 Quentin Deslandes 2019-11-01 854 if (IS_ERR(fifo->base_addr)) { 6a20d283ed6867 Quentin Deslandes 2019-11-01 855 rc = PTR_ERR(fifo->base_addr); 6a20d283ed6867 Quentin Deslandes 2019-11-01 856 dev_err(fifo->dt_device, "can't remap IO resource (%d)\n", rc); 4a965c5f89decd Jacob Feder 2018-07-22 857 goto err_initial; 4a965c5f89decd Jacob Feder 2018-07-22 858 } 4a965c5f89decd Jacob Feder 2018-07-22 859 4a965c5f89decd Jacob Feder 2018-07-22 860 dev_dbg(fifo->dt_device, "remapped memory to 0x%p\n", fifo->base_addr); 4a965c5f89decd Jacob Feder 2018-07-22 861 4a965c5f89decd Jacob Feder 2018-07-22 862 /* create unique device name */ 4a965c5f89decd Jacob Feder 2018-07-22 863 snprintf(device_name, sizeof(device_name), "%s_%pa", 354e27a86b4c64 Quentin Deslandes 2019-11-01 @864 DRIVER_NAME, &r_mem->start); 4a965c5f89decd Jacob Feder 2018-07-22 865 4a965c5f89decd Jacob Feder 2018-07-22 866 dev_dbg(fifo->dt_device, "device name [%s]\n", device_name); 4a965c5f89decd Jacob Feder 2018-07-22 867 4a965c5f89decd Jacob Feder 2018-07-22 868 /* ---------------------------- 4a965c5f89decd Jacob Feder 2018-07-22 869 * init IP 4a965c5f89decd Jacob Feder 2018-07-22 870 * ---------------------------- 4a965c5f89decd Jacob Feder 2018-07-22 871 */ 4a965c5f89decd Jacob Feder 2018-07-22 872 ed6daf2b2832d9 Quentin Deslandes 2019-11-01 873 rc = axis_fifo_parse_dt(fifo); 4a965c5f89decd Jacob Feder 2018-07-22 874 if (rc) 6a20d283ed6867 Quentin Deslandes 2019-11-01 875 goto err_initial; 4a965c5f89decd Jacob Feder 2018-07-22 876 4a965c5f89decd Jacob Feder 2018-07-22 877 reset_ip_core(fifo); 4a965c5f89decd Jacob Feder 2018-07-22 878 4a965c5f89decd Jacob Feder 2018-07-22 879 /* ---------------------------- 4a965c5f89decd Jacob Feder 2018-07-22 880 * init device interrupts 4a965c5f89decd Jacob Feder 2018-07-22 881 * ---------------------------- 4a965c5f89decd Jacob Feder 2018-07-22 882 */ 4a965c5f89decd Jacob Feder 2018-07-22 883 4a965c5f89decd Jacob Feder 2018-07-22 884 /* get IRQ resource */ 4a965c5f89decd Jacob Feder 2018-07-22 885 r_irq = platform_get_resource(pdev, IORESOURCE_IRQ, 0); 4a965c5f89decd Jacob Feder 2018-07-22 886 if (!r_irq) { 4a965c5f89decd Jacob Feder 2018-07-22 887 dev_err(fifo->dt_device, "no IRQ found for 0x%pa\n", 354e27a86b4c64 Quentin Deslandes 2019-11-01 888 &r_mem->start); 4a965c5f89decd Jacob Feder 2018-07-22 889 rc = -EIO; 6a20d283ed6867 Quentin Deslandes 2019-11-01 890 goto err_initial; 4a965c5f89decd Jacob Feder 2018-07-22 891 } 4a965c5f89decd Jacob Feder 2018-07-22 892 4a965c5f89decd Jacob Feder 2018-07-22 893 /* request IRQ */ 4a965c5f89decd Jacob Feder 2018-07-22 894 fifo->irq = r_irq->start; 6a20d283ed6867 Quentin Deslandes 2019-11-01 895 rc = devm_request_irq(fifo->dt_device, fifo->irq, &axis_fifo_irq, 0, 6a20d283ed6867 Quentin Deslandes 2019-11-01 896 DRIVER_NAME, fifo); 4a965c5f89decd Jacob Feder 2018-07-22 897 if (rc) { 4a965c5f89decd Jacob Feder 2018-07-22 898 dev_err(fifo->dt_device, "couldn't allocate interrupt %i\n", 4a965c5f89decd Jacob Feder 2018-07-22 899 fifo->irq); 6a20d283ed6867 Quentin Deslandes 2019-11-01 900 goto err_initial; 4a965c5f89decd Jacob Feder 2018-07-22 901 } 4a965c5f89decd Jacob Feder 2018-07-22 902 4a965c5f89decd Jacob Feder 2018-07-22 903 /* ---------------------------- 4a965c5f89decd Jacob Feder 2018-07-22 904 * init char device 4a965c5f89decd Jacob Feder 2018-07-22 905 * ---------------------------- 4a965c5f89decd Jacob Feder 2018-07-22 906 */ 4a965c5f89decd Jacob Feder 2018-07-22 907 4a965c5f89decd Jacob Feder 2018-07-22 908 /* allocate device number */ 4a965c5f89decd Jacob Feder 2018-07-22 909 rc = alloc_chrdev_region(&fifo->devt, 0, 1, DRIVER_NAME); 4a965c5f89decd Jacob Feder 2018-07-22 910 if (rc < 0) 6a20d283ed6867 Quentin Deslandes 2019-11-01 911 goto err_initial; 4a965c5f89decd Jacob Feder 2018-07-22 912 dev_dbg(fifo->dt_device, "allocated device number major %i minor %i\n", 4a965c5f89decd Jacob Feder 2018-07-22 913 MAJOR(fifo->devt), MINOR(fifo->devt)); 4a965c5f89decd Jacob Feder 2018-07-22 914 4a965c5f89decd Jacob Feder 2018-07-22 915 /* create driver file */ 4a965c5f89decd Jacob Feder 2018-07-22 916 fifo->device = device_create(axis_fifo_driver_class, NULL, fifo->devt, 4a965c5f89decd Jacob Feder 2018-07-22 917 NULL, device_name); 6d4abf1c0e265d Wei Yongjun 2018-07-27 918 if (IS_ERR(fifo->device)) { 4a965c5f89decd Jacob Feder 2018-07-22 919 dev_err(fifo->dt_device, 4a965c5f89decd Jacob Feder 2018-07-22 920 "couldn't create driver file\n"); 6d4abf1c0e265d Wei Yongjun 2018-07-27 921 rc = PTR_ERR(fifo->device); 4a965c5f89decd Jacob Feder 2018-07-22 922 goto err_chrdev_region; 4a965c5f89decd Jacob Feder 2018-07-22 923 } 4a965c5f89decd Jacob Feder 2018-07-22 924 dev_set_drvdata(fifo->device, fifo); 4a965c5f89decd Jacob Feder 2018-07-22 925 4a965c5f89decd Jacob Feder 2018-07-22 926 /* create character device */ 4a965c5f89decd Jacob Feder 2018-07-22 927 cdev_init(&fifo->char_device, &fops); 4a965c5f89decd Jacob Feder 2018-07-22 928 rc = cdev_add(&fifo->char_device, fifo->devt, 1); 4a965c5f89decd Jacob Feder 2018-07-22 929 if (rc < 0) { 4a965c5f89decd Jacob Feder 2018-07-22 930 dev_err(fifo->dt_device, "couldn't create character device\n"); 4a965c5f89decd Jacob Feder 2018-07-22 931 goto err_dev; 4a965c5f89decd Jacob Feder 2018-07-22 932 } 4a965c5f89decd Jacob Feder 2018-07-22 933 4a965c5f89decd Jacob Feder 2018-07-22 934 /* create sysfs entries */ 6a20d283ed6867 Quentin Deslandes 2019-11-01 935 rc = devm_device_add_group(fifo->device, &axis_fifo_attrs_group); 4a965c5f89decd Jacob Feder 2018-07-22 936 if (rc < 0) { 4a965c5f89decd Jacob Feder 2018-07-22 937 dev_err(fifo->dt_device, "couldn't register sysfs group\n"); 4a965c5f89decd Jacob Feder 2018-07-22 938 goto err_cdev; 4a965c5f89decd Jacob Feder 2018-07-22 939 } 4a965c5f89decd Jacob Feder 2018-07-22 940 4a965c5f89decd Jacob Feder 2018-07-22 941 dev_info(fifo->dt_device, "axis-fifo created at %pa mapped to 0x%pa, irq=%i, major=%i, minor=%i\n", 354e27a86b4c64 Quentin Deslandes 2019-11-01 942 &r_mem->start, &fifo->base_addr, fifo->irq, 4a965c5f89decd Jacob Feder 2018-07-22 943 MAJOR(fifo->devt), MINOR(fifo->devt)); 4a965c5f89decd Jacob Feder 2018-07-22 944 4a965c5f89decd Jacob Feder 2018-07-22 945 return 0; 4a965c5f89decd Jacob Feder 2018-07-22 946 4a965c5f89decd Jacob Feder 2018-07-22 947 err_cdev: 4a965c5f89decd Jacob Feder 2018-07-22 948 cdev_del(&fifo->char_device); 4a965c5f89decd Jacob Feder 2018-07-22 949 err_dev: 4a965c5f89decd Jacob Feder 2018-07-22 950 device_destroy(axis_fifo_driver_class, fifo->devt); 4a965c5f89decd Jacob Feder 2018-07-22 951 err_chrdev_region: 4a965c5f89decd Jacob Feder 2018-07-22 952 unregister_chrdev_region(fifo->devt, 1); 4a965c5f89decd Jacob Feder 2018-07-22 953 err_initial: 4a965c5f89decd Jacob Feder 2018-07-22 954 dev_set_drvdata(dev, NULL); 4a965c5f89decd Jacob Feder 2018-07-22 955 return rc; 4a965c5f89decd Jacob Feder 2018-07-22 956 } 4a965c5f89decd Jacob Feder 2018-07-22 957 :::::: The code at line 864 was first introduced by commit :::::: 354e27a86b4c6479cbc51a8e9e347665a73e8d12 staging: axis-fifo: remove unused pointer to memory resource :::::: TO: Quentin Deslandes <[email protected]> :::::: CC: Greg Kroah-Hartman <[email protected]> --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/[email protected]
.config.gz
Description: application/gzip
_______________________________________________ kbuild mailing list -- [email protected] To unsubscribe send an email to [email protected]
