CC: [email protected] CC: [email protected] TO: Dave Stevenson <[email protected]> CC: Mauro Carvalho Chehab <[email protected]> CC: [email protected] CC: Andrey Konovalov <[email protected]> CC: Sakari Ailus <[email protected]>
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master head: 18445bf405cb331117bc98427b1ba6f12418ad17 commit: 1283b3b8f82b9004fbb94398cade5c8e797a2c8d media: i2c: Add driver for Sony IMX219 sensor date: 6 months ago :::::: branch date: 34 hours ago :::::: commit date: 6 months ago compiler: gcc-9 (Debian 9.3.0-15) 9.3.0 If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot <[email protected]> cppcheck warnings: (new ones prefixed by >>) >> drivers/media/i2c/imx219.c:1163:6: warning: Variable 'ret' is reassigned a >> value before the old one has been used. [redundantAssignment] ret = 0; ^ drivers/media/i2c/imx219.c:1131:0: note: Variable 'ret' is reassigned a value before the old one has been used. int ret = -EINVAL; ^ drivers/media/i2c/imx219.c:1163:6: note: Variable 'ret' is reassigned a value before the old one has been used. ret = 0; ^ # https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=1283b3b8f82b9004fbb94398cade5c8e797a2c8d git remote add linus https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git git fetch --no-tags linus master git checkout 1283b3b8f82b9004fbb94398cade5c8e797a2c8d vim +/ret +1163 drivers/media/i2c/imx219.c 1283b3b8f82b90 Dave Stevenson 2020-01-20 1124 1283b3b8f82b90 Dave Stevenson 2020-01-20 1125 static int imx219_check_hwcfg(struct device *dev) 1283b3b8f82b90 Dave Stevenson 2020-01-20 1126 { 1283b3b8f82b90 Dave Stevenson 2020-01-20 1127 struct fwnode_handle *endpoint; 1283b3b8f82b90 Dave Stevenson 2020-01-20 1128 struct v4l2_fwnode_endpoint ep_cfg = { 1283b3b8f82b90 Dave Stevenson 2020-01-20 1129 .bus_type = V4L2_MBUS_CSI2_DPHY 1283b3b8f82b90 Dave Stevenson 2020-01-20 1130 }; 1283b3b8f82b90 Dave Stevenson 2020-01-20 1131 int ret = -EINVAL; 1283b3b8f82b90 Dave Stevenson 2020-01-20 1132 1283b3b8f82b90 Dave Stevenson 2020-01-20 1133 endpoint = fwnode_graph_get_next_endpoint(dev_fwnode(dev), NULL); 1283b3b8f82b90 Dave Stevenson 2020-01-20 1134 if (!endpoint) { 1283b3b8f82b90 Dave Stevenson 2020-01-20 1135 dev_err(dev, "endpoint node not found\n"); 1283b3b8f82b90 Dave Stevenson 2020-01-20 1136 return -EINVAL; 1283b3b8f82b90 Dave Stevenson 2020-01-20 1137 } 1283b3b8f82b90 Dave Stevenson 2020-01-20 1138 1283b3b8f82b90 Dave Stevenson 2020-01-20 1139 if (v4l2_fwnode_endpoint_alloc_parse(endpoint, &ep_cfg)) { 1283b3b8f82b90 Dave Stevenson 2020-01-20 1140 dev_err(dev, "could not parse endpoint\n"); 1283b3b8f82b90 Dave Stevenson 2020-01-20 1141 goto error_out; 1283b3b8f82b90 Dave Stevenson 2020-01-20 1142 } 1283b3b8f82b90 Dave Stevenson 2020-01-20 1143 1283b3b8f82b90 Dave Stevenson 2020-01-20 1144 /* Check the number of MIPI CSI2 data lanes */ 1283b3b8f82b90 Dave Stevenson 2020-01-20 1145 if (ep_cfg.bus.mipi_csi2.num_data_lanes != 2) { 1283b3b8f82b90 Dave Stevenson 2020-01-20 1146 dev_err(dev, "only 2 data lanes are currently supported\n"); 1283b3b8f82b90 Dave Stevenson 2020-01-20 1147 goto error_out; 1283b3b8f82b90 Dave Stevenson 2020-01-20 1148 } 1283b3b8f82b90 Dave Stevenson 2020-01-20 1149 1283b3b8f82b90 Dave Stevenson 2020-01-20 1150 /* Check the link frequency set in device tree */ 1283b3b8f82b90 Dave Stevenson 2020-01-20 1151 if (!ep_cfg.nr_of_link_frequencies) { 1283b3b8f82b90 Dave Stevenson 2020-01-20 1152 dev_err(dev, "link-frequency property not found in DT\n"); 1283b3b8f82b90 Dave Stevenson 2020-01-20 1153 goto error_out; 1283b3b8f82b90 Dave Stevenson 2020-01-20 1154 } 1283b3b8f82b90 Dave Stevenson 2020-01-20 1155 1283b3b8f82b90 Dave Stevenson 2020-01-20 1156 if (ep_cfg.nr_of_link_frequencies != 1 || 1283b3b8f82b90 Dave Stevenson 2020-01-20 1157 ep_cfg.link_frequencies[0] != IMX219_DEFAULT_LINK_FREQ) { 1283b3b8f82b90 Dave Stevenson 2020-01-20 1158 dev_err(dev, "Link frequency not supported: %lld\n", 1283b3b8f82b90 Dave Stevenson 2020-01-20 1159 ep_cfg.link_frequencies[0]); 1283b3b8f82b90 Dave Stevenson 2020-01-20 1160 goto error_out; 1283b3b8f82b90 Dave Stevenson 2020-01-20 1161 } 1283b3b8f82b90 Dave Stevenson 2020-01-20 1162 1283b3b8f82b90 Dave Stevenson 2020-01-20 @1163 ret = 0; 1283b3b8f82b90 Dave Stevenson 2020-01-20 1164 1283b3b8f82b90 Dave Stevenson 2020-01-20 1165 error_out: 1283b3b8f82b90 Dave Stevenson 2020-01-20 1166 v4l2_fwnode_endpoint_free(&ep_cfg); 1283b3b8f82b90 Dave Stevenson 2020-01-20 1167 fwnode_handle_put(endpoint); 1283b3b8f82b90 Dave Stevenson 2020-01-20 1168 1283b3b8f82b90 Dave Stevenson 2020-01-20 1169 return ret; 1283b3b8f82b90 Dave Stevenson 2020-01-20 1170 } 1283b3b8f82b90 Dave Stevenson 2020-01-20 1171 --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/[email protected] _______________________________________________ kbuild mailing list -- [email protected] To unsubscribe send an email to [email protected]
