CC: [email protected] CC: [email protected] TO: "Horia Geantă" <[email protected]> CC: Herbert Xu <[email protected]> CC: Aymen Sghaier <[email protected]> CC: [email protected] CC: [email protected]
From: kernel test robot <[email protected]> drivers/crypto/caam/debugfs.c:22:0-23: WARNING: caam_fops_u32_ro should be defined with DEFINE_DEBUGFS_ATTRIBUTE drivers/crypto/caam/debugfs.c:23:0-23: WARNING: caam_fops_u64_ro should be defined with DEFINE_DEBUGFS_ATTRIBUTE Use DEFINE_DEBUGFS_ATTRIBUTE rather than DEFINE_SIMPLE_ATTRIBUTE for debugfs files. Semantic patch information: Rationale: DEFINE_SIMPLE_ATTRIBUTE + debugfs_create_file() imposes some significant overhead as compared to DEFINE_DEBUGFS_ATTRIBUTE + debugfs_create_file_unsafe(). Generated by: scripts/coccinelle/api/debugfs/debugfs_simple_attr.cocci Fixes: abd9875497ba ("crypto: caam - Move debugfs fops into standalone file") CC: Horia Geantă <[email protected]> Signed-off-by: kernel test robot <[email protected]> --- tree: https://git.kernel.org/pub/scm/linux/kernel/git/herbert/cryptodev-2.6.git master head: 3d29e98d1d7550fc959a7ad4258bd804b533b493 commit: abd9875497ba47e198fb565f11d5f332eeb08ab3 [20/35] crypto: caam - Move debugfs fops into standalone file :::::: branch date: 7 hours ago :::::: commit date: 7 hours ago Please take the patch only if it's a positive warning. Thanks! debugfs.c | 51 +++++++++++++++++++++++++++------------------------ 1 file changed, 27 insertions(+), 24 deletions(-) --- a/drivers/crypto/caam/debugfs.c +++ b/drivers/crypto/caam/debugfs.c @@ -19,8 +19,10 @@ static int caam_debugfs_u32_get(void *da return 0; } -DEFINE_SIMPLE_ATTRIBUTE(caam_fops_u32_ro, caam_debugfs_u32_get, NULL, "%llu\n"); -DEFINE_SIMPLE_ATTRIBUTE(caam_fops_u64_ro, caam_debugfs_u64_get, NULL, "%llu\n"); +DEFINE_DEBUGFS_ATTRIBUTE(caam_fops_u32_ro, caam_debugfs_u32_get, NULL, + "%llu\n"); +DEFINE_DEBUGFS_ATTRIBUTE(caam_fops_u64_ro, caam_debugfs_u64_get, NULL, + "%llu\n"); #ifdef CONFIG_CAAM_QI /* @@ -37,8 +39,8 @@ void caam_debugfs_qi_congested(void) void caam_debugfs_qi_init(struct caam_drv_private *ctrlpriv) { - debugfs_create_file("qi_congested", 0444, ctrlpriv->ctl, - ×_congested, &caam_fops_u64_ro); + debugfs_create_file_unsafe("qi_congested", 0444, ctrlpriv->ctl, + ×_congested, &caam_fops_u64_ro); } #endif @@ -55,28 +57,29 @@ void caam_debugfs_init(struct caam_drv_p ctrlpriv->ctl = debugfs_create_dir("ctl", root); - debugfs_create_file("rq_dequeued", 0444, ctrlpriv->ctl, - &perfmon->req_dequeued, &caam_fops_u64_ro); - debugfs_create_file("ob_rq_encrypted", 0444, ctrlpriv->ctl, - &perfmon->ob_enc_req, &caam_fops_u64_ro); - debugfs_create_file("ib_rq_decrypted", 0444, ctrlpriv->ctl, - &perfmon->ib_dec_req, &caam_fops_u64_ro); - debugfs_create_file("ob_bytes_encrypted", 0444, ctrlpriv->ctl, - &perfmon->ob_enc_bytes, &caam_fops_u64_ro); - debugfs_create_file("ob_bytes_protected", 0444, ctrlpriv->ctl, - &perfmon->ob_prot_bytes, &caam_fops_u64_ro); - debugfs_create_file("ib_bytes_decrypted", 0444, ctrlpriv->ctl, - &perfmon->ib_dec_bytes, &caam_fops_u64_ro); - debugfs_create_file("ib_bytes_validated", 0444, ctrlpriv->ctl, - &perfmon->ib_valid_bytes, &caam_fops_u64_ro); + debugfs_create_file_unsafe("rq_dequeued", 0444, ctrlpriv->ctl, + &perfmon->req_dequeued, &caam_fops_u64_ro); + debugfs_create_file_unsafe("ob_rq_encrypted", 0444, ctrlpriv->ctl, + &perfmon->ob_enc_req, &caam_fops_u64_ro); + debugfs_create_file_unsafe("ib_rq_decrypted", 0444, ctrlpriv->ctl, + &perfmon->ib_dec_req, &caam_fops_u64_ro); + debugfs_create_file_unsafe("ob_bytes_encrypted", 0444, ctrlpriv->ctl, + &perfmon->ob_enc_bytes, &caam_fops_u64_ro); + debugfs_create_file_unsafe("ob_bytes_protected", 0444, ctrlpriv->ctl, + &perfmon->ob_prot_bytes, &caam_fops_u64_ro); + debugfs_create_file_unsafe("ib_bytes_decrypted", 0444, ctrlpriv->ctl, + &perfmon->ib_dec_bytes, &caam_fops_u64_ro); + debugfs_create_file_unsafe("ib_bytes_validated", 0444, ctrlpriv->ctl, + &perfmon->ib_valid_bytes, + &caam_fops_u64_ro); /* Controller level - global status values */ - debugfs_create_file("fault_addr", 0444, ctrlpriv->ctl, - &perfmon->faultaddr, &caam_fops_u32_ro); - debugfs_create_file("fault_detail", 0444, ctrlpriv->ctl, - &perfmon->faultdetail, &caam_fops_u32_ro); - debugfs_create_file("fault_status", 0444, ctrlpriv->ctl, - &perfmon->status, &caam_fops_u32_ro); + debugfs_create_file_unsafe("fault_addr", 0444, ctrlpriv->ctl, + &perfmon->faultaddr, &caam_fops_u32_ro); + debugfs_create_file_unsafe("fault_detail", 0444, ctrlpriv->ctl, + &perfmon->faultdetail, &caam_fops_u32_ro); + debugfs_create_file_unsafe("fault_status", 0444, ctrlpriv->ctl, + &perfmon->status, &caam_fops_u32_ro); /* Internal covering keys (useful in non-secure mode only) */ ctrlpriv->ctl_kek_wrap.data = (__force void *)&ctrlpriv->ctrl->kek[0]; _______________________________________________ kbuild mailing list -- [email protected] To unsubscribe send an email to [email protected]
