CC: [email protected] CC: [email protected] CC: [email protected] TO: Maarten Lankhorst <[email protected]> CC: "Thomas Hellström" <[email protected]>
tree: git://anongit.freedesktop.org/drm-intel topic/drm-intel-gem-next head: 19029a5b66d0e1f01dcfa5b70a3ab57e7bf538f5 commit: 4ceeb1b110068192b4c44ae0b621b9f92fcf2bb8 [5/24] drm/i915: Add an implementation for i915_gem_ww_ctx locking, v2. :::::: branch date: 5 days ago :::::: commit date: 5 days ago config: i386-randconfig-m021-20200826 (attached as .config) compiler: gcc-9 (Debian 9.3.0-15) 9.3.0 If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot <[email protected]> Reported-by: Dan Carpenter <[email protected]> New smatch warnings: drivers/gpu/drm/i915/gem/i915_gem_object.h:130 __i915_gem_object_lock() error: we previously assumed 'ww' could be null (see line 122) drivers/gpu/drm/i915/gem/i915_gem_object.h:130 __i915_gem_object_lock() error: we previously assumed 'ww' could be null (see line 122) drivers/gpu/drm/i915/gem/i915_gem_object.h:130 __i915_gem_object_lock() error: we previously assumed 'ww' could be null (see line 122) Old smatch warnings: drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c:1172 reloc_move_to_gpu() warn: maybe use && instead of & drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c:1343 vma_phys_addr() warn: right shifting more than type allows 32 vs 32 drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c:1987 eb_move_to_gpu() warn: maybe use && instead of & drivers/gpu/drm/i915/gt/intel_context.h:152 intel_context_timeline_lock() warn: inconsistent returns 'tl->mutex'. drivers/gpu/drm/i915/gem/i915_gem_context.h:205 i915_gem_context_get_engine() warn: inconsistent indenting drivers/gpu/drm/i915/gem/i915_gem_context.h:207 i915_gem_context_get_engine() warn: inconsistent indenting drivers/gpu/drm/i915/display/intel_display.c:6183 skl_update_scaler_plane() error: we previously assumed 'fb' could be null (see line 6167) drivers/gpu/drm/i915/display/intel_display.c:16652 intel_crtc_init() warn: passing a valid pointer to 'PTR_ERR' git remote add drm-intel git://anongit.freedesktop.org/drm-intel git fetch --no-tags drm-intel topic/drm-intel-gem-next git checkout 4ceeb1b110068192b4c44ae0b621b9f92fcf2bb8 vim +/ww +130 drivers/gpu/drm/i915/gem/i915_gem_object.h 6951e5893b4821 drivers/gpu/drm/i915/gem/i915_gem_object.h Chris Wilson 2019-05-28 112 4ceeb1b1100681 drivers/gpu/drm/i915/gem/i915_gem_object.h Maarten Lankhorst 2020-08-19 113 static inline int __i915_gem_object_lock(struct drm_i915_gem_object *obj, 4ceeb1b1100681 drivers/gpu/drm/i915/gem/i915_gem_object.h Maarten Lankhorst 2020-08-19 114 struct i915_gem_ww_ctx *ww, 4ceeb1b1100681 drivers/gpu/drm/i915/gem/i915_gem_object.h Maarten Lankhorst 2020-08-19 115 bool intr) dd689287b97759 drivers/gpu/drm/i915/i915_gem_object.h Chris Wilson 2017-03-01 116 { 4ceeb1b1100681 drivers/gpu/drm/i915/gem/i915_gem_object.h Maarten Lankhorst 2020-08-19 117 int ret; 4ceeb1b1100681 drivers/gpu/drm/i915/gem/i915_gem_object.h Maarten Lankhorst 2020-08-19 118 4ceeb1b1100681 drivers/gpu/drm/i915/gem/i915_gem_object.h Maarten Lankhorst 2020-08-19 119 if (intr) 4ceeb1b1100681 drivers/gpu/drm/i915/gem/i915_gem_object.h Maarten Lankhorst 2020-08-19 120 ret = dma_resv_lock_interruptible(obj->base.resv, ww ? &ww->ctx : NULL); 4ceeb1b1100681 drivers/gpu/drm/i915/gem/i915_gem_object.h Maarten Lankhorst 2020-08-19 121 else 4ceeb1b1100681 drivers/gpu/drm/i915/gem/i915_gem_object.h Maarten Lankhorst 2020-08-19 @122 ret = dma_resv_lock(obj->base.resv, ww ? &ww->ctx : NULL); 4ceeb1b1100681 drivers/gpu/drm/i915/gem/i915_gem_object.h Maarten Lankhorst 2020-08-19 123 4ceeb1b1100681 drivers/gpu/drm/i915/gem/i915_gem_object.h Maarten Lankhorst 2020-08-19 124 if (!ret && ww) 4ceeb1b1100681 drivers/gpu/drm/i915/gem/i915_gem_object.h Maarten Lankhorst 2020-08-19 125 list_add_tail(&obj->obj_link, &ww->obj_list); 4ceeb1b1100681 drivers/gpu/drm/i915/gem/i915_gem_object.h Maarten Lankhorst 2020-08-19 126 if (ret == -EALREADY) 4ceeb1b1100681 drivers/gpu/drm/i915/gem/i915_gem_object.h Maarten Lankhorst 2020-08-19 127 ret = 0; 4ceeb1b1100681 drivers/gpu/drm/i915/gem/i915_gem_object.h Maarten Lankhorst 2020-08-19 128 4ceeb1b1100681 drivers/gpu/drm/i915/gem/i915_gem_object.h Maarten Lankhorst 2020-08-19 129 if (ret == -EDEADLK) 4ceeb1b1100681 drivers/gpu/drm/i915/gem/i915_gem_object.h Maarten Lankhorst 2020-08-19 @130 ww->contended = obj; 4ceeb1b1100681 drivers/gpu/drm/i915/gem/i915_gem_object.h Maarten Lankhorst 2020-08-19 131 4ceeb1b1100681 drivers/gpu/drm/i915/gem/i915_gem_object.h Maarten Lankhorst 2020-08-19 132 return ret; dd689287b97759 drivers/gpu/drm/i915/i915_gem_object.h Chris Wilson 2017-03-01 133 } dd689287b97759 drivers/gpu/drm/i915/i915_gem_object.h Chris Wilson 2017-03-01 134 --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/[email protected]
.config.gz
Description: application/gzip
_______________________________________________ kbuild mailing list -- [email protected] To unsubscribe send an email to [email protected]
