CC: [email protected] CC: "Darrick J. Wong" <[email protected]> TO: "Darrick J. Wong" <[email protected]>
tree: https://git.kernel.org/pub/scm/linux/kernel/git/djwong/xfs-linux.git scrub-fixes head: 07d5b2cedf371d30ed7c6477dd97a9c8ef178c34 commit: 5a070aefbb3d00a71fd175bf6e48a2a4d047f005 [87/182] xfs: introduce a swap-extent log intent item :::::: branch date: 6 hours ago :::::: commit date: 6 hours ago config: h8300-randconfig-c003-20200826 (attached as .config) compiler: h8300-linux-gcc (GCC) 9.3.0 If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot <[email protected]> Reported-by: Julia Lawall <[email protected]> coccinelle warnings: (new ones prefixed by >>) >> fs/xfs/xfs_swapext_item.c:56:5-24: atomic_dec_and_test variation before >> object free at line 57. # https://git.kernel.org/pub/scm/linux/kernel/git/djwong/xfs-linux.git/commit/?id=5a070aefbb3d00a71fd175bf6e48a2a4d047f005 git remote add djwong-xfs https://git.kernel.org/pub/scm/linux/kernel/git/djwong/xfs-linux.git git fetch --no-tags djwong-xfs scrub-fixes git checkout 5a070aefbb3d00a71fd175bf6e48a2a4d047f005 vim +56 fs/xfs/xfs_swapext_item.c 5a070aefbb3d00 Darrick J. Wong 2020-06-25 43 5a070aefbb3d00 Darrick J. Wong 2020-06-25 44 /* 5a070aefbb3d00 Darrick J. Wong 2020-06-25 45 * Freeing the SXI requires that we remove it from the AIL if it has already 5a070aefbb3d00 Darrick J. Wong 2020-06-25 46 * been placed there. However, the SXI may not yet have been placed in the AIL 5a070aefbb3d00 Darrick J. Wong 2020-06-25 47 * when called by xfs_sxi_release() from SXD processing due to the ordering of 5a070aefbb3d00 Darrick J. Wong 2020-06-25 48 * committed vs unpin operations in bulk insert operations. Hence the reference 5a070aefbb3d00 Darrick J. Wong 2020-06-25 49 * count to ensure only the last caller frees the SXI. 5a070aefbb3d00 Darrick J. Wong 2020-06-25 50 */ 5a070aefbb3d00 Darrick J. Wong 2020-06-25 51 STATIC void 5a070aefbb3d00 Darrick J. Wong 2020-06-25 52 xfs_sxi_release( 5a070aefbb3d00 Darrick J. Wong 2020-06-25 53 struct xfs_sxi_log_item *sxi_lip) 5a070aefbb3d00 Darrick J. Wong 2020-06-25 54 { 5a070aefbb3d00 Darrick J. Wong 2020-06-25 55 ASSERT(atomic_read(&sxi_lip->sxi_refcount) > 0); 5a070aefbb3d00 Darrick J. Wong 2020-06-25 @56 if (atomic_dec_and_test(&sxi_lip->sxi_refcount)) { 5a070aefbb3d00 Darrick J. Wong 2020-06-25 @57 xfs_trans_ail_delete(&sxi_lip->sxi_item, SHUTDOWN_LOG_IO_ERROR); 5a070aefbb3d00 Darrick J. Wong 2020-06-25 58 xfs_sxi_item_free(sxi_lip); 5a070aefbb3d00 Darrick J. Wong 2020-06-25 59 } 5a070aefbb3d00 Darrick J. Wong 2020-06-25 60 } 5a070aefbb3d00 Darrick J. Wong 2020-06-25 61 --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/[email protected]
.config.gz
Description: application/gzip
_______________________________________________ kbuild mailing list -- [email protected] To unsubscribe send an email to [email protected]
