CC: [email protected]
In-Reply-To: 
<cdd26d104000c060d85a0c5f8abe8492e4103de5.1597381889.git.mallikarjunax.re...@linux.intel.com>
References: 
<cdd26d104000c060d85a0c5f8abe8492e4103de5.1597381889.git.mallikarjunax.re...@linux.intel.com>
TO: Amireddy Mallikarjuna reddy <[email protected]>
TO: [email protected]
TO: [email protected]
TO: [email protected]
TO: [email protected]
CC: [email protected]
CC: [email protected]
CC: [email protected]
CC: [email protected]
CC: [email protected]
CC: [email protected]

Hi Amireddy,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on vkoul-dmaengine/next]
[also build test WARNING on v5.9-rc2 next-20200826]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    
https://github.com/0day-ci/linux/commits/Amireddy-Mallikarjuna-reddy/Add-Intel-LGM-soc-DMA-support/20200814-134726
base:   https://git.kernel.org/pub/scm/linux/kernel/git/vkoul/dmaengine.git next
:::::: branch date: 13 days ago
:::::: commit date: 13 days ago
config: i386-randconfig-c001-20200826 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-15) 9.3.0

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <[email protected]>
Reported-by: Julia Lawall <[email protected]>


coccinelle warnings: (new ones prefixed by >>)

>> drivers/dma/lgm/lgm-dma.c:1285:4-10: preceding lock on line 1277

# 
https://github.com/0day-ci/linux/commit/db4132717064573dc2ae130ef1bc71bcee3bb33a
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review 
Amireddy-Mallikarjuna-reddy/Add-Intel-LGM-soc-DMA-support/20200814-134726
git checkout db4132717064573dc2ae130ef1bc71bcee3bb33a
vim +1285 drivers/dma/lgm/lgm-dma.c

db413271706457 Amireddy Mallikarjuna reddy 2020-08-14  1269  
db413271706457 Amireddy Mallikarjuna reddy 2020-08-14  1270  static void 
dma_issue_pending(struct dma_chan *chan)
db413271706457 Amireddy Mallikarjuna reddy 2020-08-14  1271  {
db413271706457 Amireddy Mallikarjuna reddy 2020-08-14  1272     struct 
ldma_chan *c = to_ldma_chan(chan);
db413271706457 Amireddy Mallikarjuna reddy 2020-08-14  1273     struct ldma_dev 
*d = to_ldma_dev(c->vchan.chan.device);
db413271706457 Amireddy Mallikarjuna reddy 2020-08-14  1274     unsigned long 
flags;
db413271706457 Amireddy Mallikarjuna reddy 2020-08-14  1275  
db413271706457 Amireddy Mallikarjuna reddy 2020-08-14  1276     if (d->ver == 
DMA_VER22) {
db413271706457 Amireddy Mallikarjuna reddy 2020-08-14 @1277             
spin_lock_irqsave(&c->vchan.lock, flags);
db413271706457 Amireddy Mallikarjuna reddy 2020-08-14  1278             if 
(vchan_issue_pending(&c->vchan)) {
db413271706457 Amireddy Mallikarjuna reddy 2020-08-14  1279                     
struct virt_dma_desc *vdesc;
db413271706457 Amireddy Mallikarjuna reddy 2020-08-14  1280  
db413271706457 Amireddy Mallikarjuna reddy 2020-08-14  1281                     
/* Get the next descriptor */
db413271706457 Amireddy Mallikarjuna reddy 2020-08-14  1282                     
vdesc = vchan_next_desc(&c->vchan);
db413271706457 Amireddy Mallikarjuna reddy 2020-08-14  1283                     
if (!vdesc) {
db413271706457 Amireddy Mallikarjuna reddy 2020-08-14  1284                     
        c->ds = NULL;
db413271706457 Amireddy Mallikarjuna reddy 2020-08-14 @1285                     
        return;
db413271706457 Amireddy Mallikarjuna reddy 2020-08-14  1286                     
}
db413271706457 Amireddy Mallikarjuna reddy 2020-08-14  1287                     
list_del(&vdesc->node);
db413271706457 Amireddy Mallikarjuna reddy 2020-08-14  1288                     
c->ds = to_lgm_dma_desc(vdesc);
db413271706457 Amireddy Mallikarjuna reddy 2020-08-14  1289                     
spin_unlock_irqrestore(&c->vchan.lock, flags);
db413271706457 Amireddy Mallikarjuna reddy 2020-08-14  1290                     
ldma_chan_desc_hw_cfg(c, c->ds->desc_phys, c->ds->desc_cnt);
db413271706457 Amireddy Mallikarjuna reddy 2020-08-14  1291                     
ldma_chan_irq_en(c);
db413271706457 Amireddy Mallikarjuna reddy 2020-08-14  1292             }
db413271706457 Amireddy Mallikarjuna reddy 2020-08-14  1293     }
db413271706457 Amireddy Mallikarjuna reddy 2020-08-14  1294     ldma_chan_on(c);
db413271706457 Amireddy Mallikarjuna reddy 2020-08-14  1295  }
db413271706457 Amireddy Mallikarjuna reddy 2020-08-14  1296  

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/[email protected]

Attachment: .config.gz
Description: application/gzip

_______________________________________________
kbuild mailing list -- [email protected]
To unsubscribe send an email to [email protected]

Reply via email to