CC: [email protected]
In-Reply-To: <[email protected]>
References: <[email protected]>
TO: "Marek Behún" <[email protected]>
TO: [email protected]
CC: Russell King <[email protected]>
CC: Andrew Lunn <[email protected]>
CC: Florian Fainelli <[email protected]>
CC: Vivien Didelot <[email protected]>
CC: "Marek Behún" <[email protected]>

Hi "Marek,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on net-next/master]

url:    
https://github.com/0day-ci/linux/commits/Marek-Beh-n/net-dsa-mv88e6xxx-Add-Amethyst-88E6393X/20200819-234008
base:   https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git 
e3ec1e8ca02b7e6c935bba3f9b6da86c2e57d2eb
:::::: branch date: 8 days ago
:::::: commit date: 8 days ago
config: openrisc-randconfig-m031-20200827 (attached as .config)
compiler: or1k-linux-gcc (GCC) 9.3.0

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <[email protected]>
Reported-by: Dan Carpenter <[email protected]>

New smatch warnings:
drivers/net/dsa/mv88e6xxx/serdes.c:547 mv88e6393x_serdes_get_lane() warn: 
impossible condition '(*lane == -1) => (0-255 == (-1))'

Old smatch warnings:
drivers/net/dsa/mv88e6xxx/serdes.c:428 mv88e6341_serdes_get_lane() warn: 
impossible condition '(*lane == -1) => (0-255 == (-1))'
drivers/net/dsa/mv88e6xxx/serdes.c:451 mv88e6390_serdes_get_lane() warn: 
impossible condition '(*lane == -1) => (0-255 == (-1))'
drivers/net/dsa/mv88e6xxx/serdes.c:526 mv88e6390x_serdes_get_lane() warn: 
impossible condition '(*lane == -1) => (0-255 == (-1))'

# 
https://github.com/0day-ci/linux/commit/ec03405fdc7e66a29e2fdec65eadc261b10d441d
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review 
Marek-Beh-n/net-dsa-mv88e6xxx-Add-Amethyst-88E6393X/20200819-234008
git checkout ec03405fdc7e66a29e2fdec65eadc261b10d441d
vim +547 drivers/net/dsa/mv88e6xxx/serdes.c

a8c01c0d941d2f Andrew Lunn 2018-08-09  528  
ec03405fdc7e66 Marek Behún 2020-08-19  529  int 
mv88e6393x_serdes_get_lane(struct mv88e6xxx_chip *chip, int port, u8 *lane)
ec03405fdc7e66 Marek Behún 2020-08-19  530  {
ec03405fdc7e66 Marek Behún 2020-08-19  531      u8 cmode = 
chip->ports[port].cmode;
ec03405fdc7e66 Marek Behún 2020-08-19  532  
ec03405fdc7e66 Marek Behún 2020-08-19  533      *lane = -1;
ec03405fdc7e66 Marek Behún 2020-08-19  534      switch (port) {
ec03405fdc7e66 Marek Behún 2020-08-19  535      case 0:
ec03405fdc7e66 Marek Behún 2020-08-19  536      case 9:
ec03405fdc7e66 Marek Behún 2020-08-19  537      case 10:
ec03405fdc7e66 Marek Behún 2020-08-19  538              if (cmode == 
MV88E6XXX_PORT_STS_CMODE_1000BASEX ||
ec03405fdc7e66 Marek Behún 2020-08-19  539                  cmode == 
MV88E6XXX_PORT_STS_CMODE_SGMII ||
ec03405fdc7e66 Marek Behún 2020-08-19  540                  cmode == 
MV88E6XXX_PORT_STS_CMODE_2500BASEX ||
ec03405fdc7e66 Marek Behún 2020-08-19  541                  cmode == 
MV88E6393_PORT_STS_CMODE_5GBASER ||
ec03405fdc7e66 Marek Behún 2020-08-19  542                  cmode == 
MV88E6393_PORT_STS_CMODE_10GBASER ||
ec03405fdc7e66 Marek Behún 2020-08-19  543                  cmode == 
MV88E6393_PORT_STS_CMODE_USXGMII)
ec03405fdc7e66 Marek Behún 2020-08-19  544                      *lane = port;
ec03405fdc7e66 Marek Behún 2020-08-19  545      }
ec03405fdc7e66 Marek Behún 2020-08-19  546  
ec03405fdc7e66 Marek Behún 2020-08-19 @547      return *lane == -1 ? -ENODEV : 
0;
ec03405fdc7e66 Marek Behún 2020-08-19  548  }
ec03405fdc7e66 Marek Behún 2020-08-19  549  

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/[email protected]

Attachment: .config.gz
Description: application/gzip

_______________________________________________
kbuild mailing list -- [email protected]
To unsubscribe send an email to [email protected]

Reply via email to