CC: [email protected] In-Reply-To: <[email protected]> References: <[email protected]> TO: Thierry Reding <[email protected]>
Hi Thierry, I love your patch! Perhaps something to improve: [auto build test WARNING on linus/master] [also build test WARNING on v5.9-rc2 next-20200828] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/0day-ci/linux/commits/Thierry-Reding/drm-nouveau-Support-sync-FDs-and-sync-objects/20200828-184155 base: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git 15bc20c6af4ceee97a1f90b43c0e386643c071b4 :::::: branch date: 11 hours ago :::::: commit date: 11 hours ago config: x86_64-randconfig-m001-20200828 (attached as .config) compiler: gcc-9 (Debian 9.3.0-15) 9.3.0 If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot <[email protected]> Reported-by: Dan Carpenter <[email protected]> New smatch warnings: drivers/gpu/drm/nouveau/nouveau_gem.c:772 nouveau_channel_emit_fence() warn: passing zero to 'ERR_PTR' Old smatch warnings: include/drm/ttm/ttm_bo_driver.h:641 __ttm_bo_reserve() warn: inconsistent returns '*bo->base.resv'. # https://github.com/0day-ci/linux/commit/2a7ed4e5037cdf9d59e36812ae6ce230df64d472 git remote add linux-review https://github.com/0day-ci/linux git fetch --no-tags linux-review Thierry-Reding/drm-nouveau-Support-sync-FDs-and-sync-objects/20200828-184155 git checkout 2a7ed4e5037cdf9d59e36812ae6ce230df64d472 vim +/ERR_PTR +772 drivers/gpu/drm/nouveau/nouveau_gem.c 2a7ed4e5037cdf9 Thierry Reding 2020-08-28 727 2a7ed4e5037cdf9 Thierry Reding 2020-08-28 728 static struct nouveau_fence * 2a7ed4e5037cdf9 Thierry Reding 2020-08-28 729 nouveau_channel_emit_fence(struct nouveau_channel *channel, 2a7ed4e5037cdf9 Thierry Reding 2020-08-28 730 struct drm_file *file_priv, 2a7ed4e5037cdf9 Thierry Reding 2020-08-28 731 struct drm_nouveau_gem_fence *f) 2a7ed4e5037cdf9 Thierry Reding 2020-08-28 732 { 2a7ed4e5037cdf9 Thierry Reding 2020-08-28 733 struct nouveau_fence *fence; 2a7ed4e5037cdf9 Thierry Reding 2020-08-28 734 int ret; 2a7ed4e5037cdf9 Thierry Reding 2020-08-28 735 2a7ed4e5037cdf9 Thierry Reding 2020-08-28 736 ret = nouveau_fence_new(channel, false, &fence); 2a7ed4e5037cdf9 Thierry Reding 2020-08-28 737 if (ret < 0) 2a7ed4e5037cdf9 Thierry Reding 2020-08-28 738 return ERR_PTR(ret); 2a7ed4e5037cdf9 Thierry Reding 2020-08-28 739 2a7ed4e5037cdf9 Thierry Reding 2020-08-28 740 if (f->flags & NOUVEAU_GEM_FENCE_FD) { 2a7ed4e5037cdf9 Thierry Reding 2020-08-28 741 struct sync_file *file; 2a7ed4e5037cdf9 Thierry Reding 2020-08-28 742 int fd; 2a7ed4e5037cdf9 Thierry Reding 2020-08-28 743 2a7ed4e5037cdf9 Thierry Reding 2020-08-28 744 fd = get_unused_fd_flags(O_CLOEXEC); 2a7ed4e5037cdf9 Thierry Reding 2020-08-28 745 if (fd < 0) { 2a7ed4e5037cdf9 Thierry Reding 2020-08-28 746 ret = fd; 2a7ed4e5037cdf9 Thierry Reding 2020-08-28 747 goto put; 2a7ed4e5037cdf9 Thierry Reding 2020-08-28 748 } 2a7ed4e5037cdf9 Thierry Reding 2020-08-28 749 2a7ed4e5037cdf9 Thierry Reding 2020-08-28 750 file = sync_file_create(&fence->base); 2a7ed4e5037cdf9 Thierry Reding 2020-08-28 751 if (!file) { 2a7ed4e5037cdf9 Thierry Reding 2020-08-28 752 put_unused_fd(fd); 2a7ed4e5037cdf9 Thierry Reding 2020-08-28 753 ret = -ENOMEM; 2a7ed4e5037cdf9 Thierry Reding 2020-08-28 754 goto put; 2a7ed4e5037cdf9 Thierry Reding 2020-08-28 755 } 2a7ed4e5037cdf9 Thierry Reding 2020-08-28 756 2a7ed4e5037cdf9 Thierry Reding 2020-08-28 757 fd_install(fd, file->file); 2a7ed4e5037cdf9 Thierry Reding 2020-08-28 758 f->handle = fd; 2a7ed4e5037cdf9 Thierry Reding 2020-08-28 759 } else { 2a7ed4e5037cdf9 Thierry Reding 2020-08-28 760 struct drm_syncobj *syncobj; 2a7ed4e5037cdf9 Thierry Reding 2020-08-28 761 2a7ed4e5037cdf9 Thierry Reding 2020-08-28 762 ret = drm_syncobj_create(&syncobj, 0, &fence->base); 2a7ed4e5037cdf9 Thierry Reding 2020-08-28 763 if (ret < 0) 2a7ed4e5037cdf9 Thierry Reding 2020-08-28 764 goto put; 2a7ed4e5037cdf9 Thierry Reding 2020-08-28 765 2a7ed4e5037cdf9 Thierry Reding 2020-08-28 766 ret = drm_syncobj_get_handle(file_priv, syncobj, &f->handle); 2a7ed4e5037cdf9 Thierry Reding 2020-08-28 767 drm_syncobj_put(syncobj); 2a7ed4e5037cdf9 Thierry Reding 2020-08-28 768 } 2a7ed4e5037cdf9 Thierry Reding 2020-08-28 769 2a7ed4e5037cdf9 Thierry Reding 2020-08-28 770 put: 2a7ed4e5037cdf9 Thierry Reding 2020-08-28 771 nouveau_fence_unref(&fence); 2a7ed4e5037cdf9 Thierry Reding 2020-08-28 @772 return ERR_PTR(ret); 2a7ed4e5037cdf9 Thierry Reding 2020-08-28 773 } 2a7ed4e5037cdf9 Thierry Reding 2020-08-28 774 --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/[email protected]
.config.gz
Description: application/gzip
_______________________________________________ kbuild mailing list -- [email protected] To unsubscribe send an email to [email protected]
