CC: [email protected] CC: [email protected] TO: Miquel Raynal <[email protected]> CC: Boris Brezillon <[email protected]>
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master head: 729e3d091984487f7aa1ebfabfe594e5b317ed0f commit: 83c411c29b90b7de505a2fe1d655293c95f8ba90 mtd: rawnand: timings: Add mode information to the timings structure date: 4 months ago :::::: branch date: 23 hours ago :::::: commit date: 4 months ago config: parisc-randconfig-m031-20200913 (attached as .config) compiler: hppa-linux-gcc (GCC) 9.3.0 If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot <[email protected]> Reported-by: Dan Carpenter <[email protected]> smatch warnings: drivers/mtd/nand/raw/tango_nand.c:489 tango_set_timings() warn: passing a valid pointer to 'PTR_ERR' # https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=83c411c29b90b7de505a2fe1d655293c95f8ba90 git remote add linus https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git git fetch --no-tags linus master git checkout 83c411c29b90b7de505a2fe1d655293c95f8ba90 vim +/PTR_ERR +489 drivers/mtd/nand/raw/tango_nand.c 6956e2385a1617 drivers/mtd/nand/tango_nand.c Marc Gonzalez 2016-10-25 478 858838b87ef542 drivers/mtd/nand/raw/tango_nand.c Boris Brezillon 2018-09-06 479 static int tango_set_timings(struct nand_chip *chip, int csline, 104e442a67cfba drivers/mtd/nand/tango_nand.c Boris Brezillon 2017-03-16 480 const struct nand_data_interface *conf) 6956e2385a1617 drivers/mtd/nand/tango_nand.c Marc Gonzalez 2016-10-25 481 { 6956e2385a1617 drivers/mtd/nand/tango_nand.c Marc Gonzalez 2016-10-25 482 const struct nand_sdr_timings *sdr = nand_get_sdr_timings(conf); 6956e2385a1617 drivers/mtd/nand/tango_nand.c Marc Gonzalez 2016-10-25 483 struct tango_nfc *nfc = to_tango_nfc(chip->controller); 6956e2385a1617 drivers/mtd/nand/tango_nand.c Marc Gonzalez 2016-10-25 484 struct tango_chip *tchip = to_tango_chip(chip); 6956e2385a1617 drivers/mtd/nand/tango_nand.c Marc Gonzalez 2016-10-25 485 u32 Trdy, Textw, Twc, Twpw, Tacc, Thold, Trpw, Textr; 6956e2385a1617 drivers/mtd/nand/tango_nand.c Marc Gonzalez 2016-10-25 486 int kHz = nfc->freq_kHz; 6956e2385a1617 drivers/mtd/nand/tango_nand.c Marc Gonzalez 2016-10-25 487 6956e2385a1617 drivers/mtd/nand/tango_nand.c Marc Gonzalez 2016-10-25 488 if (IS_ERR(sdr)) 6956e2385a1617 drivers/mtd/nand/tango_nand.c Marc Gonzalez 2016-10-25 @489 return PTR_ERR(sdr); 6956e2385a1617 drivers/mtd/nand/tango_nand.c Marc Gonzalez 2016-10-25 490 104e442a67cfba drivers/mtd/nand/tango_nand.c Boris Brezillon 2017-03-16 491 if (csline == NAND_DATA_IFACE_CHECK_ONLY) 6956e2385a1617 drivers/mtd/nand/tango_nand.c Marc Gonzalez 2016-10-25 492 return 0; 6956e2385a1617 drivers/mtd/nand/tango_nand.c Marc Gonzalez 2016-10-25 493 6956e2385a1617 drivers/mtd/nand/tango_nand.c Marc Gonzalez 2016-10-25 494 Trdy = to_ticks(kHz, sdr->tCEA_max - sdr->tREA_max); 6956e2385a1617 drivers/mtd/nand/tango_nand.c Marc Gonzalez 2016-10-25 495 Textw = to_ticks(kHz, sdr->tWB_max); 6956e2385a1617 drivers/mtd/nand/tango_nand.c Marc Gonzalez 2016-10-25 496 Twc = to_ticks(kHz, sdr->tWC_min); 6956e2385a1617 drivers/mtd/nand/tango_nand.c Marc Gonzalez 2016-10-25 497 Twpw = to_ticks(kHz, sdr->tWC_min - sdr->tWP_min); 6956e2385a1617 drivers/mtd/nand/tango_nand.c Marc Gonzalez 2016-10-25 498 6956e2385a1617 drivers/mtd/nand/tango_nand.c Marc Gonzalez 2016-10-25 499 Tacc = to_ticks(kHz, sdr->tREA_max); 6956e2385a1617 drivers/mtd/nand/tango_nand.c Marc Gonzalez 2016-10-25 500 Thold = to_ticks(kHz, sdr->tREH_min); 6956e2385a1617 drivers/mtd/nand/tango_nand.c Marc Gonzalez 2016-10-25 501 Trpw = to_ticks(kHz, sdr->tRC_min - sdr->tREH_min); 6956e2385a1617 drivers/mtd/nand/tango_nand.c Marc Gonzalez 2016-10-25 502 Textr = to_ticks(kHz, sdr->tRHZ_max); 6956e2385a1617 drivers/mtd/nand/tango_nand.c Marc Gonzalez 2016-10-25 503 6956e2385a1617 drivers/mtd/nand/tango_nand.c Marc Gonzalez 2016-10-25 504 tchip->timing1 = TIMING(Trdy, Textw, Twc, Twpw); 6956e2385a1617 drivers/mtd/nand/tango_nand.c Marc Gonzalez 2016-10-25 505 tchip->timing2 = TIMING(Tacc, Thold, Trpw, Textr); 6956e2385a1617 drivers/mtd/nand/tango_nand.c Marc Gonzalez 2016-10-25 506 6956e2385a1617 drivers/mtd/nand/tango_nand.c Marc Gonzalez 2016-10-25 507 return 0; 6956e2385a1617 drivers/mtd/nand/tango_nand.c Marc Gonzalez 2016-10-25 508 } 6956e2385a1617 drivers/mtd/nand/tango_nand.c Marc Gonzalez 2016-10-25 509 :::::: The code at line 489 was first introduced by commit :::::: 6956e2385a16175ca350e199f9c760eb1644d5bf mtd: nand: add tango NAND flash controller support :::::: TO: Marc Gonzalez <[email protected]> :::::: CC: Boris Brezillon <[email protected]> --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/[email protected]
.config.gz
Description: application/gzip
_______________________________________________ kbuild mailing list -- [email protected] To unsubscribe send an email to [email protected]
