CC: [email protected] TO: Moti Haimovski <[email protected]> CC: Oded Gabbay <[email protected]>
tree: https://github.com/HabanaAI/linux.git dev/ogabbay/nic_patchset_v2 head: 8ff5d9e889ea76aeffd08ce4faeff1e40152d716 commit: b4123293c186dce375459b425131df23f7340ef9 [33/56] habanalabs: rename mmu.c to mmu_v1.c :::::: branch date: 28 hours ago :::::: commit date: 33 hours ago compiler: hppa-linux-gcc (GCC) 9.3.0 If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot <[email protected]> cppcheck warnings: (new ones prefixed by >>) >> drivers/misc/habanalabs/common/mmu_v1.c:399:16: warning: Variable >> 'hop2_pte_addr' is reassigned a value before the old one has been used. >> [redundantAssignment] hop2_pte_addr = hop2_addr; ^ drivers/misc/habanalabs/common/mmu_v1.c:398:16: note: Variable 'hop2_pte_addr' is reassigned a value before the old one has been used. hop2_pte_addr = hop2_addr; ^ drivers/misc/habanalabs/common/mmu_v1.c:399:16: note: Variable 'hop2_pte_addr' is reassigned a value before the old one has been used. hop2_pte_addr = hop2_addr; ^ # https://github.com/HabanaAI/linux/commit/b4123293c186dce375459b425131df23f7340ef9 git remote add habanaai https://github.com/HabanaAI/linux.git git fetch --no-tags habanaai dev/ogabbay/nic_patchset_v2 git checkout b4123293c186dce375459b425131df23f7340ef9 vim +/hop2_pte_addr +399 drivers/misc/habanalabs/common/mmu_v1.c 0feaf86d4e6950 drivers/misc/habanalabs/mmu.c Omer Shpigelman 2019-02-16 365 66542c3b9d2fe1 drivers/misc/habanalabs/mmu.c Omer Shpigelman 2019-02-24 366 static void dram_default_mapping_fini(struct hl_ctx *ctx) 0feaf86d4e6950 drivers/misc/habanalabs/mmu.c Omer Shpigelman 2019-02-16 367 { 27ca384cb7c44b drivers/misc/habanalabs/mmu.c Omer Shpigelman 2019-02-28 368 struct hl_device *hdev = ctx->hdev; 27ca384cb7c44b drivers/misc/habanalabs/mmu.c Omer Shpigelman 2019-02-28 369 struct asic_fixed_properties *prop = &hdev->asic_prop; 66542c3b9d2fe1 drivers/misc/habanalabs/mmu.c Omer Shpigelman 2019-02-24 370 u64 num_of_hop3, total_hops, hop0_addr, hop1_addr, hop2_addr, 66542c3b9d2fe1 drivers/misc/habanalabs/mmu.c Omer Shpigelman 2019-02-24 371 hop2_pte_addr, hop3_pte_addr; 27ca384cb7c44b drivers/misc/habanalabs/mmu.c Omer Shpigelman 2019-02-28 372 int i, j; 0feaf86d4e6950 drivers/misc/habanalabs/mmu.c Omer Shpigelman 2019-02-16 373 7aa2227affb510 drivers/misc/habanalabs/mmu.c Oded Gabbay 2019-05-29 374 if ((!hdev->dram_supports_virtual_memory) || 7aa2227affb510 drivers/misc/habanalabs/mmu.c Oded Gabbay 2019-05-29 375 (!hdev->dram_default_page_mapping) || 7aa2227affb510 drivers/misc/habanalabs/mmu.c Oded Gabbay 2019-05-29 376 (ctx->asid == HL_KERNEL_ASID_ID)) 0feaf86d4e6950 drivers/misc/habanalabs/mmu.c Omer Shpigelman 2019-02-16 377 return; 0feaf86d4e6950 drivers/misc/habanalabs/mmu.c Omer Shpigelman 2019-02-16 378 b3bf147bd6117f drivers/misc/habanalabs/mmu.c Oded Gabbay 2019-03-01 379 num_of_hop3 = prop->dram_size_for_default_page_mapping; b3bf147bd6117f drivers/misc/habanalabs/mmu.c Oded Gabbay 2019-03-01 380 do_div(num_of_hop3, prop->dram_page_size); b3bf147bd6117f drivers/misc/habanalabs/mmu.c Oded Gabbay 2019-03-01 381 do_div(num_of_hop3, PTE_ENTRIES_IN_HOP); 27ca384cb7c44b drivers/misc/habanalabs/mmu.c Omer Shpigelman 2019-02-28 382 66542c3b9d2fe1 drivers/misc/habanalabs/mmu.c Omer Shpigelman 2019-02-24 383 hop0_addr = get_hop0_addr(ctx); 27ca384cb7c44b drivers/misc/habanalabs/mmu.c Omer Shpigelman 2019-02-28 384 /* add hop1 and hop2 */ 27ca384cb7c44b drivers/misc/habanalabs/mmu.c Omer Shpigelman 2019-02-28 385 total_hops = num_of_hop3 + 2; 27ca384cb7c44b drivers/misc/habanalabs/mmu.c Omer Shpigelman 2019-02-28 386 hop1_addr = ctx->dram_default_hops[total_hops - 1]; 27ca384cb7c44b drivers/misc/habanalabs/mmu.c Omer Shpigelman 2019-02-28 387 hop2_addr = ctx->dram_default_hops[total_hops - 2]; 27ca384cb7c44b drivers/misc/habanalabs/mmu.c Omer Shpigelman 2019-02-28 388 27ca384cb7c44b drivers/misc/habanalabs/mmu.c Omer Shpigelman 2019-02-28 389 for (i = 0 ; i < num_of_hop3 ; i++) { 27ca384cb7c44b drivers/misc/habanalabs/mmu.c Omer Shpigelman 2019-02-28 390 hop3_pte_addr = ctx->dram_default_hops[i]; 27ca384cb7c44b drivers/misc/habanalabs/mmu.c Omer Shpigelman 2019-02-28 391 for (j = 0 ; j < PTE_ENTRIES_IN_HOP ; j++) { 66542c3b9d2fe1 drivers/misc/habanalabs/mmu.c Omer Shpigelman 2019-02-24 392 clear_pte(ctx, hop3_pte_addr); 27ca384cb7c44b drivers/misc/habanalabs/mmu.c Omer Shpigelman 2019-02-28 393 put_pte(ctx, ctx->dram_default_hops[i]); 27ca384cb7c44b drivers/misc/habanalabs/mmu.c Omer Shpigelman 2019-02-28 394 hop3_pte_addr += HL_PTE_SIZE; 27ca384cb7c44b drivers/misc/habanalabs/mmu.c Omer Shpigelman 2019-02-28 395 } 27ca384cb7c44b drivers/misc/habanalabs/mmu.c Omer Shpigelman 2019-02-28 396 } 27ca384cb7c44b drivers/misc/habanalabs/mmu.c Omer Shpigelman 2019-02-28 397 66542c3b9d2fe1 drivers/misc/habanalabs/mmu.c Omer Shpigelman 2019-02-24 398 hop2_pte_addr = hop2_addr; 27ca384cb7c44b drivers/misc/habanalabs/mmu.c Omer Shpigelman 2019-02-28 @399 hop2_pte_addr = hop2_addr; 27ca384cb7c44b drivers/misc/habanalabs/mmu.c Omer Shpigelman 2019-02-28 400 for (i = 0 ; i < num_of_hop3 ; i++) { 66542c3b9d2fe1 drivers/misc/habanalabs/mmu.c Omer Shpigelman 2019-02-24 401 clear_pte(ctx, hop2_pte_addr); 27ca384cb7c44b drivers/misc/habanalabs/mmu.c Omer Shpigelman 2019-02-28 402 put_pte(ctx, hop2_addr); 27ca384cb7c44b drivers/misc/habanalabs/mmu.c Omer Shpigelman 2019-02-28 403 hop2_pte_addr += HL_PTE_SIZE; 27ca384cb7c44b drivers/misc/habanalabs/mmu.c Omer Shpigelman 2019-02-28 404 } 27ca384cb7c44b drivers/misc/habanalabs/mmu.c Omer Shpigelman 2019-02-28 405 66542c3b9d2fe1 drivers/misc/habanalabs/mmu.c Omer Shpigelman 2019-02-24 406 clear_pte(ctx, hop1_addr); 27ca384cb7c44b drivers/misc/habanalabs/mmu.c Omer Shpigelman 2019-02-28 407 put_pte(ctx, hop1_addr); 66542c3b9d2fe1 drivers/misc/habanalabs/mmu.c Omer Shpigelman 2019-02-24 408 clear_pte(ctx, hop0_addr); 27ca384cb7c44b drivers/misc/habanalabs/mmu.c Omer Shpigelman 2019-02-28 409 27ca384cb7c44b drivers/misc/habanalabs/mmu.c Omer Shpigelman 2019-02-28 410 kfree(ctx->dram_default_hops); 27ca384cb7c44b drivers/misc/habanalabs/mmu.c Omer Shpigelman 2019-02-28 411 66542c3b9d2fe1 drivers/misc/habanalabs/mmu.c Omer Shpigelman 2019-02-24 412 flush(ctx); 66542c3b9d2fe1 drivers/misc/habanalabs/mmu.c Omer Shpigelman 2019-02-24 413 } 66542c3b9d2fe1 drivers/misc/habanalabs/mmu.c Omer Shpigelman 2019-02-24 414 :::::: The code at line 399 was first introduced by commit :::::: 27ca384cb7c44b8b16ea43f9aed930664140360e habanalabs: add MMU DRAM default page mapping :::::: TO: Omer Shpigelman <[email protected]> :::::: CC: Greg Kroah-Hartman <[email protected]> --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/[email protected] _______________________________________________ kbuild mailing list -- [email protected] To unsubscribe send an email to [email protected]
