CC: [email protected]
In-Reply-To: <[email protected]>
References: <[email protected]>
TO: [email protected]
TO: [email protected]
CC: [email protected]
CC: [email protected]
CC: [email protected]
CC: [email protected]
CC: [email protected]
CC: [email protected]
CC: [email protected]
CC: [email protected]
CC: AngeloGioacchino Del Regno <[email protected]>

Hi,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on linuxtv-media/master]
[also build test WARNING on robh/for-next linus/master v5.9 next-20201023]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    
https://github.com/0day-ci/linux/commits/kholk11-gmail-com/Add-support-for-the-Sony-Exmor-RS-IMX300-camera-sensor/20201018-203244
base:   git://linuxtv.org/media_tree.git master
:::::: branch date: 5 days ago
:::::: commit date: 5 days ago
config: x86_64-randconfig-m001-20201022 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-15) 9.3.0

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <[email protected]>
Reported-by: Dan Carpenter <[email protected]>

smatch warnings:
drivers/media/i2c/imx300.c:2413 imx300_set_framefmt() error: uninitialized 
symbol 'ret'.

vim +/ret +2413 drivers/media/i2c/imx300.c

c82629fb21ade4 AngeloGioacchino Del Regno 2020-10-18  2376  
c82629fb21ade4 AngeloGioacchino Del Regno 2020-10-18  2377  static int 
imx300_set_framefmt(struct imx300 *imx300)
c82629fb21ade4 AngeloGioacchino Del Regno 2020-10-18  2378  {
c82629fb21ade4 AngeloGioacchino Del Regno 2020-10-18  2379      int ret;
c82629fb21ade4 AngeloGioacchino Del Regno 2020-10-18  2380  
c82629fb21ade4 AngeloGioacchino Del Regno 2020-10-18  2381      switch 
(imx300->fmt.code) {
c82629fb21ade4 AngeloGioacchino Del Regno 2020-10-18  2382      case 
MEDIA_BUS_FMT_SRGGB8_1X8:
c82629fb21ade4 AngeloGioacchino Del Regno 2020-10-18  2383              
fallthrough;
c82629fb21ade4 AngeloGioacchino Del Regno 2020-10-18  2384      case 
MEDIA_BUS_FMT_SGRBG8_1X8:
c82629fb21ade4 AngeloGioacchino Del Regno 2020-10-18  2385              
fallthrough;
c82629fb21ade4 AngeloGioacchino Del Regno 2020-10-18  2386      case 
MEDIA_BUS_FMT_SGBRG8_1X8:
c82629fb21ade4 AngeloGioacchino Del Regno 2020-10-18  2387              
fallthrough;
c82629fb21ade4 AngeloGioacchino Del Regno 2020-10-18  2388      case 
MEDIA_BUS_FMT_SBGGR8_1X8:
c82629fb21ade4 AngeloGioacchino Del Regno 2020-10-18  2389              ret = 
imx300_write_regs(imx300, raw8_framefmt_regs,
c82629fb21ade4 AngeloGioacchino Del Regno 2020-10-18  2390                      
                ARRAY_SIZE(raw8_framefmt_regs));
c82629fb21ade4 AngeloGioacchino Del Regno 2020-10-18  2391              if (ret)
c82629fb21ade4 AngeloGioacchino Del Regno 2020-10-18  2392                      
return ret;
c82629fb21ade4 AngeloGioacchino Del Regno 2020-10-18  2393              
imx300->cur_bps = 8;
c82629fb21ade4 AngeloGioacchino Del Regno 2020-10-18  2394              break;
c82629fb21ade4 AngeloGioacchino Del Regno 2020-10-18  2395      case 
MEDIA_BUS_FMT_SRGGB10_1X10:
c82629fb21ade4 AngeloGioacchino Del Regno 2020-10-18  2396              
fallthrough;
c82629fb21ade4 AngeloGioacchino Del Regno 2020-10-18  2397      case 
MEDIA_BUS_FMT_SGRBG10_1X10:
c82629fb21ade4 AngeloGioacchino Del Regno 2020-10-18  2398              
fallthrough;
c82629fb21ade4 AngeloGioacchino Del Regno 2020-10-18  2399      case 
MEDIA_BUS_FMT_SGBRG10_1X10:
c82629fb21ade4 AngeloGioacchino Del Regno 2020-10-18  2400              
fallthrough;
c82629fb21ade4 AngeloGioacchino Del Regno 2020-10-18  2401      case 
MEDIA_BUS_FMT_SBGGR10_1X10:
c82629fb21ade4 AngeloGioacchino Del Regno 2020-10-18  2402              ret = 
imx300_write_regs(imx300, raw10_framefmt_regs,
c82629fb21ade4 AngeloGioacchino Del Regno 2020-10-18  2403                      
                ARRAY_SIZE(raw10_framefmt_regs));
c82629fb21ade4 AngeloGioacchino Del Regno 2020-10-18  2404              if (ret)
c82629fb21ade4 AngeloGioacchino Del Regno 2020-10-18  2405                      
return ret;
c82629fb21ade4 AngeloGioacchino Del Regno 2020-10-18  2406              
imx300->cur_bps = 10;
c82629fb21ade4 AngeloGioacchino Del Regno 2020-10-18  2407              break;
c82629fb21ade4 AngeloGioacchino Del Regno 2020-10-18  2408      }
c82629fb21ade4 AngeloGioacchino Del Regno 2020-10-18  2409  
c82629fb21ade4 AngeloGioacchino Del Regno 2020-10-18  2410      /* Update the 
pixel rate to eventually save some power */
c82629fb21ade4 AngeloGioacchino Del Regno 2020-10-18  2411      
__v4l2_ctrl_s_ctrl_int64(imx300->pixel_rate, get_pixel_rate(imx300));
c82629fb21ade4 AngeloGioacchino Del Regno 2020-10-18  2412  
c82629fb21ade4 AngeloGioacchino Del Regno 2020-10-18 @2413      return ret;
c82629fb21ade4 AngeloGioacchino Del Regno 2020-10-18  2414  }
c82629fb21ade4 AngeloGioacchino Del Regno 2020-10-18  2415  

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/[email protected]

Attachment: .config.gz
Description: application/gzip

_______________________________________________
kbuild mailing list -- [email protected]
To unsubscribe send an email to [email protected]

Reply via email to