CC: [email protected] CC: [email protected] TO: Petteri Aimonen <[email protected]> CC: Borislav Petkov <[email protected]> CC: Nick Desaulniers <[email protected]> CC: [email protected]
From: kernel test robot <[email protected]> lib/test_fpu.c:66:0-23: WARNING: test_fpu_fops should be defined with DEFINE_DEBUGFS_ATTRIBUTE Use DEFINE_DEBUGFS_ATTRIBUTE rather than DEFINE_SIMPLE_ATTRIBUTE for debugfs files. Semantic patch information: Rationale: DEFINE_SIMPLE_ATTRIBUTE + debugfs_create_file() imposes some significant overhead as compared to DEFINE_DEBUGFS_ATTRIBUTE + debugfs_create_file_unsafe(). Generated by: scripts/coccinelle/api/debugfs/debugfs_simple_attr.cocci Fixes: 4185b3b92792 ("selftests/fpu: Add an FPU selftest") CC: Petteri Aimonen <[email protected]> Signed-off-by: kernel test robot <[email protected]> --- tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master head: b6f96e75ae121ead54da3f58c545d68184079f90 commit: 4185b3b92792eaec5869266e594338343421ffb0 selftests/fpu: Add an FPU selftest :::::: branch date: 2 hours ago :::::: commit date: 4 months ago Please take the patch only if it's a positive warning. Thanks! test_fpu.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) --- a/lib/test_fpu.c +++ b/lib/test_fpu.c @@ -63,7 +63,7 @@ static int test_fpu_get(void *data, u64 return status; } -DEFINE_SIMPLE_ATTRIBUTE(test_fpu_fops, test_fpu_get, NULL, "%lld\n"); +DEFINE_DEBUGFS_ATTRIBUTE(test_fpu_fops, test_fpu_get, NULL, "%lld\n"); static struct dentry *selftest_dir; static int __init test_fpu_init(void) @@ -72,8 +72,8 @@ static int __init test_fpu_init(void) if (!selftest_dir) return -ENOMEM; - debugfs_create_file("test_fpu", 0444, selftest_dir, NULL, - &test_fpu_fops); + debugfs_create_file_unsafe("test_fpu", 0444, selftest_dir, NULL, + &test_fpu_fops); return 0; } _______________________________________________ kbuild mailing list -- [email protected] To unsubscribe send an email to [email protected]
