CC: [email protected]
CC: "Darrick J. Wong" <[email protected]>
TO: "Darrick J. Wong" <[email protected]>

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/djwong/xfs-linux.git 
widen-efi-and-bui-formats
head:   e0082e8a4eb51065947a02435610d4c717845aee
commit: ec4688760d00213257cde9d9cc7382523e83ddec [72/164] xfs: introduce a 
swap-extent log intent item
:::::: branch date: 4 hours ago
:::::: commit date: 4 hours ago
config: arm-randconfig-c004-20201026 (attached as .config)
compiler: arm-linux-gnueabi-gcc (GCC) 9.3.0

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <[email protected]>
Reported-by: Julia Lawall <[email protected]>


"coccinelle warnings: (new ones prefixed by >>)"
>> fs/xfs/xfs_swapext_item.c:56:5-24: atomic_dec_and_test variation before 
>> object free at line 57.

vim +56 fs/xfs/xfs_swapext_item.c

ec4688760d00213 Darrick J. Wong 2020-10-25  43  
ec4688760d00213 Darrick J. Wong 2020-10-25  44  /*
ec4688760d00213 Darrick J. Wong 2020-10-25  45   * Freeing the SXI requires 
that we remove it from the AIL if it has already
ec4688760d00213 Darrick J. Wong 2020-10-25  46   * been placed there. However, 
the SXI may not yet have been placed in the AIL
ec4688760d00213 Darrick J. Wong 2020-10-25  47   * when called by 
xfs_sxi_release() from SXD processing due to the ordering of
ec4688760d00213 Darrick J. Wong 2020-10-25  48   * committed vs unpin 
operations in bulk insert operations. Hence the reference
ec4688760d00213 Darrick J. Wong 2020-10-25  49   * count to ensure only the 
last caller frees the SXI.
ec4688760d00213 Darrick J. Wong 2020-10-25  50   */
ec4688760d00213 Darrick J. Wong 2020-10-25  51  STATIC void
ec4688760d00213 Darrick J. Wong 2020-10-25  52  xfs_sxi_release(
ec4688760d00213 Darrick J. Wong 2020-10-25  53          struct xfs_sxi_log_item 
*sxi_lip)
ec4688760d00213 Darrick J. Wong 2020-10-25  54  {
ec4688760d00213 Darrick J. Wong 2020-10-25  55          
ASSERT(atomic_read(&sxi_lip->sxi_refcount) > 0);
ec4688760d00213 Darrick J. Wong 2020-10-25 @56          if 
(atomic_dec_and_test(&sxi_lip->sxi_refcount)) {
ec4688760d00213 Darrick J. Wong 2020-10-25 @57                  
xfs_trans_ail_delete(&sxi_lip->sxi_item, SHUTDOWN_LOG_IO_ERROR);
ec4688760d00213 Darrick J. Wong 2020-10-25  58                  
xfs_sxi_item_free(sxi_lip);
ec4688760d00213 Darrick J. Wong 2020-10-25  59          }
ec4688760d00213 Darrick J. Wong 2020-10-25  60  }
ec4688760d00213 Darrick J. Wong 2020-10-25  61  

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/[email protected]

Attachment: .config.gz
Description: application/gzip

_______________________________________________
kbuild mailing list -- [email protected]
To unsubscribe send an email to [email protected]

Reply via email to