CC: [email protected] CC: [email protected] TO: Taehee Yoo <[email protected]>
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master head: ed8780e3f2ecc82645342d070c6b4e530532e680 commit: 1fc70edb7d7b5ce1ae32b0cf90183f4879ad421a net: core: add nested_level variable in net_device date: 4 weeks ago :::::: branch date: 20 hours ago :::::: commit date: 4 weeks ago config: parisc-randconfig-m031-20201028 (attached as .config) compiler: hppa64-linux-gcc (GCC) 9.3.0 If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot <[email protected]> Reported-by: Dan Carpenter <[email protected]> New smatch warnings: drivers/net/ethernet/broadcom/bnx2x/bnx2x_cmn.h:1255 bnx2x_wait_sp_comp() error: double unlocked 'bp->dev->addr_list_lock' (orig line 1244) drivers/net/ethernet/broadcom/bnx2x/bnx2x_cmn.h:1255 bnx2x_wait_sp_comp() error: double unlocked 'bp->dev->addr_list_lock' (orig line 1244) drivers/net/ethernet/broadcom/bnx2x/bnx2x_main.c:12781 bnx2x_set_rx_mode_inner() error: double unlocked 'bp->dev->addr_list_lock' (orig line 12760) Old smatch warnings: drivers/net/ethernet/broadcom/bnx2x/bnx2x_cmn.h:1258 bnx2x_wait_sp_comp() error: double unlocked 'bp->dev->addr_list_lock' (orig line 1244) drivers/net/ethernet/broadcom/bnx2x/bnx2x_init_ops.h:640 bnx2x_ilt_client_mem_op() warn: variable dereferenced before check 'ilt' (see line 638) drivers/net/ethernet/broadcom/bnx2x/bnx2x_cmn.h:1258 bnx2x_wait_sp_comp() error: double unlocked 'bp->dev->addr_list_lock' (orig line 1244) drivers/net/ethernet/broadcom/bnx2x/bnx2x_main.c:12787 bnx2x_set_rx_mode_inner() error: double unlocked 'bp->dev->addr_list_lock' (orig line 12760) drivers/net/ethernet/broadcom/bnx2x/bnx2x_main.c:13490 bnx2x_init_firmware() error: we previously assumed 'bp->firmware' could be null (see line 13462) vim +1255 drivers/net/ethernet/broadcom/bnx2x/bnx2x_cmn.h 523224a3b3cd407 drivers/net/bnx2x/bnx2x_cmn.h Dmitry Kravkov 2010-10-06 1226 619c5cb6885b936 drivers/net/bnx2x/bnx2x_cmn.h Vlad Zolotarov 2011-06-14 1227 /** 619c5cb6885b936 drivers/net/bnx2x/bnx2x_cmn.h Vlad Zolotarov 2011-06-14 1228 * bnx2x_wait_sp_comp - wait for the outstanding SP commands. 619c5cb6885b936 drivers/net/bnx2x/bnx2x_cmn.h Vlad Zolotarov 2011-06-14 1229 * 619c5cb6885b936 drivers/net/bnx2x/bnx2x_cmn.h Vlad Zolotarov 2011-06-14 1230 * @bp: driver handle 619c5cb6885b936 drivers/net/bnx2x/bnx2x_cmn.h Vlad Zolotarov 2011-06-14 1231 * @mask: bits that need to be cleared 619c5cb6885b936 drivers/net/bnx2x/bnx2x_cmn.h Vlad Zolotarov 2011-06-14 1232 */ 619c5cb6885b936 drivers/net/bnx2x/bnx2x_cmn.h Vlad Zolotarov 2011-06-14 1233 static inline bool bnx2x_wait_sp_comp(struct bnx2x *bp, unsigned long mask) 619c5cb6885b936 drivers/net/bnx2x/bnx2x_cmn.h Vlad Zolotarov 2011-06-14 1234 { 619c5cb6885b936 drivers/net/bnx2x/bnx2x_cmn.h Vlad Zolotarov 2011-06-14 1235 int tout = 5000; /* Wait for 5 secs tops */ 619c5cb6885b936 drivers/net/bnx2x/bnx2x_cmn.h Vlad Zolotarov 2011-06-14 1236 619c5cb6885b936 drivers/net/bnx2x/bnx2x_cmn.h Vlad Zolotarov 2011-06-14 1237 while (tout--) { 619c5cb6885b936 drivers/net/bnx2x/bnx2x_cmn.h Vlad Zolotarov 2011-06-14 1238 smp_mb(); 619c5cb6885b936 drivers/net/bnx2x/bnx2x_cmn.h Vlad Zolotarov 2011-06-14 1239 netif_addr_lock_bh(bp->dev); 619c5cb6885b936 drivers/net/bnx2x/bnx2x_cmn.h Vlad Zolotarov 2011-06-14 1240 if (!(bp->sp_state & mask)) { 619c5cb6885b936 drivers/net/bnx2x/bnx2x_cmn.h Vlad Zolotarov 2011-06-14 1241 netif_addr_unlock_bh(bp->dev); 619c5cb6885b936 drivers/net/bnx2x/bnx2x_cmn.h Vlad Zolotarov 2011-06-14 1242 return true; 619c5cb6885b936 drivers/net/bnx2x/bnx2x_cmn.h Vlad Zolotarov 2011-06-14 1243 } 619c5cb6885b936 drivers/net/bnx2x/bnx2x_cmn.h Vlad Zolotarov 2011-06-14 @1244 netif_addr_unlock_bh(bp->dev); 619c5cb6885b936 drivers/net/bnx2x/bnx2x_cmn.h Vlad Zolotarov 2011-06-14 1245 0926d499e24d22d drivers/net/ethernet/broadcom/bnx2x/bnx2x_cmn.h Yuval Mintz 2013-01-23 1246 usleep_range(1000, 2000); 619c5cb6885b936 drivers/net/bnx2x/bnx2x_cmn.h Vlad Zolotarov 2011-06-14 1247 } 3b7f817e47bb66a drivers/net/bnx2x/bnx2x_cmn.h Dmitry Kravkov 2011-03-31 1248 619c5cb6885b936 drivers/net/bnx2x/bnx2x_cmn.h Vlad Zolotarov 2011-06-14 1249 smp_mb(); 3b7f817e47bb66a drivers/net/bnx2x/bnx2x_cmn.h Dmitry Kravkov 2011-03-31 1250 619c5cb6885b936 drivers/net/bnx2x/bnx2x_cmn.h Vlad Zolotarov 2011-06-14 1251 netif_addr_lock_bh(bp->dev); 619c5cb6885b936 drivers/net/bnx2x/bnx2x_cmn.h Vlad Zolotarov 2011-06-14 1252 if (bp->sp_state & mask) { 51c1a580b1e07d5 drivers/net/ethernet/broadcom/bnx2x/bnx2x_cmn.h Merav Sicron 2012-03-18 1253 BNX2X_ERR("Filtering completion timed out. sp_state 0x%lx, mask 0x%lx\n", 51c1a580b1e07d5 drivers/net/ethernet/broadcom/bnx2x/bnx2x_cmn.h Merav Sicron 2012-03-18 1254 bp->sp_state, mask); 619c5cb6885b936 drivers/net/bnx2x/bnx2x_cmn.h Vlad Zolotarov 2011-06-14 @1255 netif_addr_unlock_bh(bp->dev); 619c5cb6885b936 drivers/net/bnx2x/bnx2x_cmn.h Vlad Zolotarov 2011-06-14 1256 return false; 523224a3b3cd407 drivers/net/bnx2x/bnx2x_cmn.h Dmitry Kravkov 2010-10-06 1257 } 619c5cb6885b936 drivers/net/bnx2x/bnx2x_cmn.h Vlad Zolotarov 2011-06-14 1258 netif_addr_unlock_bh(bp->dev); f85582f8c48addd drivers/net/bnx2x/bnx2x_cmn.h Dmitry Kravkov 2010-10-06 1259 619c5cb6885b936 drivers/net/bnx2x/bnx2x_cmn.h Vlad Zolotarov 2011-06-14 1260 return true; 619c5cb6885b936 drivers/net/bnx2x/bnx2x_cmn.h Vlad Zolotarov 2011-06-14 1261 } 9f6c925889ad920 drivers/net/bnx2x/bnx2x_cmn.h Dmitry Kravkov 2010-07-27 1262 :::::: The code at line 1255 was first introduced by commit :::::: 619c5cb6885b936c44ae1422ef805b69c6291485 New 7.0 FW: bnx2x, cnic, bnx2i, bnx2fc :::::: TO: Vlad Zolotarov <[email protected]> :::::: CC: David S. Miller <[email protected]> --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/[email protected]
.config.gz
Description: application/gzip
_______________________________________________ kbuild mailing list -- [email protected] To unsubscribe send an email to [email protected]
