CC: [email protected] CC: [email protected] TO: Lorenzo Bianconi <[email protected]> CC: Felix Fietkau <[email protected]> CC: Sean Wang <[email protected]>
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master head: f6e1ea19649216156576aeafa784e3b4cee45549 commit: eb99cc95c3b6513b495c4839ac4917206705f657 mt76: mt7615: introduce mt7663u support date: 8 months ago :::::: branch date: 25 hours ago :::::: commit date: 8 months ago config: i386-randconfig-m021-20201231 (attached as .config) compiler: gcc-9 (Debian 9.3.0-15) 9.3.0 If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot <[email protected]> Reported-by: Dan Carpenter <[email protected]> New smatch warnings: drivers/net/wireless/mediatek/mt76/mt7615/mac.c:1510 mt7615_mac_adjust_sensitivity() warn: assigning (-98) to unsigned variable 'def_th' Old smatch warnings: drivers/net/wireless/mediatek/mt76/mt7615/mac.c:1510 mt7615_mac_adjust_sensitivity() warn: assigning (-110) to unsigned variable 'def_th' vim +/def_th +1510 drivers/net/wireless/mediatek/mt76/mt7615/mac.c 49de79ad9a748c8 Lorenzo Bianconi 2019-07-28 1502 49de79ad9a748c8 Lorenzo Bianconi 2019-07-28 1503 static void d446a20f5b0ca04 Felix Fietkau 2019-10-26 1504 mt7615_mac_adjust_sensitivity(struct mt7615_phy *phy, 49de79ad9a748c8 Lorenzo Bianconi 2019-07-28 1505 u32 rts_err_rate, bool ofdm) 49de79ad9a748c8 Lorenzo Bianconi 2019-07-28 1506 { d446a20f5b0ca04 Felix Fietkau 2019-10-26 1507 struct mt7615_dev *dev = phy->dev; d446a20f5b0ca04 Felix Fietkau 2019-10-26 1508 int false_cca = ofdm ? phy->false_cca_ofdm : phy->false_cca_cck; d446a20f5b0ca04 Felix Fietkau 2019-10-26 1509 bool ext_phy = phy != &dev->phy; 49de79ad9a748c8 Lorenzo Bianconi 2019-07-28 @1510 u16 def_th = ofdm ? -98 : -110; 49de79ad9a748c8 Lorenzo Bianconi 2019-07-28 1511 bool update = false; 49de79ad9a748c8 Lorenzo Bianconi 2019-07-28 1512 s8 *sensitivity; 49de79ad9a748c8 Lorenzo Bianconi 2019-07-28 1513 int signal; 49de79ad9a748c8 Lorenzo Bianconi 2019-07-28 1514 d446a20f5b0ca04 Felix Fietkau 2019-10-26 1515 sensitivity = ofdm ? &phy->ofdm_sensitivity : &phy->cck_sensitivity; d446a20f5b0ca04 Felix Fietkau 2019-10-26 1516 signal = mt76_get_min_avg_rssi(&dev->mt76, ext_phy); 49de79ad9a748c8 Lorenzo Bianconi 2019-07-28 1517 if (!signal) { d446a20f5b0ca04 Felix Fietkau 2019-10-26 1518 mt7615_mac_set_default_sensitivity(phy); 49de79ad9a748c8 Lorenzo Bianconi 2019-07-28 1519 return; 49de79ad9a748c8 Lorenzo Bianconi 2019-07-28 1520 } 49de79ad9a748c8 Lorenzo Bianconi 2019-07-28 1521 49de79ad9a748c8 Lorenzo Bianconi 2019-07-28 1522 signal = min(signal, -72); 49de79ad9a748c8 Lorenzo Bianconi 2019-07-28 1523 if (false_cca > 500) { 49de79ad9a748c8 Lorenzo Bianconi 2019-07-28 1524 if (rts_err_rate > MT_FRAC(40, 100)) 49de79ad9a748c8 Lorenzo Bianconi 2019-07-28 1525 return; 49de79ad9a748c8 Lorenzo Bianconi 2019-07-28 1526 49de79ad9a748c8 Lorenzo Bianconi 2019-07-28 1527 /* decrease coverage */ 49de79ad9a748c8 Lorenzo Bianconi 2019-07-28 1528 if (*sensitivity == def_th && signal > -90) { 49de79ad9a748c8 Lorenzo Bianconi 2019-07-28 1529 *sensitivity = -90; 49de79ad9a748c8 Lorenzo Bianconi 2019-07-28 1530 update = true; 49de79ad9a748c8 Lorenzo Bianconi 2019-07-28 1531 } else if (*sensitivity + 2 < signal) { 49de79ad9a748c8 Lorenzo Bianconi 2019-07-28 1532 *sensitivity += 2; 49de79ad9a748c8 Lorenzo Bianconi 2019-07-28 1533 update = true; 49de79ad9a748c8 Lorenzo Bianconi 2019-07-28 1534 } 49de79ad9a748c8 Lorenzo Bianconi 2019-07-28 1535 } else if ((false_cca > 0 && false_cca < 50) || 49de79ad9a748c8 Lorenzo Bianconi 2019-07-28 1536 rts_err_rate > MT_FRAC(60, 100)) { 49de79ad9a748c8 Lorenzo Bianconi 2019-07-28 1537 /* increase coverage */ 49de79ad9a748c8 Lorenzo Bianconi 2019-07-28 1538 if (*sensitivity - 2 >= def_th) { 49de79ad9a748c8 Lorenzo Bianconi 2019-07-28 1539 *sensitivity -= 2; 49de79ad9a748c8 Lorenzo Bianconi 2019-07-28 1540 update = true; 49de79ad9a748c8 Lorenzo Bianconi 2019-07-28 1541 } 49de79ad9a748c8 Lorenzo Bianconi 2019-07-28 1542 } 49de79ad9a748c8 Lorenzo Bianconi 2019-07-28 1543 49de79ad9a748c8 Lorenzo Bianconi 2019-07-28 1544 if (*sensitivity > signal) { 49de79ad9a748c8 Lorenzo Bianconi 2019-07-28 1545 *sensitivity = signal; 49de79ad9a748c8 Lorenzo Bianconi 2019-07-28 1546 update = true; 49de79ad9a748c8 Lorenzo Bianconi 2019-07-28 1547 } 49de79ad9a748c8 Lorenzo Bianconi 2019-07-28 1548 49de79ad9a748c8 Lorenzo Bianconi 2019-07-28 1549 if (update) { 49de79ad9a748c8 Lorenzo Bianconi 2019-07-28 1550 u16 val; 49de79ad9a748c8 Lorenzo Bianconi 2019-07-28 1551 49de79ad9a748c8 Lorenzo Bianconi 2019-07-28 1552 if (ofdm) { 49de79ad9a748c8 Lorenzo Bianconi 2019-07-28 1553 val = *sensitivity * 2 + 512; 2cad515ece8ad4e Ryder Lee 2019-12-24 1554 mt76_rmw(dev, MT_WF_PHY_MIN_PRI_PWR(ext_phy), 2cad515ece8ad4e Ryder Lee 2019-12-24 1555 MT_WF_PHY_PD_OFDM_MASK(ext_phy), 2cad515ece8ad4e Ryder Lee 2019-12-24 1556 MT_WF_PHY_PD_OFDM(ext_phy, val)); 49de79ad9a748c8 Lorenzo Bianconi 2019-07-28 1557 } else { 49de79ad9a748c8 Lorenzo Bianconi 2019-07-28 1558 val = *sensitivity + 256; 2cad515ece8ad4e Ryder Lee 2019-12-24 1559 mt76_rmw(dev, MT_WF_PHY_RXTD_CCK_PD(ext_phy), 2cad515ece8ad4e Ryder Lee 2019-12-24 1560 MT_WF_PHY_PD_CCK_MASK(ext_phy), 2cad515ece8ad4e Ryder Lee 2019-12-24 1561 MT_WF_PHY_PD_CCK(ext_phy, val)); 49de79ad9a748c8 Lorenzo Bianconi 2019-07-28 1562 } d446a20f5b0ca04 Felix Fietkau 2019-10-26 1563 phy->last_cca_adj = jiffies; 49de79ad9a748c8 Lorenzo Bianconi 2019-07-28 1564 } 49de79ad9a748c8 Lorenzo Bianconi 2019-07-28 1565 } 49de79ad9a748c8 Lorenzo Bianconi 2019-07-28 1566 :::::: The code at line 1510 was first introduced by commit :::::: 49de79ad9a748c86277f39613ade72dc56421454 mt76: mt7615: add Smart Carrier Sense support :::::: TO: Lorenzo Bianconi <[email protected]> :::::: CC: Felix Fietkau <[email protected]> --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/[email protected]
.config.gz
Description: application/gzip
_______________________________________________ kbuild mailing list -- [email protected] To unsubscribe send an email to [email protected]
