CC: [email protected] In-Reply-To: <[email protected]> References: <[email protected]> TO: Vinod Koul <[email protected]> TO: Bjorn Andersson <[email protected]> TO: Mark Brown <[email protected]> TO: Wolfram Sang <[email protected]> CC: [email protected] CC: Vinod Koul <[email protected]> CC: Andy Gross <[email protected]> CC: Matthias Kaehlcke <[email protected]> CC: Douglas Anderson <[email protected]> CC: Sumit Semwal <[email protected]> CC: Amit Pundir <[email protected]>
Hi Vinod, I love your patch! Perhaps something to improve: [auto build test WARNING on v5.11-rc2] [cannot apply to robh/for-next spi/for-next wsa/i2c/for-next linus/master v5.11-rc3 next-20210111] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/0day-ci/linux/commits/Vinod-Koul/Add-and-enable-GPI-DMA-users/20210111-232052 base: e71ba9452f0b5b2e8dc8aa5445198cd9214a6a62 :::::: branch date: 4 hours ago :::::: commit date: 4 hours ago config: mips-randconfig-s031-20210111 (attached as .config) compiler: mipsel-linux-gcc (GCC) 9.3.0 reproduce: wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # apt-get install sparse # sparse version: v0.6.3-208-g46a52ca4-dirty # https://github.com/0day-ci/linux/commit/bcc874d4e76c4129ee33077e2828a311b2edcb96 git remote add linux-review https://github.com/0day-ci/linux git fetch --no-tags linux-review Vinod-Koul/Add-and-enable-GPI-DMA-users/20210111-232052 git checkout bcc874d4e76c4129ee33077e2828a311b2edcb96 # save the attached .config to linux build tree COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' ARCH=mips If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot <[email protected]> "sparse warnings: (new ones prefixed by >>)" command-line: note: in included file: builtin:1:9: sparse: sparse: preprocessor token __ATOMIC_ACQUIRE redefined builtin:0:0: sparse: this was the original definition builtin:1:9: sparse: sparse: preprocessor token __ATOMIC_SEQ_CST redefined builtin:0:0: sparse: this was the original definition builtin:1:9: sparse: sparse: preprocessor token __ATOMIC_ACQ_REL redefined builtin:0:0: sparse: this was the original definition builtin:1:9: sparse: sparse: preprocessor token __ATOMIC_RELEASE redefined builtin:0:0: sparse: this was the original definition >> drivers/spi/spi-geni-qcom.c:811:19: sparse: sparse: constant 0i is not a >> valid number vim +811 drivers/spi/spi-geni-qcom.c 561de45f72bd5f9b Girish Mahadevan 2018-10-03 804 561de45f72bd5f9b Girish Mahadevan 2018-10-03 805 static int spi_geni_transfer_one(struct spi_master *spi, 561de45f72bd5f9b Girish Mahadevan 2018-10-03 806 struct spi_device *slv, 561de45f72bd5f9b Girish Mahadevan 2018-10-03 807 struct spi_transfer *xfer) 561de45f72bd5f9b Girish Mahadevan 2018-10-03 808 { 561de45f72bd5f9b Girish Mahadevan 2018-10-03 809 struct spi_geni_master *mas = spi_master_get_devdata(spi); bcc874d4e76c4129 Vinod Koul 2021-01-11 810 unsigned long timeout, jiffies; bcc874d4e76c4129 Vinod Koul 2021-01-11 @811 int ret = 0i, i; 561de45f72bd5f9b Girish Mahadevan 2018-10-03 812 561de45f72bd5f9b Girish Mahadevan 2018-10-03 813 /* Terminate and return success for 0 byte length transfer */ 561de45f72bd5f9b Girish Mahadevan 2018-10-03 814 if (!xfer->len) bcc874d4e76c4129 Vinod Koul 2021-01-11 815 return ret; 561de45f72bd5f9b Girish Mahadevan 2018-10-03 816 bcc874d4e76c4129 Vinod Koul 2021-01-11 817 if (mas->cur_xfer_mode == GENI_SE_FIFO) { 561de45f72bd5f9b Girish Mahadevan 2018-10-03 818 setup_fifo_xfer(xfer, mas, slv->mode, spi); bcc874d4e76c4129 Vinod Koul 2021-01-11 819 } else { bcc874d4e76c4129 Vinod Koul 2021-01-11 820 setup_gsi_xfer(xfer, mas, slv, spi); bcc874d4e76c4129 Vinod Koul 2021-01-11 821 if (mas->num_xfers >= NUM_SPI_XFER || bcc874d4e76c4129 Vinod Koul 2021-01-11 822 (list_is_last(&xfer->transfer_list, &spi->cur_msg->transfers))) { bcc874d4e76c4129 Vinod Koul 2021-01-11 823 for (i = 0 ; i < mas->num_tx_eot; i++) { bcc874d4e76c4129 Vinod Koul 2021-01-11 824 jiffies = msecs_to_jiffies(SPI_XFER_TIMEOUT_MS); bcc874d4e76c4129 Vinod Koul 2021-01-11 825 timeout = wait_for_completion_timeout(&mas->tx_cb, jiffies); bcc874d4e76c4129 Vinod Koul 2021-01-11 826 if (timeout <= 0) { bcc874d4e76c4129 Vinod Koul 2021-01-11 827 dev_err(mas->dev, "Tx[%d] timeout%lu\n", i, timeout); bcc874d4e76c4129 Vinod Koul 2021-01-11 828 ret = -ETIMEDOUT; bcc874d4e76c4129 Vinod Koul 2021-01-11 829 goto err_gsi_geni_transfer_one; bcc874d4e76c4129 Vinod Koul 2021-01-11 830 } bcc874d4e76c4129 Vinod Koul 2021-01-11 831 spi_finalize_current_transfer(spi); bcc874d4e76c4129 Vinod Koul 2021-01-11 832 } bcc874d4e76c4129 Vinod Koul 2021-01-11 833 for (i = 0 ; i < mas->num_rx_eot; i++) { bcc874d4e76c4129 Vinod Koul 2021-01-11 834 jiffies = msecs_to_jiffies(SPI_XFER_TIMEOUT_MS); bcc874d4e76c4129 Vinod Koul 2021-01-11 835 timeout = wait_for_completion_timeout(&mas->tx_cb, jiffies); bcc874d4e76c4129 Vinod Koul 2021-01-11 836 if (timeout <= 0) { bcc874d4e76c4129 Vinod Koul 2021-01-11 837 dev_err(mas->dev, "Rx[%d] timeout%lu\n", i, timeout); bcc874d4e76c4129 Vinod Koul 2021-01-11 838 ret = -ETIMEDOUT; bcc874d4e76c4129 Vinod Koul 2021-01-11 839 goto err_gsi_geni_transfer_one; bcc874d4e76c4129 Vinod Koul 2021-01-11 840 } bcc874d4e76c4129 Vinod Koul 2021-01-11 841 spi_finalize_current_transfer(spi); bcc874d4e76c4129 Vinod Koul 2021-01-11 842 } bcc874d4e76c4129 Vinod Koul 2021-01-11 843 if (mas->qn_err) { bcc874d4e76c4129 Vinod Koul 2021-01-11 844 ret = -EIO; bcc874d4e76c4129 Vinod Koul 2021-01-11 845 mas->qn_err = false; bcc874d4e76c4129 Vinod Koul 2021-01-11 846 goto err_gsi_geni_transfer_one; bcc874d4e76c4129 Vinod Koul 2021-01-11 847 } bcc874d4e76c4129 Vinod Koul 2021-01-11 848 } bcc874d4e76c4129 Vinod Koul 2021-01-11 849 } bcc874d4e76c4129 Vinod Koul 2021-01-11 850 bcc874d4e76c4129 Vinod Koul 2021-01-11 851 return ret; bcc874d4e76c4129 Vinod Koul 2021-01-11 852 bcc874d4e76c4129 Vinod Koul 2021-01-11 853 err_gsi_geni_transfer_one: bcc874d4e76c4129 Vinod Koul 2021-01-11 854 dmaengine_terminate_all(mas->tx); bcc874d4e76c4129 Vinod Koul 2021-01-11 855 return ret; 561de45f72bd5f9b Girish Mahadevan 2018-10-03 856 } 561de45f72bd5f9b Girish Mahadevan 2018-10-03 857 --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/[email protected]
.config.gz
Description: application/gzip
_______________________________________________ kbuild mailing list -- [email protected] To unsubscribe send an email to [email protected]
