tree:   https://git.kernel.org/pub/scm/linux/kernel/git/jberg/mac80211-next.git 
 rtnl
head:   81df9f5e047aa0424b954a726c3fc3259be26526
commit: 81df9f5e047aa0424b954a726c3fc3259be26526 [22/22] cfg80211: avoid 
holding the RTNL when calling the driver
config: x86_64-randconfig-m001-20210125 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-20) 9.3.0

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <[email protected]>
Reported-by: Dan Carpenter <[email protected]>

smatch warnings:
net/wireless/core.c:1336 cfg80211_register_netdevice() error: uninitialized 
symbol 'rdev'.

vim +/rdev +1336 net/wireless/core.c

cf2f4b65e4e9d866 Johannes Berg 2021-01-22  1329  int 
cfg80211_register_netdevice(struct net_device *dev)
cf2f4b65e4e9d866 Johannes Berg 2021-01-22  1330  {
cf2f4b65e4e9d866 Johannes Berg 2021-01-22  1331         struct wireless_dev 
*wdev = dev->ieee80211_ptr;
cf2f4b65e4e9d866 Johannes Berg 2021-01-22  1332         struct 
cfg80211_registered_device *rdev;
cf2f4b65e4e9d866 Johannes Berg 2021-01-22  1333         int ret;
cf2f4b65e4e9d866 Johannes Berg 2021-01-22  1334  
cf2f4b65e4e9d866 Johannes Berg 2021-01-22  1335         ASSERT_RTNL();
81df9f5e047aa042 Johannes Berg 2021-01-19 @1336         
lockdep_assert_held(&rdev->wiphy.mtx);
                                                                            
^^^^^^^^^^^^^^^^
Uninitialized

cf2f4b65e4e9d866 Johannes Berg 2021-01-22  1337  
cf2f4b65e4e9d866 Johannes Berg 2021-01-22  1338         if (WARN_ON(!wdev))
cf2f4b65e4e9d866 Johannes Berg 2021-01-22  1339                 return -EINVAL;
cf2f4b65e4e9d866 Johannes Berg 2021-01-22  1340  
cf2f4b65e4e9d866 Johannes Berg 2021-01-22  1341         rdev = 
wiphy_to_rdev(wdev->wiphy);
                                                        
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

cf2f4b65e4e9d866 Johannes Berg 2021-01-22  1342  
cf2f4b65e4e9d866 Johannes Berg 2021-01-22  1343         
lockdep_assert_held(&rdev->wiphy.mtx);
cf2f4b65e4e9d866 Johannes Berg 2021-01-22  1344  
cf2f4b65e4e9d866 Johannes Berg 2021-01-22  1345         /* we'll take care of 
this */
cf2f4b65e4e9d866 Johannes Berg 2021-01-22  1346         wdev->registered = true;
cf2f4b65e4e9d866 Johannes Berg 2021-01-22  1347         ret = 
register_netdevice(dev);
cf2f4b65e4e9d866 Johannes Berg 2021-01-22  1348         if (ret)
cf2f4b65e4e9d866 Johannes Berg 2021-01-22  1349                 goto out;
cf2f4b65e4e9d866 Johannes Berg 2021-01-22  1350  
cf2f4b65e4e9d866 Johannes Berg 2021-01-22  1351         if 
(sysfs_create_link(&dev->dev.kobj, &rdev->wiphy.dev.kobj,
cf2f4b65e4e9d866 Johannes Berg 2021-01-22  1352                               
"phy80211")) {
cf2f4b65e4e9d866 Johannes Berg 2021-01-22  1353                 pr_err("failed 
to add phy80211 symlink to netdev!\n");
cf2f4b65e4e9d866 Johannes Berg 2021-01-22  1354                 
unregister_netdevice(dev);
cf2f4b65e4e9d866 Johannes Berg 2021-01-22  1355                 ret = -EINVAL;
cf2f4b65e4e9d866 Johannes Berg 2021-01-22  1356                 goto out;
cf2f4b65e4e9d866 Johannes Berg 2021-01-22  1357         }
cf2f4b65e4e9d866 Johannes Berg 2021-01-22  1358  
cf2f4b65e4e9d866 Johannes Berg 2021-01-22  1359         
cfg80211_register_wdev(rdev, wdev);
cf2f4b65e4e9d866 Johannes Berg 2021-01-22  1360         ret = 0;
cf2f4b65e4e9d866 Johannes Berg 2021-01-22  1361  out:
cf2f4b65e4e9d866 Johannes Berg 2021-01-22  1362         if (ret)
cf2f4b65e4e9d866 Johannes Berg 2021-01-22  1363                 
wdev->registered = false;
cf2f4b65e4e9d866 Johannes Berg 2021-01-22  1364         return ret;
cf2f4b65e4e9d866 Johannes Berg 2021-01-22  1365  }

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/[email protected] 

Attachment: .config.gz
Description: application/gzip

_______________________________________________
kbuild mailing list -- [email protected]
To unsubscribe send an email to [email protected]
_______________________________________________
kbuild mailing list -- [email protected]
To unsubscribe send an email to [email protected]

Reply via email to