tree:   git://linuxtv.org/pinchartl/media.git am65x/devel/v4
head:   bd5d5f421c359cb5291d07410087503dd21bb0fe
commit: 9e10bd721ab5707b8787fef07d50ba418056e9e1 [33/50] media: entity: Move 
the pipeline from entity to pads
config: i386-randconfig-m021-20210128 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-15) 9.3.0

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <[email protected]>
Reported-by: Dan Carpenter <[email protected]>

smatch warnings:
drivers/media/mc/mc-entity.c:443 __media_pipeline_start() error: uninitialized 
symbol 'ret'.

vim +/ret +443 drivers/media/mc/mc-entity.c

20b852273642f4 drivers/media/media-entity.c Sakari Ailus              
2016-11-21  406  __must_check int __media_pipeline_start(struct media_entity 
*entity,
e02188c90f6ef6 drivers/media/media-entity.c Laurent Pinchart          
2010-08-25  407                                   struct media_pipeline *pipe)
e02188c90f6ef6 drivers/media/media-entity.c Laurent Pinchart          
2010-08-25  408  {
d10c98949d1a1f drivers/media/media-entity.c Javier Martinez Canillas  
2015-08-19  409   struct media_device *mdev = entity->graph_obj.mdev;
20b852273642f4 drivers/media/media-entity.c Sakari Ailus              
2016-11-21  410   struct media_graph *graph = &pipe->graph;
06e04736922bbe drivers/media/mc/mc-entity.c Sakari Ailus              
2019-03-28  411   struct media_pad *pad = entity->pads;
06e04736922bbe drivers/media/mc/mc-entity.c Sakari Ailus              
2019-03-28  412   struct media_pad *pad_err = pad;
57208e5e25f263 drivers/media/media-entity.c Mauro Carvalho Chehab     
2015-08-07  413   struct media_link *link;
af88be3887c1a0 drivers/media/media-entity.c Sakari Ailus              
2012-01-11  414   int ret;
e02188c90f6ef6 drivers/media/media-entity.c Laurent Pinchart          
2010-08-25  415  
74a4133079f739 drivers/media/media-entity.c Sakari Ailus              
2015-12-16  416   if (!pipe->streaming_count++) {
20b852273642f4 drivers/media/media-entity.c Sakari Ailus              
2016-11-21  417           ret = media_graph_walk_init(&pipe->graph, mdev);
74a4133079f739 drivers/media/media-entity.c Sakari Ailus              
2015-12-16  418           if (ret)
74a4133079f739 drivers/media/media-entity.c Sakari Ailus              
2015-12-16  419                   goto error_graph_walk_start;
106b9907c368e3 drivers/media/media-entity.c Sakari Ailus              
2015-12-16  420   }
106b9907c368e3 drivers/media/media-entity.c Sakari Ailus              
2015-12-16  421  
06e04736922bbe drivers/media/mc/mc-entity.c Sakari Ailus              
2019-03-28  422   media_graph_walk_start(&pipe->graph, pad);
06e04736922bbe drivers/media/mc/mc-entity.c Sakari Ailus              
2019-03-28  423  
06e04736922bbe drivers/media/mc/mc-entity.c Sakari Ailus              
2019-03-28  424   while ((pad = media_graph_walk_next(graph))) {
06e04736922bbe drivers/media/mc/mc-entity.c Sakari Ailus              
2019-03-28  425           struct media_entity *entity = pad->entity;
9e10bd721ab570 drivers/media/mc/mc-entity.c Sakari Ailus              
2019-03-28  426           bool skip_validation = pad->pipe;
9e10bd721ab570 drivers/media/mc/mc-entity.c Sakari Ailus              
2019-03-28  427           struct media_pad *iter;
e02188c90f6ef6 drivers/media/media-entity.c Laurent Pinchart          
2010-08-25  428  
ef69ee1bc2c10f drivers/media/media-entity.c Mauro Carvalho Chehab     
2015-10-01  429           DECLARE_BITMAP(active, MEDIA_ENTITY_MAX_PADS);
ef69ee1bc2c10f drivers/media/media-entity.c Mauro Carvalho Chehab     
2015-10-01  430           DECLARE_BITMAP(has_no_links, MEDIA_ENTITY_MAX_PADS);
af88be3887c1a0 drivers/media/media-entity.c Sakari Ailus              
2012-01-11  431  
9e10bd721ab570 drivers/media/mc/mc-entity.c Sakari Ailus              
2019-03-28  432           media_entity_for_each_pad(entity, iter) {
9e10bd721ab570 drivers/media/mc/mc-entity.c Sakari Ailus              
2019-03-28  433                   if (iter->pipe && iter->pipe != pipe) {
3eb87773dee633 drivers/media/media-entity.c Shuah Khan                
2019-02-22  434                           pr_err("Pipe active for %s. Can't 
start for %s\n",
9e10bd721ab570 drivers/media/mc/mc-entity.c Sakari Ailus              
2019-03-28  435                                  entity->name, 
iter->entity->name);
8aaf62b5b9bef7 drivers/media/media-entity.c Sakari Ailus              
2015-11-29  436                           ret = -EBUSY;
9e10bd721ab570 drivers/media/mc/mc-entity.c Sakari Ailus              
2019-03-28  437                   } else {
9e10bd721ab570 drivers/media/mc/mc-entity.c Sakari Ailus              
2019-03-28  438                           iter->pipe = pipe;
9e10bd721ab570 drivers/media/mc/mc-entity.c Sakari Ailus              
2019-03-28  439                   }
9e10bd721ab570 drivers/media/mc/mc-entity.c Sakari Ailus              
2019-03-28  440                   iter->stream_count++;
8aaf62b5b9bef7 drivers/media/media-entity.c Sakari Ailus              
2015-11-29  441           }
8aaf62b5b9bef7 drivers/media/media-entity.c Sakari Ailus              
2015-11-29  442  
9e10bd721ab570 drivers/media/mc/mc-entity.c Sakari Ailus              
2019-03-28 @443           if (ret)
9e10bd721ab570 drivers/media/mc/mc-entity.c Sakari Ailus              
2019-03-28  444                   goto error;

"ret" is not necessarily set on the success path.

af88be3887c1a0 drivers/media/media-entity.c Sakari Ailus              
2012-01-11  445  
9e10bd721ab570 drivers/media/mc/mc-entity.c Sakari Ailus              
2019-03-28  446           /* Already part of the pipeline, skip validation. */
9e10bd721ab570 drivers/media/mc/mc-entity.c Sakari Ailus              
2019-03-28  447           if (skip_validation)

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/[email protected]

Attachment: .config.gz
Description: application/gzip

_______________________________________________
kbuild mailing list -- [email protected]
To unsubscribe send an email to [email protected]

Reply via email to