CC: [email protected]
In-Reply-To: <[email protected]>
References: <[email protected]>
TO: Nicholas Piggin <[email protected]>
TO: [email protected]
TO: Andrew Morton <[email protected]>
CC: Linux Memory Management List <[email protected]>
CC: Nicholas Piggin <[email protected]>
CC: [email protected]
CC: [email protected]
CC: [email protected]
CC: Jonathan Cameron <[email protected]>
CC: Christoph Hellwig <[email protected]>
CC: Christophe Leroy <[email protected]>

Hi Nicholas,

I love your patch! Perhaps something to improve:

[auto build test WARNING on powerpc/next]
[also build test WARNING on arm64/for-next/core v5.11-rc6 next-20210125]
[cannot apply to hnaz-linux-mm/master]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    
https://github.com/0day-ci/linux/commits/Nicholas-Piggin/huge-vmalloc-mappings/20210202-190833
base:   https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git next
:::::: branch date: 11 hours ago
:::::: commit date: 11 hours ago
config: x86_64-randconfig-m001-20210202 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-15) 9.3.0

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <[email protected]>
Reported-by: Dan Carpenter <[email protected]>

smatch warnings:
mm/vmalloc.c:266 vmap_range_noflush() warn: bitwise AND condition is false here

vim +266 mm/vmalloc.c

6eeeb316e3f099 Nicholas Piggin 2021-02-02  242  
ce778f16d62a93 Nicholas Piggin 2021-02-02  243  static int 
vmap_range_noflush(unsigned long addr, unsigned long end,
6eeeb316e3f099 Nicholas Piggin 2021-02-02  244                          
phys_addr_t phys_addr, pgprot_t prot,
6eeeb316e3f099 Nicholas Piggin 2021-02-02  245                          
unsigned int max_page_shift)
6eeeb316e3f099 Nicholas Piggin 2021-02-02  246  {
6eeeb316e3f099 Nicholas Piggin 2021-02-02  247          pgd_t *pgd;
6eeeb316e3f099 Nicholas Piggin 2021-02-02  248          unsigned long start;
6eeeb316e3f099 Nicholas Piggin 2021-02-02  249          unsigned long next;
6eeeb316e3f099 Nicholas Piggin 2021-02-02  250          int err;
6eeeb316e3f099 Nicholas Piggin 2021-02-02  251          pgtbl_mod_mask mask = 0;
6eeeb316e3f099 Nicholas Piggin 2021-02-02  252  
6eeeb316e3f099 Nicholas Piggin 2021-02-02  253          might_sleep();
6eeeb316e3f099 Nicholas Piggin 2021-02-02  254          BUG_ON(addr >= end);
6eeeb316e3f099 Nicholas Piggin 2021-02-02  255  
6eeeb316e3f099 Nicholas Piggin 2021-02-02  256          start = addr;
6eeeb316e3f099 Nicholas Piggin 2021-02-02  257          pgd = 
pgd_offset_k(addr);
6eeeb316e3f099 Nicholas Piggin 2021-02-02  258          do {
6eeeb316e3f099 Nicholas Piggin 2021-02-02  259                  next = 
pgd_addr_end(addr, end);
6eeeb316e3f099 Nicholas Piggin 2021-02-02  260                  err = 
vmap_p4d_range(pgd, addr, next, phys_addr, prot,
6eeeb316e3f099 Nicholas Piggin 2021-02-02  261                                  
        max_page_shift, &mask);
6eeeb316e3f099 Nicholas Piggin 2021-02-02  262                  if (err)
6eeeb316e3f099 Nicholas Piggin 2021-02-02  263                          break;
6eeeb316e3f099 Nicholas Piggin 2021-02-02  264          } while (pgd++, 
phys_addr += (next - addr), addr = next, addr != end);
6eeeb316e3f099 Nicholas Piggin 2021-02-02  265  
6eeeb316e3f099 Nicholas Piggin 2021-02-02 @266          if (mask & 
ARCH_PAGE_TABLE_SYNC_MASK)
6eeeb316e3f099 Nicholas Piggin 2021-02-02  267                  
arch_sync_kernel_mappings(start, end);
6eeeb316e3f099 Nicholas Piggin 2021-02-02  268  
6eeeb316e3f099 Nicholas Piggin 2021-02-02  269          return err;
6eeeb316e3f099 Nicholas Piggin 2021-02-02  270  }
b221385bc41d67 Adrian Bunk     2006-09-25  271  

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/[email protected]

Attachment: .config.gz
Description: application/gzip

_______________________________________________
kbuild mailing list -- [email protected]
To unsubscribe send an email to [email protected]

Reply via email to