CC: [email protected]
In-Reply-To: <[email protected]>
References: <[email protected]>
TO: Nicholas Piggin <[email protected]>
TO: [email protected]
TO: Andrew Morton <[email protected]>
CC: Linux Memory Management List <[email protected]>
CC: Nicholas Piggin <[email protected]>
CC: [email protected]
CC: [email protected]
CC: [email protected]
CC: Jonathan Cameron <[email protected]>
CC: Christoph Hellwig <[email protected]>
CC: Christophe Leroy <[email protected]>

Hi Nicholas,

I love your patch! Perhaps something to improve:

[auto build test WARNING on powerpc/next]
[also build test WARNING on arm64/for-next/core v5.11-rc6]
[cannot apply to hnaz-linux-mm/master next-20210125]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    
https://github.com/0day-ci/linux/commits/Nicholas-Piggin/huge-vmalloc-mappings/20210202-190833
base:   https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git next
:::::: branch date: 17 hours ago
:::::: commit date: 17 hours ago
config: x86_64-randconfig-m001-20210202 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-15) 9.3.0

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <[email protected]>
Reported-by: Dan Carpenter <[email protected]>

smatch warnings:
mm/vmalloc.c:520 vmap_small_pages_range_noflush() warn: bitwise AND condition 
is false here
mm/vmalloc.c:2933 __vmalloc_node_range() error: uninitialized symbol 'area'.

vim +520 mm/vmalloc.c

c2febafc67734a Kirill A. Shutemov 2017-03-09  498  
2362efe9169e3d Nicholas Piggin    2021-02-02  499  static int 
vmap_small_pages_range_noflush(unsigned long addr, unsigned long end,
db64fe02258f15 Nick Piggin        2008-10-18  500               pgprot_t prot, 
struct page **pages)
^1da177e4c3f41 Linus Torvalds     2005-04-16  501  {
2ba3e6947aed9b Joerg Roedel       2020-06-01  502       unsigned long start = 
addr;
b521c43f58e523 Christoph Hellwig  2020-06-01  503       pgd_t *pgd;
2362efe9169e3d Nicholas Piggin    2021-02-02  504       unsigned long next;
db64fe02258f15 Nick Piggin        2008-10-18  505       int err = 0;
db64fe02258f15 Nick Piggin        2008-10-18  506       int nr = 0;
2ba3e6947aed9b Joerg Roedel       2020-06-01  507       pgtbl_mod_mask mask = 0;
^1da177e4c3f41 Linus Torvalds     2005-04-16  508  
^1da177e4c3f41 Linus Torvalds     2005-04-16  509       BUG_ON(addr >= end);
^1da177e4c3f41 Linus Torvalds     2005-04-16  510       pgd = 
pgd_offset_k(addr);
^1da177e4c3f41 Linus Torvalds     2005-04-16  511       do {
^1da177e4c3f41 Linus Torvalds     2005-04-16  512               next = 
pgd_addr_end(addr, end);
2ba3e6947aed9b Joerg Roedel       2020-06-01  513               if 
(pgd_bad(*pgd))
2ba3e6947aed9b Joerg Roedel       2020-06-01  514                       mask |= 
PGTBL_PGD_MODIFIED;
2ef69bb78a3fb7 Nicholas Piggin    2021-02-02  515               err = 
vmap_pages_p4d_range(pgd, addr, next, prot, pages, &nr, &mask);
^1da177e4c3f41 Linus Torvalds     2005-04-16  516               if (err)
bf88c8c83e4425 Figo.zhang         2009-09-21  517                       return 
err;
^1da177e4c3f41 Linus Torvalds     2005-04-16  518       } while (pgd++, addr = 
next, addr != end);
db64fe02258f15 Nick Piggin        2008-10-18  519  
2ba3e6947aed9b Joerg Roedel       2020-06-01 @520       if (mask & 
ARCH_PAGE_TABLE_SYNC_MASK)
2ba3e6947aed9b Joerg Roedel       2020-06-01  521               
arch_sync_kernel_mappings(start, end);
2ba3e6947aed9b Joerg Roedel       2020-06-01  522  
60bb44652a0dcc Christoph Hellwig  2020-06-01  523       return 0;
^1da177e4c3f41 Linus Torvalds     2005-04-16  524  }
^1da177e4c3f41 Linus Torvalds     2005-04-16  525  

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/[email protected]

Attachment: .config.gz
Description: application/gzip

_______________________________________________
kbuild mailing list -- [email protected]
To unsubscribe send an email to [email protected]

Reply via email to