CC: [email protected] In-Reply-To: <[email protected]> References: <[email protected]> TO: Calvin Johnson <[email protected]>
Hi Calvin, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on net-next/master] url: https://github.com/0day-ci/linux/commits/Calvin-Johnson/ACPI-support-for-dpaa2-driver/20210209-084334 base: https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git 6626a0266566c5aea16178c5e6cd7fc4db3f2f56 :::::: branch date: 8 hours ago :::::: commit date: 8 hours ago config: i386-randconfig-m021-20210209 (attached as .config) compiler: gcc-9 (Debian 9.3.0-15) 9.3.0 If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot <[email protected]> Reported-by: Dan Carpenter <[email protected]> New smatch warnings: drivers/net/phy/mdio_bus.c:134 fwnode_mdiobus_register_phy() error: uninitialized symbol 'mii_ts'. Old smatch warnings: drivers/net/phy/mdio_bus.c:157 fwnode_mdiobus_register_phy() error: uninitialized symbol 'mii_ts'. drivers/net/phy/mdio_bus.c:167 fwnode_mdiobus_register_phy() error: uninitialized symbol 'mii_ts'. include/linux/u64_stats_sync.h:128 u64_stats_update_begin() warn: statement has no effect 31 vim +/mii_ts +134 drivers/net/phy/mdio_bus.c 7f854420fbfe9d Andrew Lunn 2016-01-06 109 36305d64c94998 Calvin Johnson 2021-02-08 110 int fwnode_mdiobus_register_phy(struct mii_bus *bus, 36305d64c94998 Calvin Johnson 2021-02-08 111 struct fwnode_handle *child, u32 addr) 36305d64c94998 Calvin Johnson 2021-02-08 112 { 36305d64c94998 Calvin Johnson 2021-02-08 113 struct mii_timestamper *mii_ts; 36305d64c94998 Calvin Johnson 2021-02-08 114 struct phy_device *phy; 36305d64c94998 Calvin Johnson 2021-02-08 115 bool is_c45 = false; 36305d64c94998 Calvin Johnson 2021-02-08 116 u32 phy_id; 36305d64c94998 Calvin Johnson 2021-02-08 117 int rc; 36305d64c94998 Calvin Johnson 2021-02-08 118 36305d64c94998 Calvin Johnson 2021-02-08 119 if (is_of_node(child)) { 36305d64c94998 Calvin Johnson 2021-02-08 120 mii_ts = of_find_mii_timestamper(to_of_node(child)); 36305d64c94998 Calvin Johnson 2021-02-08 121 if (IS_ERR(mii_ts)) 36305d64c94998 Calvin Johnson 2021-02-08 122 return PTR_ERR(mii_ts); 36305d64c94998 Calvin Johnson 2021-02-08 123 } 36305d64c94998 Calvin Johnson 2021-02-08 124 36305d64c94998 Calvin Johnson 2021-02-08 125 rc = fwnode_property_match_string(child, "compatible", "ethernet-phy-ieee802.3-c45"); 36305d64c94998 Calvin Johnson 2021-02-08 126 if (rc >= 0) 36305d64c94998 Calvin Johnson 2021-02-08 127 is_c45 = true; 36305d64c94998 Calvin Johnson 2021-02-08 128 36305d64c94998 Calvin Johnson 2021-02-08 129 if (is_c45 || fwnode_get_phy_id(child, &phy_id)) 36305d64c94998 Calvin Johnson 2021-02-08 130 phy = get_phy_device(bus, addr, is_c45); 36305d64c94998 Calvin Johnson 2021-02-08 131 else 36305d64c94998 Calvin Johnson 2021-02-08 132 phy = phy_device_create(bus, addr, phy_id, 0, NULL); 36305d64c94998 Calvin Johnson 2021-02-08 133 if (IS_ERR(phy)) { 36305d64c94998 Calvin Johnson 2021-02-08 @134 if (mii_ts && is_of_node(child)) 36305d64c94998 Calvin Johnson 2021-02-08 135 unregister_mii_timestamper(mii_ts); 36305d64c94998 Calvin Johnson 2021-02-08 136 return PTR_ERR(phy); 36305d64c94998 Calvin Johnson 2021-02-08 137 } 36305d64c94998 Calvin Johnson 2021-02-08 138 36305d64c94998 Calvin Johnson 2021-02-08 139 if (is_acpi_node(child)) { 36305d64c94998 Calvin Johnson 2021-02-08 140 phy->irq = bus->irq[addr]; 36305d64c94998 Calvin Johnson 2021-02-08 141 36305d64c94998 Calvin Johnson 2021-02-08 142 /* Associate the fwnode with the device structure so it 36305d64c94998 Calvin Johnson 2021-02-08 143 * can be looked up later. 36305d64c94998 Calvin Johnson 2021-02-08 144 */ 36305d64c94998 Calvin Johnson 2021-02-08 145 phy->mdio.dev.fwnode = child; 36305d64c94998 Calvin Johnson 2021-02-08 146 36305d64c94998 Calvin Johnson 2021-02-08 147 /* All data is now stored in the phy struct, so register it */ 36305d64c94998 Calvin Johnson 2021-02-08 148 rc = phy_device_register(phy); 36305d64c94998 Calvin Johnson 2021-02-08 149 if (rc) { 36305d64c94998 Calvin Johnson 2021-02-08 150 phy_device_free(phy); 36305d64c94998 Calvin Johnson 2021-02-08 151 fwnode_handle_put(phy->mdio.dev.fwnode); 36305d64c94998 Calvin Johnson 2021-02-08 152 return rc; 36305d64c94998 Calvin Johnson 2021-02-08 153 } 36305d64c94998 Calvin Johnson 2021-02-08 154 } else if (is_of_node(child)) { 36305d64c94998 Calvin Johnson 2021-02-08 155 rc = of_mdiobus_phy_device_register(bus, phy, to_of_node(child), addr); 36305d64c94998 Calvin Johnson 2021-02-08 156 if (rc) { 36305d64c94998 Calvin Johnson 2021-02-08 157 if (mii_ts) 36305d64c94998 Calvin Johnson 2021-02-08 158 unregister_mii_timestamper(mii_ts); 36305d64c94998 Calvin Johnson 2021-02-08 159 phy_device_free(phy); 36305d64c94998 Calvin Johnson 2021-02-08 160 return rc; 36305d64c94998 Calvin Johnson 2021-02-08 161 } 36305d64c94998 Calvin Johnson 2021-02-08 162 36305d64c94998 Calvin Johnson 2021-02-08 163 /* phy->mii_ts may already be defined by the PHY driver. A 36305d64c94998 Calvin Johnson 2021-02-08 164 * mii_timestamper probed via the device tree will still have 36305d64c94998 Calvin Johnson 2021-02-08 165 * precedence. 36305d64c94998 Calvin Johnson 2021-02-08 166 */ 36305d64c94998 Calvin Johnson 2021-02-08 167 if (mii_ts) 36305d64c94998 Calvin Johnson 2021-02-08 168 phy->mii_ts = mii_ts; 36305d64c94998 Calvin Johnson 2021-02-08 169 } 36305d64c94998 Calvin Johnson 2021-02-08 170 return 0; 36305d64c94998 Calvin Johnson 2021-02-08 171 } 36305d64c94998 Calvin Johnson 2021-02-08 172 EXPORT_SYMBOL(fwnode_mdiobus_register_phy); 36305d64c94998 Calvin Johnson 2021-02-08 173 --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/[email protected]
.config.gz
Description: application/gzip
_______________________________________________ kbuild mailing list -- [email protected] To unsubscribe send an email to [email protected]
