CC: [email protected] In-Reply-To: <[email protected]> References: <[email protected]> TO: Lorenz Bauer <[email protected]> TO: [email protected] TO: [email protected] TO: [email protected] TO: [email protected] CC: [email protected] CC: [email protected] CC: [email protected] CC: Lorenz Bauer <[email protected]>
Hi Lorenz, I love your patch! Perhaps something to improve: [auto build test WARNING on bpf-next/master] url: https://github.com/0day-ci/linux/commits/Lorenz-Bauer/PROG_TEST_RUN-support-for-sk_lookup-programs/20210216-190705 base: https://git.kernel.org/pub/scm/linux/kernel/git/bpf/bpf-next.git master :::::: branch date: 3 hours ago :::::: commit date: 3 hours ago config: i386-randconfig-m021-20210215 (attached as .config) compiler: gcc-9 (Debian 9.3.0-15) 9.3.0 If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot <[email protected]> Reported-by: Dan Carpenter <[email protected]> New smatch warnings: net/bpf/test_run.c:774 bpf_prog_test_run_flow_dissector() error: uninitialized symbol 'retval'. Old smatch warnings: include/linux/u64_stats_sync.h:128 u64_stats_update_begin() warn: statement has no effect 31 vim +/retval +774 net/bpf/test_run.c b2ca4e1cfa7d3d Stanislav Fomichev 2019-07-25 714 b7a1848e8398b8 Stanislav Fomichev 2019-01-28 715 int bpf_prog_test_run_flow_dissector(struct bpf_prog *prog, b7a1848e8398b8 Stanislav Fomichev 2019-01-28 716 const union bpf_attr *kattr, b7a1848e8398b8 Stanislav Fomichev 2019-01-28 717 union bpf_attr __user *uattr) b7a1848e8398b8 Stanislav Fomichev 2019-01-28 718 { 938a0856b8ac67 Lorenz Bauer 2021-02-16 719 struct test_timer t = { NO_PREEMPT }; b7a1848e8398b8 Stanislav Fomichev 2019-01-28 720 u32 size = kattr->test.data_size_in; 7b8a1304323b35 Stanislav Fomichev 2019-04-22 721 struct bpf_flow_dissector ctx = {}; b7a1848e8398b8 Stanislav Fomichev 2019-01-28 722 u32 repeat = kattr->test.repeat; b2ca4e1cfa7d3d Stanislav Fomichev 2019-07-25 723 struct bpf_flow_keys *user_ctx; b7a1848e8398b8 Stanislav Fomichev 2019-01-28 724 struct bpf_flow_keys flow_keys; 7b8a1304323b35 Stanislav Fomichev 2019-04-22 725 const struct ethhdr *eth; b2ca4e1cfa7d3d Stanislav Fomichev 2019-07-25 726 unsigned int flags = 0; b7a1848e8398b8 Stanislav Fomichev 2019-01-28 727 u32 retval, duration; b7a1848e8398b8 Stanislav Fomichev 2019-01-28 728 void *data; b7a1848e8398b8 Stanislav Fomichev 2019-01-28 729 int ret; b7a1848e8398b8 Stanislav Fomichev 2019-01-28 730 b7a1848e8398b8 Stanislav Fomichev 2019-01-28 731 if (prog->type != BPF_PROG_TYPE_FLOW_DISSECTOR) b7a1848e8398b8 Stanislav Fomichev 2019-01-28 732 return -EINVAL; b7a1848e8398b8 Stanislav Fomichev 2019-01-28 733 1b4d60ec162f82 Song Liu 2020-09-25 734 if (kattr->test.flags || kattr->test.cpu) 1b4d60ec162f82 Song Liu 2020-09-25 735 return -EINVAL; 1b4d60ec162f82 Song Liu 2020-09-25 736 7b8a1304323b35 Stanislav Fomichev 2019-04-22 737 if (size < ETH_HLEN) 7b8a1304323b35 Stanislav Fomichev 2019-04-22 738 return -EINVAL; 7b8a1304323b35 Stanislav Fomichev 2019-04-22 739 7b8a1304323b35 Stanislav Fomichev 2019-04-22 740 data = bpf_test_init(kattr, size, 0, 0); b7a1848e8398b8 Stanislav Fomichev 2019-01-28 741 if (IS_ERR(data)) b7a1848e8398b8 Stanislav Fomichev 2019-01-28 742 return PTR_ERR(data); b7a1848e8398b8 Stanislav Fomichev 2019-01-28 743 7b8a1304323b35 Stanislav Fomichev 2019-04-22 744 eth = (struct ethhdr *)data; b7a1848e8398b8 Stanislav Fomichev 2019-01-28 745 b7a1848e8398b8 Stanislav Fomichev 2019-01-28 746 if (!repeat) b7a1848e8398b8 Stanislav Fomichev 2019-01-28 747 repeat = 1; b7a1848e8398b8 Stanislav Fomichev 2019-01-28 748 b2ca4e1cfa7d3d Stanislav Fomichev 2019-07-25 749 user_ctx = bpf_ctx_init(kattr, sizeof(struct bpf_flow_keys)); b2ca4e1cfa7d3d Stanislav Fomichev 2019-07-25 750 if (IS_ERR(user_ctx)) { b2ca4e1cfa7d3d Stanislav Fomichev 2019-07-25 751 kfree(data); b2ca4e1cfa7d3d Stanislav Fomichev 2019-07-25 752 return PTR_ERR(user_ctx); b2ca4e1cfa7d3d Stanislav Fomichev 2019-07-25 753 } b2ca4e1cfa7d3d Stanislav Fomichev 2019-07-25 754 if (user_ctx) { b2ca4e1cfa7d3d Stanislav Fomichev 2019-07-25 755 ret = verify_user_bpf_flow_keys(user_ctx); b2ca4e1cfa7d3d Stanislav Fomichev 2019-07-25 756 if (ret) b2ca4e1cfa7d3d Stanislav Fomichev 2019-07-25 757 goto out; b2ca4e1cfa7d3d Stanislav Fomichev 2019-07-25 758 flags = user_ctx->flags; b2ca4e1cfa7d3d Stanislav Fomichev 2019-07-25 759 } b2ca4e1cfa7d3d Stanislav Fomichev 2019-07-25 760 7b8a1304323b35 Stanislav Fomichev 2019-04-22 761 ctx.flow_keys = &flow_keys; 7b8a1304323b35 Stanislav Fomichev 2019-04-22 762 ctx.data = data; 7b8a1304323b35 Stanislav Fomichev 2019-04-22 763 ctx.data_end = (__u8 *)data + size; 7b8a1304323b35 Stanislav Fomichev 2019-04-22 764 938a0856b8ac67 Lorenz Bauer 2021-02-16 765 while (t_check(&t, repeat, &ret, &duration)) { 7b8a1304323b35 Stanislav Fomichev 2019-04-22 766 retval = bpf_flow_dissect(prog, &ctx, eth->h_proto, ETH_HLEN, b2ca4e1cfa7d3d Stanislav Fomichev 2019-07-25 767 size, flags); a439184d515fbf Stanislav Fomichev 2019-02-19 768 } b7a1848e8398b8 Stanislav Fomichev 2019-01-28 769 938a0856b8ac67 Lorenz Bauer 2021-02-16 770 if (ret < 0) 938a0856b8ac67 Lorenz Bauer 2021-02-16 771 goto out; b7a1848e8398b8 Stanislav Fomichev 2019-01-28 772 b7a1848e8398b8 Stanislav Fomichev 2019-01-28 773 ret = bpf_test_finish(kattr, uattr, &flow_keys, sizeof(flow_keys), b7a1848e8398b8 Stanislav Fomichev 2019-01-28 @774 retval, duration); --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/[email protected]
.config.gz
Description: application/gzip
_______________________________________________ kbuild mailing list -- [email protected] To unsubscribe send an email to [email protected]
