CC: [email protected] TO: Kuninori Morimoto <[email protected]>
tree: https://github.com/morimoto/linux fw-cleanup-2021-02-19-v1 head: d725907b967c16bb0c4982a395b4bbdbc05c6e5b commit: a5dae1e31bf0ec5b45a5b86d830e5ae33c4ecc1a [20/106] ASoC: soc-pcm: indicate error message at dpcm_apply_symmetry() :::::: branch date: 2 hours ago :::::: commit date: 26 hours ago config: sh-randconfig-m031-20210219 (attached as .config) compiler: sh4-linux-gcc (GCC) 9.3.0 If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot <[email protected]> Reported-by: Dan Carpenter <[email protected]> smatch warnings: sound/soc/soc-pcm.c:1738 dpcm_apply_symmetry() error: uninitialized symbol 'err'. vim +/err +1738 sound/soc/soc-pcm.c baacd8d100d571 Jerome Brunet 2018-07-05 1691 906c7d690c3b80 PC Liao 2015-12-11 1692 static int dpcm_apply_symmetry(struct snd_pcm_substream *fe_substream, 906c7d690c3b80 PC Liao 2015-12-11 1693 int stream) 906c7d690c3b80 PC Liao 2015-12-11 1694 { 906c7d690c3b80 PC Liao 2015-12-11 1695 struct snd_soc_dpcm *dpcm; 0ceef681e34a61 Kuninori Morimoto 2020-07-20 1696 struct snd_soc_pcm_runtime *fe = asoc_substream_to_rtd(fe_substream); 19bdcc7aeed416 Shreyas NC 2020-02-25 1697 struct snd_soc_dai *fe_cpu_dai; 906c7d690c3b80 PC Liao 2015-12-11 1698 int err; 19bdcc7aeed416 Shreyas NC 2020-02-25 1699 int i; 906c7d690c3b80 PC Liao 2015-12-11 1700 906c7d690c3b80 PC Liao 2015-12-11 1701 /* apply symmetry for FE */ 84ce5f144b22d1 Kuninori Morimoto 2020-01-22 1702 soc_pcm_care_symmetry(fe_substream); 906c7d690c3b80 PC Liao 2015-12-11 1703 a4be4187b2bfc6 Kuninori Morimoto 2020-03-09 1704 for_each_rtd_cpu_dais (fe, i, fe_cpu_dai) { 906c7d690c3b80 PC Liao 2015-12-11 1705 /* Symmetry only applies if we've got an active stream. */ 906c7d690c3b80 PC Liao 2015-12-11 1706 err = soc_pcm_apply_symmetry(fe_substream, fe_cpu_dai); 906c7d690c3b80 PC Liao 2015-12-11 1707 if (err < 0) a5dae1e31bf0ec Kuninori Morimoto 2021-02-18 1708 goto error; 906c7d690c3b80 PC Liao 2015-12-11 1709 } 906c7d690c3b80 PC Liao 2015-12-11 1710 906c7d690c3b80 PC Liao 2015-12-11 1711 /* apply symmetry for BE */ 8d6258a4dd2678 Kuninori Morimoto 2018-09-18 1712 for_each_dpcm_be(fe, stream, dpcm) { 906c7d690c3b80 PC Liao 2015-12-11 1713 struct snd_soc_pcm_runtime *be = dpcm->be; 906c7d690c3b80 PC Liao 2015-12-11 1714 struct snd_pcm_substream *be_substream = 906c7d690c3b80 PC Liao 2015-12-11 1715 snd_soc_dpcm_get_substream(be, stream); 6246f283d5e02a Jerome Brunet 2019-04-01 1716 struct snd_soc_pcm_runtime *rtd; c840f7698d26b0 Kuninori Morimoto 2020-03-16 1717 struct snd_soc_dai *dai; 906c7d690c3b80 PC Liao 2015-12-11 1718 int i; 906c7d690c3b80 PC Liao 2015-12-11 1719 6246f283d5e02a Jerome Brunet 2019-04-01 1720 /* A backend may not have the requested substream */ 6246f283d5e02a Jerome Brunet 2019-04-01 1721 if (!be_substream) 6246f283d5e02a Jerome Brunet 2019-04-01 1722 continue; 6246f283d5e02a Jerome Brunet 2019-04-01 1723 0ceef681e34a61 Kuninori Morimoto 2020-07-20 1724 rtd = asoc_substream_to_rtd(be_substream); f11766143caa06 Jeeja KP 2016-09-06 1725 if (rtd->dai_link->be_hw_params_fixup) f11766143caa06 Jeeja KP 2016-09-06 1726 continue; f11766143caa06 Jeeja KP 2016-09-06 1727 84ce5f144b22d1 Kuninori Morimoto 2020-01-22 1728 soc_pcm_care_symmetry(be_substream); 906c7d690c3b80 PC Liao 2015-12-11 1729 906c7d690c3b80 PC Liao 2015-12-11 1730 /* Symmetry only applies if we've got an active stream. */ c840f7698d26b0 Kuninori Morimoto 2020-03-16 1731 for_each_rtd_dais(rtd, i, dai) { c840f7698d26b0 Kuninori Morimoto 2020-03-16 1732 err = soc_pcm_apply_symmetry(fe_substream, dai); 906c7d690c3b80 PC Liao 2015-12-11 1733 if (err < 0) a5dae1e31bf0ec Kuninori Morimoto 2021-02-18 1734 goto error; 906c7d690c3b80 PC Liao 2015-12-11 1735 } 906c7d690c3b80 PC Liao 2015-12-11 1736 } a5dae1e31bf0ec Kuninori Morimoto 2021-02-18 1737 error: a5dae1e31bf0ec Kuninori Morimoto 2021-02-18 @1738 if (err < 0) a5dae1e31bf0ec Kuninori Morimoto 2021-02-18 1739 dev_err(fe->dev, "ASoC: %s failed (%d)\n", __func__, err); 906c7d690c3b80 PC Liao 2015-12-11 1740 a5dae1e31bf0ec Kuninori Morimoto 2021-02-18 1741 return err; 906c7d690c3b80 PC Liao 2015-12-11 1742 } 906c7d690c3b80 PC Liao 2015-12-11 1743 --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/[email protected]
.config.gz
Description: application/gzip
_______________________________________________ kbuild mailing list -- [email protected] To unsubscribe send an email to [email protected]
