tree:   
https://github.com/0day-ci/linux/commits/UPDATE-20210221-080227/Tong-Zhang/video-fbdev-pm2fb-avoid-stall-on-fb_sync/20210221-070421
head:   cf83deca80e53c5a8c9a0e43efcea8bf7306a7a7
commit: cf83deca80e53c5a8c9a0e43efcea8bf7306a7a7 video: fbdev: pm2fb: avoid 
stall on fb_sync
config: s390-randconfig-m031-20210221 (attached as .config)
compiler: s390-linux-gcc (GCC) 9.3.0

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <[email protected]>
Reported-by: Dan Carpenter <[email protected]>

smatch warnings:
drivers/video/fbdev/pm2fb.c:1064 pm2fb_sync() error: uninitialized symbol 
'timeout_fifo'.

vim +/timeout_fifo +1064 drivers/video/fbdev/pm2fb.c

03b9ae4b80dd5b drivers/video/pm2fb.c       Antonino A. Daplas 2007-05-10  1042  
static int pm2fb_sync(struct fb_info *info)
03b9ae4b80dd5b drivers/video/pm2fb.c       Antonino A. Daplas 2007-05-10  1043  
{
03b9ae4b80dd5b drivers/video/pm2fb.c       Antonino A. Daplas 2007-05-10  1044  
        struct pm2fb_par *par = info->par;
cf83deca80e53c drivers/video/fbdev/pm2fb.c Tong Zhang         2021-02-20  1045  
        int timeout_sync = 10000;
cf83deca80e53c drivers/video/fbdev/pm2fb.c Tong Zhang         2021-02-20  1046  
        int timeout_fifo;
03b9ae4b80dd5b drivers/video/pm2fb.c       Antonino A. Daplas 2007-05-10  1047  
cf83deca80e53c drivers/video/fbdev/pm2fb.c Tong Zhang         2021-02-20  1048  
        if (WAIT_FIFO_TIMEOUT(par, 1))
cf83deca80e53c drivers/video/fbdev/pm2fb.c Tong Zhang         2021-02-20  1049  
                goto end;
                                                                                
                ^^^^^^^^
Assume we hit this goto

03b9ae4b80dd5b drivers/video/pm2fb.c       Antonino A. Daplas 2007-05-10  1050  
        pm2_WR(par, PM2R_SYNC, 0);
03b9ae4b80dd5b drivers/video/pm2fb.c       Antonino A. Daplas 2007-05-10  1051  
        mb();
03b9ae4b80dd5b drivers/video/pm2fb.c       Antonino A. Daplas 2007-05-10  1052  
        do {
cf83deca80e53c drivers/video/fbdev/pm2fb.c Tong Zhang         2021-02-20  1053  
                timeout_fifo = 10000;
cf83deca80e53c drivers/video/fbdev/pm2fb.c Tong Zhang         2021-02-20  1054  
                while (pm2_RD(par, PM2R_OUT_FIFO_WORDS) == 0) {
6416ad73658336 drivers/video/pm2fb.c       Krzysztof Helt     2007-10-16  1055  
                        cpu_relax();
cf83deca80e53c drivers/video/fbdev/pm2fb.c Tong Zhang         2021-02-20  1056  
                        if (--timeout_fifo == 0)
cf83deca80e53c drivers/video/fbdev/pm2fb.c Tong Zhang         2021-02-20  1057  
                                goto end;
cf83deca80e53c drivers/video/fbdev/pm2fb.c Tong Zhang         2021-02-20  1058  
                }
cf83deca80e53c drivers/video/fbdev/pm2fb.c Tong Zhang         2021-02-20  1059  
                if (pm2_RD(par, PM2R_OUT_FIFO) == PM2TAG(PM2R_SYNC))
cf83deca80e53c drivers/video/fbdev/pm2fb.c Tong Zhang         2021-02-20  1060  
                        break;
cf83deca80e53c drivers/video/fbdev/pm2fb.c Tong Zhang         2021-02-20  1061  
        } while (--timeout_sync > 0);
03b9ae4b80dd5b drivers/video/pm2fb.c       Antonino A. Daplas 2007-05-10  1062  
cf83deca80e53c drivers/video/fbdev/pm2fb.c Tong Zhang         2021-02-20  1063  
end:
cf83deca80e53c drivers/video/fbdev/pm2fb.c Tong Zhang         2021-02-20 @1064  
        if ((!timeout_sync) || (!timeout_fifo))
                                                                                
                                ^^^^^^^^^^^^^
Uninitialized

cf83deca80e53c drivers/video/fbdev/pm2fb.c Tong Zhang         2021-02-20  1065  
                printk_ratelimited(KERN_WARNING "pm2fb: sync timeout!\n");
03b9ae4b80dd5b drivers/video/pm2fb.c       Antonino A. Daplas 2007-05-10  1066  
        return 0;
03b9ae4b80dd5b drivers/video/pm2fb.c       Antonino A. Daplas 2007-05-10  1067  
}

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/[email protected]

Attachment: .config.gz
Description: application/gzip

_______________________________________________
kbuild mailing list -- [email protected]
To unsubscribe send an email to [email protected]

Reply via email to