CC: [email protected] CC: [email protected] CC: [email protected] TO: "Gwan-gyeong Mun" <[email protected]> CC: "José Roberto de Souza" <[email protected]>
tree: git://anongit.freedesktop.org/drm-intel for-linux-next head: 2d667442dbe70e7e78c3450b17ba5aa5032a7b6b commit: 2d667442dbe70e7e78c3450b17ba5aa5032a7b6b [1/1] drm/i915/display/psr: Disable DC3CO when the PSR2 is used :::::: branch date: 3 days ago :::::: commit date: 3 days ago config: x86_64-randconfig-m001-20210405 (attached as .config) compiler: gcc-9 (Debian 9.3.0-22) 9.3.0 If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot <[email protected]> Reported-by: Dan Carpenter <[email protected]> New smatch warnings: drivers/gpu/drm/i915/display/intel_psr.c:668 tgl_dc3co_exitline_compute_config() warn: ignoring unreachable code. Old smatch warnings: drivers/gpu/drm/i915/display/intel_psr.c:1219 intel_psr2_program_plane_sel_fetch() error: we previously assumed 'plane_state' could be null (see line 1211) vim +668 drivers/gpu/drm/i915/display/intel_psr.c 1c4d821db91936 Anshuman Gupta 2019-10-03 647 c5c772cf8d7cb6 José Roberto de Souza 2020-01-22 648 static void c5c772cf8d7cb6 José Roberto de Souza 2020-01-22 649 tgl_dc3co_exitline_compute_config(struct intel_dp *intel_dp, c5c772cf8d7cb6 José Roberto de Souza 2020-01-22 650 struct intel_crtc_state *crtc_state) c5c772cf8d7cb6 José Roberto de Souza 2020-01-22 651 { c5c772cf8d7cb6 José Roberto de Souza 2020-01-22 652 const u32 crtc_vdisplay = crtc_state->uapi.adjusted_mode.crtc_vdisplay; c5c772cf8d7cb6 José Roberto de Souza 2020-01-22 653 struct intel_digital_port *dig_port = dp_to_dig_port(intel_dp); c5c772cf8d7cb6 José Roberto de Souza 2020-01-22 654 struct drm_i915_private *dev_priv = dp_to_i915(intel_dp); c5c772cf8d7cb6 José Roberto de Souza 2020-01-22 655 u32 exit_scanlines; c5c772cf8d7cb6 José Roberto de Souza 2020-01-22 656 2d667442dbe70e Gwan-gyeong Mun 2021-04-01 657 /* 2d667442dbe70e Gwan-gyeong Mun 2021-04-01 658 * FIXME: Due to the changed sequence of activating/deactivating DC3CO, 2d667442dbe70e Gwan-gyeong Mun 2021-04-01 659 * disable DC3CO until the changed dc3co activating/deactivating sequence 2d667442dbe70e Gwan-gyeong Mun 2021-04-01 660 * is applied. B.Specs:49196 2d667442dbe70e Gwan-gyeong Mun 2021-04-01 661 */ 2d667442dbe70e Gwan-gyeong Mun 2021-04-01 662 return; 2d667442dbe70e Gwan-gyeong Mun 2021-04-01 663 62c211bb9e1bee Gwan-gyeong Mun 2021-02-22 664 /* 62c211bb9e1bee Gwan-gyeong Mun 2021-02-22 665 * DMC's DC3CO exit mechanism has an issue with Selective Fecth 62c211bb9e1bee Gwan-gyeong Mun 2021-02-22 666 * TODO: when the issue is addressed, this restriction should be removed. 62c211bb9e1bee Gwan-gyeong Mun 2021-02-22 667 */ 62c211bb9e1bee Gwan-gyeong Mun 2021-02-22 @668 if (crtc_state->enable_psr2_sel_fetch) 62c211bb9e1bee Gwan-gyeong Mun 2021-02-22 669 return; 62c211bb9e1bee Gwan-gyeong Mun 2021-02-22 670 c5c772cf8d7cb6 José Roberto de Souza 2020-01-22 671 if (!(dev_priv->csr.allowed_dc_mask & DC_STATE_EN_DC3CO)) c5c772cf8d7cb6 José Roberto de Souza 2020-01-22 672 return; c5c772cf8d7cb6 José Roberto de Souza 2020-01-22 673 c5c772cf8d7cb6 José Roberto de Souza 2020-01-22 674 /* B.Specs:49196 DC3CO only works with pipeA and DDIA.*/ c5c772cf8d7cb6 José Roberto de Souza 2020-01-22 675 if (to_intel_crtc(crtc_state->uapi.crtc)->pipe != PIPE_A || c5c772cf8d7cb6 José Roberto de Souza 2020-01-22 676 dig_port->base.port != PORT_A) c5c772cf8d7cb6 José Roberto de Souza 2020-01-22 677 return; c5c772cf8d7cb6 José Roberto de Souza 2020-01-22 678 c5c772cf8d7cb6 José Roberto de Souza 2020-01-22 679 /* c5c772cf8d7cb6 José Roberto de Souza 2020-01-22 680 * DC3CO Exit time 200us B.Spec 49196 c5c772cf8d7cb6 José Roberto de Souza 2020-01-22 681 * PSR2 transcoder Early Exit scanlines = ROUNDUP(200 / line time) + 1 c5c772cf8d7cb6 José Roberto de Souza 2020-01-22 682 */ c5c772cf8d7cb6 José Roberto de Souza 2020-01-22 683 exit_scanlines = c5c772cf8d7cb6 José Roberto de Souza 2020-01-22 684 intel_usecs_to_scanlines(&crtc_state->uapi.adjusted_mode, 200) + 1; c5c772cf8d7cb6 José Roberto de Souza 2020-01-22 685 16c56083c0cb60 Pankaj Bharadiya 2020-01-28 686 if (drm_WARN_ON(&dev_priv->drm, exit_scanlines > crtc_vdisplay)) c5c772cf8d7cb6 José Roberto de Souza 2020-01-22 687 return; c5c772cf8d7cb6 José Roberto de Souza 2020-01-22 688 c5c772cf8d7cb6 José Roberto de Souza 2020-01-22 689 crtc_state->dc3co_exitline = crtc_vdisplay - exit_scanlines; c5c772cf8d7cb6 José Roberto de Souza 2020-01-22 690 } c5c772cf8d7cb6 José Roberto de Souza 2020-01-22 691 :::::: The code at line 668 was first introduced by commit :::::: 62c211bb9e1bee0083d8061ce0012f538ac754c3 drm/i915/display: Do not allow DC3CO if PSR SF is enabled :::::: TO: Gwan-gyeong Mun <[email protected]> :::::: CC: José Roberto de Souza <[email protected]> --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/[email protected]
.config.gz
Description: application/gzip
_______________________________________________ kbuild mailing list -- [email protected] To unsubscribe send an email to [email protected]
