CC: [email protected] CC: [email protected] TO: AngeloGioacchino Del Regno <[email protected]> CC: Mark Brown <[email protected]> CC: Andy Gross <[email protected]> CC: Bjorn Andersson <[email protected]> CC: Liam Girdwood <[email protected]> CC: [email protected] CC: [email protected]
From: kernel test robot <[email protected]> drivers/regulator/qcom-labibb-regulator.c:364:8-33: ERROR: Threaded IRQ with no primary handler requested without IRQF_ONESHOT Since commit 1c6c69525b40 ("genirq: Reject bogus threaded irq requests") threaded IRQs without a primary handler need to be requested with IRQF_ONESHOT, otherwise the request will fail. So pass the IRQF_ONESHOT flag in this case. Generated by: scripts/coccinelle/misc/irqf_oneshot.cocci Fixes: 390af53e0411 ("regulator: qcom-labibb: Implement short-circuit and over-current IRQs") CC: AngeloGioacchino Del Regno <[email protected]> Reported-by: kernel test robot <[email protected]> Signed-off-by: kernel test robot <[email protected]> --- tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master head: 0a50438c84363bd37fe18fe432888ae9a074dcab commit: 390af53e04114f790d60b63802a4de9d815ade03 regulator: qcom-labibb: Implement short-circuit and over-current IRQs :::::: branch date: 18 hours ago :::::: commit date: 3 months ago Please take the patch only if it's a positive warning. Thanks! qcom-labibb-regulator.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) --- a/drivers/regulator/qcom-labibb-regulator.c +++ b/drivers/regulator/qcom-labibb-regulator.c @@ -362,7 +362,8 @@ static int qcom_labibb_set_ocp(struct re return ret; return devm_request_threaded_irq(vreg->dev, vreg->ocp_irq, NULL, - qcom_labibb_ocp_isr, irq_flags, + qcom_labibb_ocp_isr, + irq_flags | IRQF_ONESHOT, ocp_irq_name, vreg); } _______________________________________________ kbuild mailing list -- [email protected] To unsubscribe send an email to [email protected]
