CC: [email protected] In-Reply-To: <[email protected]> References: <[email protected]> TO: Marcelo Tosatti <[email protected]> TO: Thomas Gleixner <[email protected]> CC: [email protected] CC: Frederic Weisbecker <[email protected]> CC: Peter Xu <[email protected]> CC: Nitesh Narayan Lal <[email protected]> CC: Alex Belits <[email protected]>
Hi Marcelo, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on tip/timers/core] [also build test WARNING on linux/master linus/master v5.12-rc6 next-20210407] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/0day-ci/linux/commits/Marcelo-Tosatti/hrtimer-avoid-retrigger_next_event-IPI/20210407-233005 base: https://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git d4c7c28806616809e3baa0b7cd8c665516b2726d :::::: branch date: 3 hours ago :::::: commit date: 3 hours ago config: i386-randconfig-s001-20210407 (attached as .config) compiler: gcc-9 (Debian 9.3.0-22) 9.3.0 reproduce: # apt-get install sparse # sparse version: v0.6.3-279-g6d5d9b42-dirty # https://github.com/0day-ci/linux/commit/defd4db9d63d1f16e3e21862bd9c9105a9f6a7e9 git remote add linux-review https://github.com/0day-ci/linux git fetch --no-tags linux-review Marcelo-Tosatti/hrtimer-avoid-retrigger_next_event-IPI/20210407-233005 git checkout defd4db9d63d1f16e3e21862bd9c9105a9f6a7e9 # save the attached .config to linux build tree make W=1 C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' ARCH=i386 If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot <[email protected]> sparse warnings: (new ones prefixed by >>) >> kernel/time/hrtimer.c:944:1: sparse: sparse: unused label 'set_timerfd' vim +/set_timerfd +944 kernel/time/hrtimer.c defd4db9d63d1f kernel/time/hrtimer.c Marcelo Tosatti 2021-04-07 895 b12a03ce4880bd kernel/hrtimer.c Thomas Gleixner 2011-05-02 896 /* b12a03ce4880bd kernel/hrtimer.c Thomas Gleixner 2011-05-02 897 * Clock realtime was set b12a03ce4880bd kernel/hrtimer.c Thomas Gleixner 2011-05-02 898 * b12a03ce4880bd kernel/hrtimer.c Thomas Gleixner 2011-05-02 899 * Change the offset of the realtime clock vs. the monotonic b12a03ce4880bd kernel/hrtimer.c Thomas Gleixner 2011-05-02 900 * clock. b12a03ce4880bd kernel/hrtimer.c Thomas Gleixner 2011-05-02 901 * b12a03ce4880bd kernel/hrtimer.c Thomas Gleixner 2011-05-02 902 * We might have to reprogram the high resolution timer interrupt. On b12a03ce4880bd kernel/hrtimer.c Thomas Gleixner 2011-05-02 903 * SMP we call the architecture specific code to retrigger _all_ high b12a03ce4880bd kernel/hrtimer.c Thomas Gleixner 2011-05-02 904 * resolution timer interrupts. On UP we just disable interrupts and b12a03ce4880bd kernel/hrtimer.c Thomas Gleixner 2011-05-02 905 * call the high resolution interrupt code. b12a03ce4880bd kernel/hrtimer.c Thomas Gleixner 2011-05-02 906 */ b12a03ce4880bd kernel/hrtimer.c Thomas Gleixner 2011-05-02 907 void clock_was_set(void) b12a03ce4880bd kernel/hrtimer.c Thomas Gleixner 2011-05-02 908 { 90ff1f30c0f401 kernel/hrtimer.c Thomas Gleixner 2011-05-25 909 #ifdef CONFIG_HIGH_RES_TIMERS defd4db9d63d1f kernel/time/hrtimer.c Marcelo Tosatti 2021-04-07 910 cpumask_var_t mask; defd4db9d63d1f kernel/time/hrtimer.c Marcelo Tosatti 2021-04-07 911 int cpu; defd4db9d63d1f kernel/time/hrtimer.c Marcelo Tosatti 2021-04-07 912 defd4db9d63d1f kernel/time/hrtimer.c Marcelo Tosatti 2021-04-07 913 if (!tick_nohz_full_enabled()) { b12a03ce4880bd kernel/hrtimer.c Thomas Gleixner 2011-05-02 914 /* Retrigger the CPU local events everywhere */ b12a03ce4880bd kernel/hrtimer.c Thomas Gleixner 2011-05-02 915 on_each_cpu(retrigger_next_event, NULL, 1); defd4db9d63d1f kernel/time/hrtimer.c Marcelo Tosatti 2021-04-07 916 goto set_timerfd; defd4db9d63d1f kernel/time/hrtimer.c Marcelo Tosatti 2021-04-07 917 } defd4db9d63d1f kernel/time/hrtimer.c Marcelo Tosatti 2021-04-07 918 defd4db9d63d1f kernel/time/hrtimer.c Marcelo Tosatti 2021-04-07 919 if (!zalloc_cpumask_var(&mask, GFP_KERNEL)) { defd4db9d63d1f kernel/time/hrtimer.c Marcelo Tosatti 2021-04-07 920 on_each_cpu(retrigger_next_event, NULL, 1); defd4db9d63d1f kernel/time/hrtimer.c Marcelo Tosatti 2021-04-07 921 goto set_timerfd; defd4db9d63d1f kernel/time/hrtimer.c Marcelo Tosatti 2021-04-07 922 } defd4db9d63d1f kernel/time/hrtimer.c Marcelo Tosatti 2021-04-07 923 defd4db9d63d1f kernel/time/hrtimer.c Marcelo Tosatti 2021-04-07 924 /* Avoid interrupting nohz_full CPUs if possible */ defd4db9d63d1f kernel/time/hrtimer.c Marcelo Tosatti 2021-04-07 925 preempt_disable(); defd4db9d63d1f kernel/time/hrtimer.c Marcelo Tosatti 2021-04-07 926 for_each_online_cpu(cpu) { defd4db9d63d1f kernel/time/hrtimer.c Marcelo Tosatti 2021-04-07 927 if (tick_nohz_full_cpu(cpu)) { defd4db9d63d1f kernel/time/hrtimer.c Marcelo Tosatti 2021-04-07 928 unsigned long flags; defd4db9d63d1f kernel/time/hrtimer.c Marcelo Tosatti 2021-04-07 929 struct hrtimer_cpu_base *cpu_base = &per_cpu(hrtimer_bases, cpu); defd4db9d63d1f kernel/time/hrtimer.c Marcelo Tosatti 2021-04-07 930 defd4db9d63d1f kernel/time/hrtimer.c Marcelo Tosatti 2021-04-07 931 raw_spin_lock_irqsave(&cpu_base->lock, flags); defd4db9d63d1f kernel/time/hrtimer.c Marcelo Tosatti 2021-04-07 932 if (need_reprogram_timer(cpu_base)) defd4db9d63d1f kernel/time/hrtimer.c Marcelo Tosatti 2021-04-07 933 cpumask_set_cpu(cpu, mask); defd4db9d63d1f kernel/time/hrtimer.c Marcelo Tosatti 2021-04-07 934 else defd4db9d63d1f kernel/time/hrtimer.c Marcelo Tosatti 2021-04-07 935 hrtimer_update_base(cpu_base); defd4db9d63d1f kernel/time/hrtimer.c Marcelo Tosatti 2021-04-07 936 raw_spin_unlock_irqrestore(&cpu_base->lock, flags); defd4db9d63d1f kernel/time/hrtimer.c Marcelo Tosatti 2021-04-07 937 } defd4db9d63d1f kernel/time/hrtimer.c Marcelo Tosatti 2021-04-07 938 } defd4db9d63d1f kernel/time/hrtimer.c Marcelo Tosatti 2021-04-07 939 defd4db9d63d1f kernel/time/hrtimer.c Marcelo Tosatti 2021-04-07 940 smp_call_function_many(mask, retrigger_next_event, NULL, 1); defd4db9d63d1f kernel/time/hrtimer.c Marcelo Tosatti 2021-04-07 941 preempt_enable(); defd4db9d63d1f kernel/time/hrtimer.c Marcelo Tosatti 2021-04-07 942 free_cpumask_var(mask); 9ec2690758a546 kernel/hrtimer.c Thomas Gleixner 2011-05-20 943 #endif defd4db9d63d1f kernel/time/hrtimer.c Marcelo Tosatti 2021-04-07 @944 set_timerfd: 9ec2690758a546 kernel/hrtimer.c Thomas Gleixner 2011-05-20 945 timerfd_clock_was_set(); b12a03ce4880bd kernel/hrtimer.c Thomas Gleixner 2011-05-02 946 } b12a03ce4880bd kernel/hrtimer.c Thomas Gleixner 2011-05-02 947 --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/[email protected]
.config.gz
Description: application/gzip
_______________________________________________ kbuild mailing list -- [email protected] To unsubscribe send an email to [email protected]
