CC: [email protected] In-Reply-To: <[email protected]> References: <[email protected]> TO: Dexuan Cui <[email protected]> TO: [email protected] TO: [email protected] TO: [email protected] TO: [email protected] TO: [email protected] TO: [email protected] TO: [email protected] TO: [email protected] TO: [email protected] TO: [email protected]
Hi Dexuan, I love your patch! Perhaps something to improve: [auto build test WARNING on net-next/master] url: https://github.com/0day-ci/linux/commits/Dexuan-Cui/net-mana-Add-a-driver-for-Microsoft-Azure-Network-Adapter-MANA/20210408-171836 base: https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git 3cd52c1e32fe7dfee09815ced702db9ee9f84ec9 :::::: branch date: 3 hours ago :::::: commit date: 3 hours ago config: x86_64-randconfig-c022-20210408 (attached as .config) compiler: gcc-9 (Debian 9.3.0-22) 9.3.0 If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot <[email protected]> Reported-by: Julia Lawall <[email protected]> cocci warnings: (new ones prefixed by >>) >> drivers/net/ethernet/microsoft/mana/gdma_main.c:1469:13-16: ERROR: gc is >> NULL but dereferenced. vim +1469 drivers/net/ethernet/microsoft/mana/gdma_main.c 14f90d1ae32a99 Dexuan Cui 2021-04-08 1386 14f90d1ae32a99 Dexuan Cui 2021-04-08 1387 static int gdma_probe(struct pci_dev *pdev, const struct pci_device_id *ent) 14f90d1ae32a99 Dexuan Cui 2021-04-08 1388 { 14f90d1ae32a99 Dexuan Cui 2021-04-08 1389 struct gdma_context *gc; 14f90d1ae32a99 Dexuan Cui 2021-04-08 1390 void __iomem *bar0_va; 14f90d1ae32a99 Dexuan Cui 2021-04-08 1391 int bar = 0; 14f90d1ae32a99 Dexuan Cui 2021-04-08 1392 int err; 14f90d1ae32a99 Dexuan Cui 2021-04-08 1393 14f90d1ae32a99 Dexuan Cui 2021-04-08 1394 err = pci_enable_device(pdev); 14f90d1ae32a99 Dexuan Cui 2021-04-08 1395 if (err) 14f90d1ae32a99 Dexuan Cui 2021-04-08 1396 return -ENXIO; 14f90d1ae32a99 Dexuan Cui 2021-04-08 1397 14f90d1ae32a99 Dexuan Cui 2021-04-08 1398 pci_set_master(pdev); 14f90d1ae32a99 Dexuan Cui 2021-04-08 1399 14f90d1ae32a99 Dexuan Cui 2021-04-08 1400 err = pci_request_regions(pdev, "gdma"); 14f90d1ae32a99 Dexuan Cui 2021-04-08 1401 if (err) 14f90d1ae32a99 Dexuan Cui 2021-04-08 1402 goto disable_dev; 14f90d1ae32a99 Dexuan Cui 2021-04-08 1403 14f90d1ae32a99 Dexuan Cui 2021-04-08 1404 err = dma_set_mask_and_coherent(&pdev->dev, DMA_BIT_MASK(64)); 14f90d1ae32a99 Dexuan Cui 2021-04-08 1405 if (err) 14f90d1ae32a99 Dexuan Cui 2021-04-08 1406 goto release_region; 14f90d1ae32a99 Dexuan Cui 2021-04-08 1407 14f90d1ae32a99 Dexuan Cui 2021-04-08 1408 err = -ENOMEM; 14f90d1ae32a99 Dexuan Cui 2021-04-08 1409 gc = vzalloc(sizeof(*gc)); 14f90d1ae32a99 Dexuan Cui 2021-04-08 1410 if (!gc) 14f90d1ae32a99 Dexuan Cui 2021-04-08 1411 goto release_region; 14f90d1ae32a99 Dexuan Cui 2021-04-08 1412 14f90d1ae32a99 Dexuan Cui 2021-04-08 1413 bar0_va = pci_iomap(pdev, bar, 0); 14f90d1ae32a99 Dexuan Cui 2021-04-08 1414 if (!bar0_va) 14f90d1ae32a99 Dexuan Cui 2021-04-08 1415 goto free_gc; 14f90d1ae32a99 Dexuan Cui 2021-04-08 1416 14f90d1ae32a99 Dexuan Cui 2021-04-08 1417 gc->bar0_va = bar0_va; 14f90d1ae32a99 Dexuan Cui 2021-04-08 1418 gc->dev = &pdev->dev; 14f90d1ae32a99 Dexuan Cui 2021-04-08 1419 14f90d1ae32a99 Dexuan Cui 2021-04-08 1420 pci_set_drvdata(pdev, gc); 14f90d1ae32a99 Dexuan Cui 2021-04-08 1421 14f90d1ae32a99 Dexuan Cui 2021-04-08 1422 gdma_init_registers(pdev); 14f90d1ae32a99 Dexuan Cui 2021-04-08 1423 14f90d1ae32a99 Dexuan Cui 2021-04-08 1424 shm_channel_init(&gc->shm_channel, gc->dev, gc->shm_base); 14f90d1ae32a99 Dexuan Cui 2021-04-08 1425 14f90d1ae32a99 Dexuan Cui 2021-04-08 1426 err = gdma_setup_irqs(pdev); 14f90d1ae32a99 Dexuan Cui 2021-04-08 1427 if (err) 14f90d1ae32a99 Dexuan Cui 2021-04-08 1428 goto unmap_bar; 14f90d1ae32a99 Dexuan Cui 2021-04-08 1429 14f90d1ae32a99 Dexuan Cui 2021-04-08 1430 mutex_init(&gc->eq_test_event_mutex); 14f90d1ae32a99 Dexuan Cui 2021-04-08 1431 14f90d1ae32a99 Dexuan Cui 2021-04-08 1432 err = hwc_create_channel(gc); 14f90d1ae32a99 Dexuan Cui 2021-04-08 1433 if (err) 14f90d1ae32a99 Dexuan Cui 2021-04-08 1434 goto remove_irq; 14f90d1ae32a99 Dexuan Cui 2021-04-08 1435 14f90d1ae32a99 Dexuan Cui 2021-04-08 1436 err = gdma_verify_vf_version(pdev); 14f90d1ae32a99 Dexuan Cui 2021-04-08 1437 if (err) 14f90d1ae32a99 Dexuan Cui 2021-04-08 1438 goto remove_irq; 14f90d1ae32a99 Dexuan Cui 2021-04-08 1439 14f90d1ae32a99 Dexuan Cui 2021-04-08 1440 err = gdma_query_max_resources(pdev); 14f90d1ae32a99 Dexuan Cui 2021-04-08 1441 if (err) 14f90d1ae32a99 Dexuan Cui 2021-04-08 1442 goto remove_irq; 14f90d1ae32a99 Dexuan Cui 2021-04-08 1443 14f90d1ae32a99 Dexuan Cui 2021-04-08 1444 err = gdma_detect_devices(pdev); 14f90d1ae32a99 Dexuan Cui 2021-04-08 1445 if (err) 14f90d1ae32a99 Dexuan Cui 2021-04-08 1446 goto remove_irq; 14f90d1ae32a99 Dexuan Cui 2021-04-08 1447 14f90d1ae32a99 Dexuan Cui 2021-04-08 1448 err = ana_probe(&gc->ana); 14f90d1ae32a99 Dexuan Cui 2021-04-08 1449 if (err) 14f90d1ae32a99 Dexuan Cui 2021-04-08 1450 goto clean_up_gdma; 14f90d1ae32a99 Dexuan Cui 2021-04-08 1451 14f90d1ae32a99 Dexuan Cui 2021-04-08 1452 return 0; 14f90d1ae32a99 Dexuan Cui 2021-04-08 1453 14f90d1ae32a99 Dexuan Cui 2021-04-08 1454 clean_up_gdma: 14f90d1ae32a99 Dexuan Cui 2021-04-08 1455 hwc_destroy_channel(gc); 14f90d1ae32a99 Dexuan Cui 2021-04-08 1456 vfree(gc->cq_table); 14f90d1ae32a99 Dexuan Cui 2021-04-08 1457 gc->cq_table = NULL; 14f90d1ae32a99 Dexuan Cui 2021-04-08 1458 remove_irq: 14f90d1ae32a99 Dexuan Cui 2021-04-08 1459 gdma_remove_irqs(pdev); 14f90d1ae32a99 Dexuan Cui 2021-04-08 1460 unmap_bar: 14f90d1ae32a99 Dexuan Cui 2021-04-08 1461 pci_iounmap(pdev, bar0_va); 14f90d1ae32a99 Dexuan Cui 2021-04-08 1462 free_gc: 14f90d1ae32a99 Dexuan Cui 2021-04-08 1463 vfree(gc); 14f90d1ae32a99 Dexuan Cui 2021-04-08 1464 release_region: 14f90d1ae32a99 Dexuan Cui 2021-04-08 1465 pci_release_regions(pdev); 14f90d1ae32a99 Dexuan Cui 2021-04-08 1466 disable_dev: 14f90d1ae32a99 Dexuan Cui 2021-04-08 1467 pci_clear_master(pdev); 14f90d1ae32a99 Dexuan Cui 2021-04-08 1468 pci_disable_device(pdev); 14f90d1ae32a99 Dexuan Cui 2021-04-08 @1469 dev_err(gc->dev, "gdma probe failed: err = %d\n", err); 14f90d1ae32a99 Dexuan Cui 2021-04-08 1470 return err; 14f90d1ae32a99 Dexuan Cui 2021-04-08 1471 } 14f90d1ae32a99 Dexuan Cui 2021-04-08 1472 --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/[email protected]
.config.gz
Description: application/gzip
_______________________________________________ kbuild mailing list -- [email protected] To unsubscribe send an email to [email protected]
