CC: [email protected]
CC: [email protected]
TO: Nicholas Piggin <[email protected]>
CC: Michael Ellerman <[email protected]>

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git 
master
head:   8e2e0104ef78d49a51db9acfd24eaf6d52dc779e
commit: a008f8f9fd67ffb13d906ef4ea6235a3d62dfdb6 powerpc/64s/hash: improve 
context tracking of hash faults
date:   9 weeks ago
:::::: branch date: 4 hours ago
:::::: commit date: 9 weeks ago
config: powerpc-randconfig-m031-20210414 (attached as .config)
compiler: powerpc-linux-gcc (GCC) 9.3.0

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <[email protected]>
Reported-by: Dan Carpenter <[email protected]>

smatch warnings:
arch/powerpc/mm/fault.c:538 ___do_page_fault() warn: inconsistent returns 
'&mm->mmap_lock'.

vim +538 arch/powerpc/mm/fault.c

fe4a6856cb4f43 Aneesh Kumar K.V       2020-05-05  500  
bd0d63f8095ae6 Benjamin Herrenschmidt 2017-07-19  501   if 
(unlikely(access_error(is_write, is_exec, vma)))
ecb101aed86156 John Sperbeck          2017-12-31  502           return 
bad_access(regs, address);
14cf11af6cf608 Paul Mackerras         2005-09-26  503  
14cf11af6cf608 Paul Mackerras         2005-09-26  504   /*
14cf11af6cf608 Paul Mackerras         2005-09-26  505    * If for any reason at 
all we couldn't handle the fault,
14cf11af6cf608 Paul Mackerras         2005-09-26  506    * make sure we exit 
gracefully rather than endlessly redo
14cf11af6cf608 Paul Mackerras         2005-09-26  507    * the fault.
14cf11af6cf608 Paul Mackerras         2005-09-26  508    */
428fdc094492e7 Peter Xu               2020-08-11  509   fault = 
handle_mm_fault(vma, address, flags, regs);
e6c2a4797e101a Ram Pai                2018-01-18  510  
f43bb27ebf27ee Benjamin Herrenschmidt 2017-07-19  511   major |= fault & 
VM_FAULT_MAJOR;
14c02e419a395c Laurent Dufour         2017-02-14  512  
c9a0dad1620141 Peter Xu               2020-04-01  513   if 
(fault_signal_pending(fault, regs))
c9a0dad1620141 Peter Xu               2020-04-01  514           return 
user_mode(regs) ? 0 : SIGBUS;
c9a0dad1620141 Peter Xu               2020-04-01  515  
14c02e419a395c Laurent Dufour         2017-02-14  516   /*
c1e8d7c6a7a682 Michel Lespinasse      2020-06-08  517    * Handle the retry 
right now, the mmap_lock has been released in that
14c02e419a395c Laurent Dufour         2017-02-14  518    * case.
14c02e419a395c Laurent Dufour         2017-02-14  519    */
14c02e419a395c Laurent Dufour         2017-02-14  520   if (unlikely(fault & 
VM_FAULT_RETRY)) {
14c02e419a395c Laurent Dufour         2017-02-14  521           if (flags & 
FAULT_FLAG_ALLOW_RETRY) {
14c02e419a395c Laurent Dufour         2017-02-14  522                   flags 
|= FAULT_FLAG_TRIED;
14c02e419a395c Laurent Dufour         2017-02-14  523                   goto 
retry;
14c02e419a395c Laurent Dufour         2017-02-14  524           }
14cf11af6cf608 Paul Mackerras         2005-09-26  525   }
9be72573a80648 Benjamin Herrenschmidt 2012-03-01  526  
d8ed45c5dcd455 Michel Lespinasse      2020-06-08  527   
mmap_read_unlock(current->mm);
b5c8f0fd595d25 Benjamin Herrenschmidt 2017-07-19  528  
b5c8f0fd595d25 Benjamin Herrenschmidt 2017-07-19  529   if (unlikely(fault & 
VM_FAULT_ERROR))
b5c8f0fd595d25 Benjamin Herrenschmidt 2017-07-19  530           return 
mm_fault_error(regs, address, fault);
b5c8f0fd595d25 Benjamin Herrenschmidt 2017-07-19  531  
9be72573a80648 Benjamin Herrenschmidt 2012-03-01  532   /*
14c02e419a395c Laurent Dufour         2017-02-14  533    * Major/minor page 
fault accounting.
9be72573a80648 Benjamin Herrenschmidt 2012-03-01  534    */
428fdc094492e7 Peter Xu               2020-08-11  535   if (major)
3da026480a7536 Benjamin Herrenschmidt 2017-07-19  536           
cmo_account_page_fault();
428fdc094492e7 Peter Xu               2020-08-11  537  
65d47fd4a37cbd Benjamin Herrenschmidt 2017-07-19 @538   return 0;
14cf11af6cf608 Paul Mackerras         2005-09-26  539  }
a008f8f9fd67ff Nicholas Piggin        2021-01-30  540  
NOKPROBE_SYMBOL(___do_page_fault);
7afad422ac6106 Benjamin Herrenschmidt 2017-07-19  541  

:::::: The code at line 538 was first introduced by commit
:::::: 65d47fd4a37cbd60d0737cdae09edf1d208364d7 powerpc/mm: Simplify returns 
from __do_page_fault

:::::: TO: Benjamin Herrenschmidt <[email protected]>
:::::: CC: Michael Ellerman <[email protected]>

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/[email protected]

Attachment: .config.gz
Description: application/gzip

_______________________________________________
kbuild mailing list -- [email protected]
To unsubscribe send an email to [email protected]

Reply via email to