CC: [email protected]
In-Reply-To: <[email protected]>
References: <[email protected]>
TO: Gao Xiang <[email protected]>

Hi Gao,

[FYI, it's a private test report for your RFC patch.]
[auto build test WARNING on xfs-linux/for-next]
[also build test WARNING on next-20210415]
[cannot apply to xiang-erofs/dev-test v5.12-rc7]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    
https://github.com/0day-ci/linux/commits/Gao-Xiang/xfs-support-shrinking-empty-AGs/20210415-035456
base:   https://git.kernel.org/pub/scm/fs/xfs/xfs-linux.git for-next
:::::: branch date: 19 hours ago
:::::: commit date: 19 hours ago
config: x86_64-randconfig-m001-20210415 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-22) 9.3.0

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <[email protected]>
Reported-by: Dan Carpenter <[email protected]>

smatch warnings:
fs/xfs/xfs_fsops.c:114 xfs_shrinkfs_deactivate_ags() error: uninitialized 
symbol 'error'.

vim +/error +114 fs/xfs/xfs_fsops.c

c789c83c7ef8f98 Gao Xiang 2021-03-23   83  
cc44e74a238999c Gao Xiang 2021-04-15   84  static int
cc44e74a238999c Gao Xiang 2021-04-15   85  xfs_shrinkfs_deactivate_ags(
cc44e74a238999c Gao Xiang 2021-04-15   86       struct xfs_mount        *mp,
cc44e74a238999c Gao Xiang 2021-04-15   87       xfs_agnumber_t          
oagcount,
cc44e74a238999c Gao Xiang 2021-04-15   88       xfs_agnumber_t          
nagcount)
cc44e74a238999c Gao Xiang 2021-04-15   89  {
cc44e74a238999c Gao Xiang 2021-04-15   90       xfs_agnumber_t          agno;
cc44e74a238999c Gao Xiang 2021-04-15   91       int                     error;
cc44e74a238999c Gao Xiang 2021-04-15   92  
cc44e74a238999c Gao Xiang 2021-04-15   93       /* confirm AGs pending for 
shrinking are all inactive */
cc44e74a238999c Gao Xiang 2021-04-15   94       for (agno = nagcount; agno < 
oagcount; ++agno) {
cc44e74a238999c Gao Xiang 2021-04-15   95               struct xfs_buf *agfbp, 
*agibp;
cc44e74a238999c Gao Xiang 2021-04-15   96               struct xfs_perag *pag = 
xfs_perag_get(mp, agno);
cc44e74a238999c Gao Xiang 2021-04-15   97  
cc44e74a238999c Gao Xiang 2021-04-15   98               
down_write(&pag->pag_inactive_rwsem);
cc44e74a238999c Gao Xiang 2021-04-15   99               /* need to lock agi, 
agf buffers here to close all races */
cc44e74a238999c Gao Xiang 2021-04-15  100               error = 
xfs_read_agi(mp, NULL, agno, &agibp);
cc44e74a238999c Gao Xiang 2021-04-15  101               if (!error) {
cc44e74a238999c Gao Xiang 2021-04-15  102                       error = 
xfs_alloc_read_agf(mp, NULL, agno, 0, &agfbp);
cc44e74a238999c Gao Xiang 2021-04-15  103                       if (!error) {
cc44e74a238999c Gao Xiang 2021-04-15  104                               
pag->pag_inactive = true;
cc44e74a238999c Gao Xiang 2021-04-15  105                               
xfs_buf_relse(agfbp);
cc44e74a238999c Gao Xiang 2021-04-15  106                       }
cc44e74a238999c Gao Xiang 2021-04-15  107                       
xfs_buf_relse(agibp);
cc44e74a238999c Gao Xiang 2021-04-15  108               }
cc44e74a238999c Gao Xiang 2021-04-15  109               
up_write(&pag->pag_inactive_rwsem);
cc44e74a238999c Gao Xiang 2021-04-15  110               xfs_perag_put(pag);
cc44e74a238999c Gao Xiang 2021-04-15  111               if (error)
cc44e74a238999c Gao Xiang 2021-04-15  112                       break;
cc44e74a238999c Gao Xiang 2021-04-15  113       }
cc44e74a238999c Gao Xiang 2021-04-15 @114       return error;
cc44e74a238999c Gao Xiang 2021-04-15  115  }
cc44e74a238999c Gao Xiang 2021-04-15  116  

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/[email protected]

Attachment: .config.gz
Description: application/gzip

_______________________________________________
kbuild mailing list -- [email protected]
To unsubscribe send an email to [email protected]

Reply via email to