CC: [email protected]
CC: [email protected]
TO: Jaegeuk Kim <[email protected]>
CC: "Martin K. Petersen" <[email protected]>

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git 
master
head:   194cf4825638256e9afe1d360831aa5379b3517a
commit: 4f3e900b628226011a5f71c19e53b175c014eb58 scsi: ufs: Clear UAC for FFU 
and RPMB LUNs
date:   5 months ago
:::::: branch date: 7 hours ago
:::::: commit date: 5 months ago
config: m68k-randconfig-m031-20210418 (attached as .config)
compiler: m68k-linux-gcc (GCC) 9.3.0

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <[email protected]>
Reported-by: Dan Carpenter <[email protected]>

smatch warnings:
drivers/scsi/ufs/ufshcd.c:7653 ufshcd_clear_ua_wlun() error: uninitialized 
symbol 'sdp'.

vim +/sdp +7653 drivers/scsi/ufs/ufshcd.c

4f3e900b628226 Jaegeuk Kim 2020-11-17  7639  
4f3e900b628226 Jaegeuk Kim 2020-11-17  7640  static int 
ufshcd_clear_ua_wlun(struct ufs_hba *hba, u8 wlun)
4f3e900b628226 Jaegeuk Kim 2020-11-17  7641  {
4f3e900b628226 Jaegeuk Kim 2020-11-17  7642     struct scsi_device *sdp;
4f3e900b628226 Jaegeuk Kim 2020-11-17  7643     unsigned long flags;
4f3e900b628226 Jaegeuk Kim 2020-11-17  7644     int ret = 0;
4f3e900b628226 Jaegeuk Kim 2020-11-17  7645  
4f3e900b628226 Jaegeuk Kim 2020-11-17  7646     
spin_lock_irqsave(hba->host->host_lock, flags);
4f3e900b628226 Jaegeuk Kim 2020-11-17  7647     if (wlun == 
UFS_UPIU_UFS_DEVICE_WLUN)
4f3e900b628226 Jaegeuk Kim 2020-11-17  7648             sdp = 
hba->sdev_ufs_device;
4f3e900b628226 Jaegeuk Kim 2020-11-17  7649     else if (wlun == 
UFS_UPIU_RPMB_WLUN)
4f3e900b628226 Jaegeuk Kim 2020-11-17  7650             sdp = hba->sdev_rpmb;
4f3e900b628226 Jaegeuk Kim 2020-11-17  7651     else
4f3e900b628226 Jaegeuk Kim 2020-11-17  7652             BUG_ON(1);
4f3e900b628226 Jaegeuk Kim 2020-11-17 @7653     if (sdp) {
4f3e900b628226 Jaegeuk Kim 2020-11-17  7654             ret = 
scsi_device_get(sdp);
4f3e900b628226 Jaegeuk Kim 2020-11-17  7655             if (!ret && 
!scsi_device_online(sdp)) {
4f3e900b628226 Jaegeuk Kim 2020-11-17  7656                     ret = -ENODEV;
4f3e900b628226 Jaegeuk Kim 2020-11-17  7657                     
scsi_device_put(sdp);
4f3e900b628226 Jaegeuk Kim 2020-11-17  7658             }
4f3e900b628226 Jaegeuk Kim 2020-11-17  7659     } else {
4f3e900b628226 Jaegeuk Kim 2020-11-17  7660             ret = -ENODEV;
4f3e900b628226 Jaegeuk Kim 2020-11-17  7661     }
4f3e900b628226 Jaegeuk Kim 2020-11-17  7662     
spin_unlock_irqrestore(hba->host->host_lock, flags);
4f3e900b628226 Jaegeuk Kim 2020-11-17  7663     if (ret)
4f3e900b628226 Jaegeuk Kim 2020-11-17  7664             goto out_err;
4f3e900b628226 Jaegeuk Kim 2020-11-17  7665  
4f3e900b628226 Jaegeuk Kim 2020-11-17  7666     ret = 
ufshcd_send_request_sense(hba, sdp);
4f3e900b628226 Jaegeuk Kim 2020-11-17  7667     scsi_device_put(sdp);
4f3e900b628226 Jaegeuk Kim 2020-11-17  7668  out_err:
4f3e900b628226 Jaegeuk Kim 2020-11-17  7669     if (ret)
4f3e900b628226 Jaegeuk Kim 2020-11-17  7670             dev_err(hba->dev, "%s: 
UAC clear LU=%x ret = %d\n",
4f3e900b628226 Jaegeuk Kim 2020-11-17  7671                             
__func__, wlun, ret);
4f3e900b628226 Jaegeuk Kim 2020-11-17  7672     return ret;
4f3e900b628226 Jaegeuk Kim 2020-11-17  7673  }
4f3e900b628226 Jaegeuk Kim 2020-11-17  7674  

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/[email protected]

Attachment: .config.gz
Description: application/gzip

_______________________________________________
kbuild mailing list -- [email protected]
To unsubscribe send an email to [email protected]

Reply via email to