CC: [email protected] In-Reply-To: <[email protected]> References: <[email protected]> TO: Johan Hovold <[email protected]> TO: "Greg Kroah-Hartman" <[email protected]> CC: Jiri Slaby <[email protected]> CC: Maxime Coquelin <[email protected]> CC: Alexandre Torgue <[email protected]> CC: [email protected] CC: Erwan Le Ray <[email protected]> CC: [email protected] CC: [email protected] CC: Johan Hovold <[email protected]>
Hi Johan, I love your patch! Perhaps something to improve: [auto build test WARNING on tty/tty-testing] [also build test WARNING on next-20210420] [cannot apply to stm32/stm32-next usb/usb-testing v5.12-rc8] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/0day-ci/linux/commits/Johan-Hovold/serial-sysrq-cleanup-and-stm32-fixes/20210416-221336 base: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/tty.git tty-testing :::::: branch date: 4 days ago :::::: commit date: 4 days ago config: arm64-randconfig-s032-20210420 (attached as .config) compiler: aarch64-linux-gcc (GCC) 9.3.0 reproduce: wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # apt-get install sparse # sparse version: v0.6.3-341-g8af24329-dirty # https://github.com/0day-ci/linux/commit/4554917dbd6d9c8d915616e748d7d1471d3b1366 git remote add linux-review https://github.com/0day-ci/linux git fetch --no-tags linux-review Johan-Hovold/serial-sysrq-cleanup-and-stm32-fixes/20210416-221336 git checkout 4554917dbd6d9c8d915616e748d7d1471d3b1366 # save the attached .config to linux build tree COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' W=1 ARCH=arm64 If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot <[email protected]> sparse warnings: (new ones prefixed by >>) drivers/tty/serial/stm32-usart.c: note: in included file: drivers/tty/serial/stm32-usart.h:42:25: sparse: sparse: symbol 'stm32f4_info' was not declared. Should it be static? drivers/tty/serial/stm32-usart.h:63:25: sparse: sparse: symbol 'stm32f7_info' was not declared. Should it be static? drivers/tty/serial/stm32-usart.h:85:25: sparse: sparse: symbol 'stm32h7_info' was not declared. Should it be static? >> drivers/tty/serial/stm32-usart.c:1449:9: sparse: sparse: context imbalance >> in 'stm32_usart_console_write' - different lock contexts for basic block vim +/stm32_usart_console_write +1449 drivers/tty/serial/stm32-usart.c 48a6092fb41fab Maxime Coquelin 2015-06-10 1421 56f9a76c27b51b Erwan Le Ray 2021-01-06 1422 static void stm32_usart_console_write(struct console *co, const char *s, 92fc00238675a1 Erwan Le Ray 2021-01-06 1423 unsigned int cnt) 48a6092fb41fab Maxime Coquelin 2015-06-10 1424 { 48a6092fb41fab Maxime Coquelin 2015-06-10 1425 struct uart_port *port = &stm32_ports[co->index].port; ada8618ff3bfe1 Alexandre TORGUE 2016-09-15 1426 struct stm32_port *stm32_port = to_stm32_port(port); d825f0bea20f49 Stephen Boyd 2021-01-22 1427 const struct stm32_usart_offsets *ofs = &stm32_port->info->ofs; d825f0bea20f49 Stephen Boyd 2021-01-22 1428 const struct stm32_usart_config *cfg = &stm32_port->info->cfg; 48a6092fb41fab Maxime Coquelin 2015-06-10 1429 unsigned long flags; 48a6092fb41fab Maxime Coquelin 2015-06-10 1430 u32 old_cr1, new_cr1; 48a6092fb41fab Maxime Coquelin 2015-06-10 1431 int locked = 1; 48a6092fb41fab Maxime Coquelin 2015-06-10 1432 4554917dbd6d9c Johan Hovold 2021-04-16 1433 if (oops_in_progress) 4554917dbd6d9c Johan Hovold 2021-04-16 1434 locked = spin_trylock_irqsave(&port->lock, flags); 48a6092fb41fab Maxime Coquelin 2015-06-10 1435 else 4554917dbd6d9c Johan Hovold 2021-04-16 1436 spin_lock_irqsave(&port->lock, flags); 48a6092fb41fab Maxime Coquelin 2015-06-10 1437 87f1f809c9b909 Alexandre TORGUE 2016-09-15 1438 /* Save and disable interrupts, enable the transmitter */ ada8618ff3bfe1 Alexandre TORGUE 2016-09-15 1439 old_cr1 = readl_relaxed(port->membase + ofs->cr1); 48a6092fb41fab Maxime Coquelin 2015-06-10 1440 new_cr1 = old_cr1 & ~USART_CR1_IE_MASK; 87f1f809c9b909 Alexandre TORGUE 2016-09-15 1441 new_cr1 |= USART_CR1_TE | BIT(cfg->uart_enable_bit); ada8618ff3bfe1 Alexandre TORGUE 2016-09-15 1442 writel_relaxed(new_cr1, port->membase + ofs->cr1); 48a6092fb41fab Maxime Coquelin 2015-06-10 1443 56f9a76c27b51b Erwan Le Ray 2021-01-06 1444 uart_console_write(port, s, cnt, stm32_usart_console_putchar); 48a6092fb41fab Maxime Coquelin 2015-06-10 1445 48a6092fb41fab Maxime Coquelin 2015-06-10 1446 /* Restore interrupt state */ ada8618ff3bfe1 Alexandre TORGUE 2016-09-15 1447 writel_relaxed(old_cr1, port->membase + ofs->cr1); 48a6092fb41fab Maxime Coquelin 2015-06-10 1448 48a6092fb41fab Maxime Coquelin 2015-06-10 @1449 if (locked) 4554917dbd6d9c Johan Hovold 2021-04-16 1450 spin_unlock_irqrestore(&port->lock, flags); 48a6092fb41fab Maxime Coquelin 2015-06-10 1451 } 48a6092fb41fab Maxime Coquelin 2015-06-10 1452 --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/[email protected]
.config.gz
Description: application/gzip
_______________________________________________ kbuild mailing list -- [email protected] To unsubscribe send an email to [email protected]
