CC: [email protected] CC: [email protected] TO: Kees Cook <[email protected]> CC: Chao Yu <[email protected]>, Chao Yu <[email protected]>
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master head: e4adffb8daf476a01e7b4a55f586dc8c26e81392 commit: 3f649ab728cda8038259d8f14492fe400fbab911 treewide: Remove uninitialized_var() usage date: 10 months ago :::::: branch date: 3 hours ago :::::: commit date: 10 months ago config: powerpc64-randconfig-m031-20210504 (attached as .config) compiler: powerpc64-linux-gcc (GCC) 9.3.0 If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot <[email protected]> Reported-by: Dan Carpenter <[email protected]> New smatch warnings: arch/powerpc/kvm/powerpc.c:1158 kvmppc_complete_mmio_load() error: uninitialized symbol 'gpr'. drivers/net/wireless/broadcom/b43/phy_n.c:5734 b43_nphy_rev2_cal_rx_iq() error: uninitialized symbol 'cur_hpf1'. drivers/net/wireless/broadcom/b43/phy_n.c:5744 b43_nphy_rev2_cal_rx_iq() error: uninitialized symbol 'cur_hpf2'. drivers/net/wireless/broadcom/b43/xmit.c:457 b43_generate_txhdr() error: uninitialized symbol 'cts'. drivers/net/wireless/broadcom/b43/xmit.c:479 b43_generate_txhdr() error: uninitialized symbol 'rts'. drivers/net/wireless/broadcom/b43/xmit.c:497 b43_generate_txhdr() error: uninitialized symbol 'plcp'. drivers/net/wireless/broadcom/b43/xmit.c:517 b43_generate_txhdr() error: potentially dereferencing uninitialized 'hdr'. drivers/net/wireless/broadcom/b43/xmit.c:664 b43_rx() error: uninitialized symbol 'macstat'. drivers/net/wireless/broadcom/b43/xmit.c:719 b43_rx() error: uninitialized symbol 'chanstat'. drivers/net/wireless/broadcom/b43/xmit.c:771 b43_rx() error: uninitialized symbol 'mactime'. drivers/net/wireless/broadcom/b43/dma.c:67 b43_dma_address() error: uninitialized symbol 'addr'. Old smatch warnings: arch/powerpc/kvm/powerpc.c:1164 kvmppc_complete_mmio_load() error: uninitialized symbol 'gpr'. arch/powerpc/kvm/powerpc.c:1198 kvmppc_complete_mmio_load() error: uninitialized symbol 'gpr'. arch/powerpc/kvm/powerpc.c:1200 kvmppc_complete_mmio_load() error: uninitialized symbol 'gpr'. arch/powerpc/kvm/powerpc.c:1203 kvmppc_complete_mmio_load() error: uninitialized symbol 'gpr'. arch/powerpc/kvm/powerpc.c:1206 kvmppc_complete_mmio_load() error: uninitialized symbol 'gpr'. drivers/net/wireless/broadcom/b43/phy_n.c:585 b43_nphy_adjust_lna_gain_table() warn: assigning (-2) to unsigned variable '*(lna_gain[0])' drivers/net/wireless/broadcom/b43/phy_n.c:5739 b43_nphy_rev2_cal_rx_iq() error: uninitialized symbol 'cur_hpf1'. vim +/gpr +1158 arch/powerpc/kvm/powerpc.c 6f63e81bda98cb Bin Lu 2017-02-21 1109 8c99d34578628b Tianjia Zhang 2020-04-27 1110 static void kvmppc_complete_mmio_load(struct kvm_vcpu *vcpu) bbf45ba57eaec5 Hollis Blanchard 2008-04-16 1111 { 8c99d34578628b Tianjia Zhang 2020-04-27 1112 struct kvm_run *run = vcpu->run; 3f649ab728cda8 Kees Cook 2020-06-03 1113 u64 gpr; bbf45ba57eaec5 Hollis Blanchard 2008-04-16 1114 8e5b26b55a8b6a Alexander Graf 2010-01-08 1115 if (run->mmio.len > sizeof(gpr)) { bbf45ba57eaec5 Hollis Blanchard 2008-04-16 1116 printk(KERN_ERR "bad MMIO length: %d\n", run->mmio.len); bbf45ba57eaec5 Hollis Blanchard 2008-04-16 1117 return; bbf45ba57eaec5 Hollis Blanchard 2008-04-16 1118 } bbf45ba57eaec5 Hollis Blanchard 2008-04-16 1119 d078eed35de386 David Gibson 2015-02-03 1120 if (!vcpu->arch.mmio_host_swabbed) { bbf45ba57eaec5 Hollis Blanchard 2008-04-16 1121 switch (run->mmio.len) { b104d06632d089 Alexander Graf 2010-02-19 1122 case 8: gpr = *(u64 *)run->mmio.data; break; 8e5b26b55a8b6a Alexander Graf 2010-01-08 1123 case 4: gpr = *(u32 *)run->mmio.data; break; 8e5b26b55a8b6a Alexander Graf 2010-01-08 1124 case 2: gpr = *(u16 *)run->mmio.data; break; 8e5b26b55a8b6a Alexander Graf 2010-01-08 1125 case 1: gpr = *(u8 *)run->mmio.data; break; bbf45ba57eaec5 Hollis Blanchard 2008-04-16 1126 } bbf45ba57eaec5 Hollis Blanchard 2008-04-16 1127 } else { bbf45ba57eaec5 Hollis Blanchard 2008-04-16 1128 switch (run->mmio.len) { d078eed35de386 David Gibson 2015-02-03 1129 case 8: gpr = swab64(*(u64 *)run->mmio.data); break; d078eed35de386 David Gibson 2015-02-03 1130 case 4: gpr = swab32(*(u32 *)run->mmio.data); break; d078eed35de386 David Gibson 2015-02-03 1131 case 2: gpr = swab16(*(u16 *)run->mmio.data); break; 8e5b26b55a8b6a Alexander Graf 2010-01-08 1132 case 1: gpr = *(u8 *)run->mmio.data; break; bbf45ba57eaec5 Hollis Blanchard 2008-04-16 1133 } bbf45ba57eaec5 Hollis Blanchard 2008-04-16 1134 } 8e5b26b55a8b6a Alexander Graf 2010-01-08 1135 6f63e81bda98cb Bin Lu 2017-02-21 1136 /* conversion between single and double precision */ 6f63e81bda98cb Bin Lu 2017-02-21 1137 if ((vcpu->arch.mmio_sp64_extend) && (run->mmio.len == 4)) 6f63e81bda98cb Bin Lu 2017-02-21 1138 gpr = sp_to_dp(gpr); 6f63e81bda98cb Bin Lu 2017-02-21 1139 3587d5348ced08 Alexander Graf 2010-02-19 1140 if (vcpu->arch.mmio_sign_extend) { 3587d5348ced08 Alexander Graf 2010-02-19 1141 switch (run->mmio.len) { 3587d5348ced08 Alexander Graf 2010-02-19 1142 #ifdef CONFIG_PPC64 3587d5348ced08 Alexander Graf 2010-02-19 1143 case 4: 3587d5348ced08 Alexander Graf 2010-02-19 1144 gpr = (s64)(s32)gpr; 3587d5348ced08 Alexander Graf 2010-02-19 1145 break; 3587d5348ced08 Alexander Graf 2010-02-19 1146 #endif 3587d5348ced08 Alexander Graf 2010-02-19 1147 case 2: 3587d5348ced08 Alexander Graf 2010-02-19 1148 gpr = (s64)(s16)gpr; 3587d5348ced08 Alexander Graf 2010-02-19 1149 break; 3587d5348ced08 Alexander Graf 2010-02-19 1150 case 1: 3587d5348ced08 Alexander Graf 2010-02-19 1151 gpr = (s64)(s8)gpr; 3587d5348ced08 Alexander Graf 2010-02-19 1152 break; 3587d5348ced08 Alexander Graf 2010-02-19 1153 } 3587d5348ced08 Alexander Graf 2010-02-19 1154 } 3587d5348ced08 Alexander Graf 2010-02-19 1155 b3c5d3c2a49602 Alexander Graf 2012-01-07 1156 switch (vcpu->arch.io_gpr & KVM_MMIO_REG_EXT_MASK) { b3c5d3c2a49602 Alexander Graf 2012-01-07 1157 case KVM_MMIO_REG_GPR: b104d06632d089 Alexander Graf 2010-02-19 @1158 kvmppc_set_gpr(vcpu, vcpu->arch.io_gpr, gpr); b104d06632d089 Alexander Graf 2010-02-19 1159 break; b3c5d3c2a49602 Alexander Graf 2012-01-07 1160 case KVM_MMIO_REG_FPR: 2e6baa46b4ae78 Simon Guo 2018-05-21 1161 if (vcpu->kvm->arch.kvm_ops->giveup_ext) 2e6baa46b4ae78 Simon Guo 2018-05-21 1162 vcpu->kvm->arch.kvm_ops->giveup_ext(vcpu, MSR_FP); 2e6baa46b4ae78 Simon Guo 2018-05-21 1163 efff19122315f1 Paul Mackerras 2013-10-15 1164 VCPU_FPR(vcpu, vcpu->arch.io_gpr & KVM_MMIO_REG_MASK) = gpr; b104d06632d089 Alexander Graf 2010-02-19 1165 break; 287d5611fab5a4 Alexander Graf 2010-04-01 1166 #ifdef CONFIG_PPC_BOOK3S b3c5d3c2a49602 Alexander Graf 2012-01-07 1167 case KVM_MMIO_REG_QPR: b3c5d3c2a49602 Alexander Graf 2012-01-07 1168 vcpu->arch.qpr[vcpu->arch.io_gpr & KVM_MMIO_REG_MASK] = gpr; b104d06632d089 Alexander Graf 2010-02-19 1169 break; b3c5d3c2a49602 Alexander Graf 2012-01-07 1170 case KVM_MMIO_REG_FQPR: efff19122315f1 Paul Mackerras 2013-10-15 1171 VCPU_FPR(vcpu, vcpu->arch.io_gpr & KVM_MMIO_REG_MASK) = gpr; b3c5d3c2a49602 Alexander Graf 2012-01-07 1172 vcpu->arch.qpr[vcpu->arch.io_gpr & KVM_MMIO_REG_MASK] = gpr; b104d06632d089 Alexander Graf 2010-02-19 1173 break; 6f63e81bda98cb Bin Lu 2017-02-21 1174 #endif 6f63e81bda98cb Bin Lu 2017-02-21 1175 #ifdef CONFIG_VSX 6f63e81bda98cb Bin Lu 2017-02-21 1176 case KVM_MMIO_REG_VSX: 2e6baa46b4ae78 Simon Guo 2018-05-21 1177 if (vcpu->kvm->arch.kvm_ops->giveup_ext) 2e6baa46b4ae78 Simon Guo 2018-05-21 1178 vcpu->kvm->arch.kvm_ops->giveup_ext(vcpu, MSR_VSX); 2e6baa46b4ae78 Simon Guo 2018-05-21 1179 da2a32b876e979 Simon Guo 2018-05-21 1180 if (vcpu->arch.mmio_copy_type == KVMPPC_VSX_COPY_DWORD) 6f63e81bda98cb Bin Lu 2017-02-21 1181 kvmppc_set_vsr_dword(vcpu, gpr); da2a32b876e979 Simon Guo 2018-05-21 1182 else if (vcpu->arch.mmio_copy_type == KVMPPC_VSX_COPY_WORD) 6f63e81bda98cb Bin Lu 2017-02-21 1183 kvmppc_set_vsr_word(vcpu, gpr); da2a32b876e979 Simon Guo 2018-05-21 1184 else if (vcpu->arch.mmio_copy_type == 6f63e81bda98cb Bin Lu 2017-02-21 1185 KVMPPC_VSX_COPY_DWORD_LOAD_DUMP) 6f63e81bda98cb Bin Lu 2017-02-21 1186 kvmppc_set_vsr_dword_dump(vcpu, gpr); da2a32b876e979 Simon Guo 2018-05-21 1187 else if (vcpu->arch.mmio_copy_type == 94dd7fa1c0b75e Simon Guo 2018-05-21 1188 KVMPPC_VSX_COPY_WORD_LOAD_DUMP) 94dd7fa1c0b75e Simon Guo 2018-05-21 1189 kvmppc_set_vsr_word_dump(vcpu, gpr); 6f63e81bda98cb Bin Lu 2017-02-21 1190 break; 09f984961c137c Jose Ricardo Ziviani 2018-02-03 1191 #endif 09f984961c137c Jose Ricardo Ziviani 2018-02-03 1192 #ifdef CONFIG_ALTIVEC 09f984961c137c Jose Ricardo Ziviani 2018-02-03 1193 case KVM_MMIO_REG_VMX: 2e6baa46b4ae78 Simon Guo 2018-05-21 1194 if (vcpu->kvm->arch.kvm_ops->giveup_ext) 2e6baa46b4ae78 Simon Guo 2018-05-21 1195 vcpu->kvm->arch.kvm_ops->giveup_ext(vcpu, MSR_VEC); 2e6baa46b4ae78 Simon Guo 2018-05-21 1196 acc9eb9305fecd Simon Guo 2018-05-21 1197 if (vcpu->arch.mmio_copy_type == KVMPPC_VMX_COPY_DWORD) 09f984961c137c Jose Ricardo Ziviani 2018-02-03 1198 kvmppc_set_vmx_dword(vcpu, gpr); acc9eb9305fecd Simon Guo 2018-05-21 1199 else if (vcpu->arch.mmio_copy_type == KVMPPC_VMX_COPY_WORD) acc9eb9305fecd Simon Guo 2018-05-21 1200 kvmppc_set_vmx_word(vcpu, gpr); acc9eb9305fecd Simon Guo 2018-05-21 1201 else if (vcpu->arch.mmio_copy_type == acc9eb9305fecd Simon Guo 2018-05-21 1202 KVMPPC_VMX_COPY_HWORD) acc9eb9305fecd Simon Guo 2018-05-21 1203 kvmppc_set_vmx_hword(vcpu, gpr); acc9eb9305fecd Simon Guo 2018-05-21 1204 else if (vcpu->arch.mmio_copy_type == acc9eb9305fecd Simon Guo 2018-05-21 1205 KVMPPC_VMX_COPY_BYTE) acc9eb9305fecd Simon Guo 2018-05-21 1206 kvmppc_set_vmx_byte(vcpu, gpr); 09f984961c137c Jose Ricardo Ziviani 2018-02-03 1207 break; 873db2cd9a6d7f Suraj Jitindar Singh 2018-12-14 1208 #endif 873db2cd9a6d7f Suraj Jitindar Singh 2018-12-14 1209 #ifdef CONFIG_KVM_BOOK3S_HV_POSSIBLE 873db2cd9a6d7f Suraj Jitindar Singh 2018-12-14 1210 case KVM_MMIO_REG_NESTED_GPR: 873db2cd9a6d7f Suraj Jitindar Singh 2018-12-14 1211 if (kvmppc_need_byteswap(vcpu)) 873db2cd9a6d7f Suraj Jitindar Singh 2018-12-14 1212 gpr = swab64(gpr); 873db2cd9a6d7f Suraj Jitindar Singh 2018-12-14 1213 kvm_vcpu_write_guest(vcpu, vcpu->arch.nested_io_gpr, &gpr, 873db2cd9a6d7f Suraj Jitindar Singh 2018-12-14 1214 sizeof(gpr)); 873db2cd9a6d7f Suraj Jitindar Singh 2018-12-14 1215 break; 287d5611fab5a4 Alexander Graf 2010-04-01 1216 #endif b104d06632d089 Alexander Graf 2010-02-19 1217 default: b104d06632d089 Alexander Graf 2010-02-19 1218 BUG(); b104d06632d089 Alexander Graf 2010-02-19 1219 } bbf45ba57eaec5 Hollis Blanchard 2008-04-16 1220 } bbf45ba57eaec5 Hollis Blanchard 2008-04-16 1221 :::::: The code at line 1158 was first introduced by commit :::::: b104d06632d08957f384ff7403f609fb5dfb9cbd KVM: PPC: Enable MMIO to do 64 bits, fprs and qprs :::::: TO: Alexander Graf <[email protected]> :::::: CC: Avi Kivity <[email protected]> --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/[email protected]
.config.gz
Description: application/gzip
_______________________________________________ kbuild mailing list -- [email protected] To unsubscribe send an email to [email protected]
