CC: [email protected] TO: [email protected] TO: Guenter Roeck <[email protected]>
From: kernel test robot <[email protected]> drivers/soc/mediatek/mtk-svs.c:1663:7-32: ERROR: Threaded IRQ with no primary handler requested without IRQF_ONESHOT Since commit 1c6c69525b40 ("genirq: Reject bogus threaded irq requests") threaded IRQs without a primary handler need to be requested with IRQF_ONESHOT, otherwise the request will fail. So pass the IRQF_ONESHOT flag in this case. Generated by: scripts/coccinelle/misc/irqf_oneshot.cocci Fixes: 8cafd5ac5f11 ("FROMLIST: soc: mediatek: SVS: introduce MTK SVS engine") CC: Roger Lu <[email protected]> Reported-by: kernel test robot <[email protected]> Signed-off-by: kernel test robot <[email protected]> --- tree: https://chromium.googlesource.com/chromiumos/third_party/kernel chromeos-5.10 head: db5f6056e952c6c5e0afca17277ede687b865584 commit: 8cafd5ac5f113cb45e075c67cdf1217569d93a36 [4/40] FROMLIST: soc: mediatek: SVS: introduce MTK SVS engine :::::: branch date: 2 hours ago :::::: commit date: 12 hours ago Please take the patch only if it's a positive warning. Thanks! mtk-svs.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) --- a/drivers/soc/mediatek/mtk-svs.c +++ b/drivers/soc/mediatek/mtk-svs.c @@ -1661,7 +1661,8 @@ static int svs_probe(struct platform_dev svsp_irq = irq_of_parse_and_map(svsp->dev->of_node, 0); ret = devm_request_threaded_irq(svsp->dev, svsp_irq, NULL, svs_isr, - svsp->irqflags, svsp->name, svsp); + svsp->irqflags | IRQF_ONESHOT, + svsp->name, svsp); if (ret) { dev_err(svsp->dev, "register irq(%d) failed: %d\n", svsp_irq, ret); _______________________________________________ kbuild mailing list -- [email protected] To unsubscribe send an email to [email protected]
