CC: [email protected] TO: Andrea Arcangeli <[email protected]> CC: Andrew Morton <[email protected]> CC: Linux Memory Management List <[email protected]> CC: [email protected]
From: kernel test robot <[email protected]> mm/userfaultfd.c:831:3-6: WARNING: Use BUG_ON instead of if condition followed by BUG. Please make sure the condition has no side effects (see conditional BUG_ON definition in include/asm-generic/bug.h) mm/userfaultfd.c:883:3-6: WARNING: Use BUG_ON instead of if condition followed by BUG. Please make sure the condition has no side effects (see conditional BUG_ON definition in include/asm-generic/bug.h) Use BUG_ON instead of a if condition followed by BUG. Semantic patch information: This makes an effort to find cases where BUG() follows an if condition on an expression and replaces the if condition and BUG() with a BUG_ON having the conditional expression of the if statement as argument. Generated by: scripts/coccinelle/misc/bugon.cocci Fixes: 02c0714c4e4f ("userfaultfd: UFFDIO_REMAP uABI") Reported-by: kernel test robot <[email protected]> Signed-off-by: kernel test robot <[email protected]> --- tree: https://git.kernel.org/pub/scm/linux/kernel/git/andrea/aa.git master head: 231327dd5f394c1d032155b7819eeca9e0efe5fd commit: 02c0714c4e4f79be9c34d6a7b3614f86f2967210 [33/37] userfaultfd: UFFDIO_REMAP uABI :::::: branch date: 4 hours ago :::::: commit date: 4 hours ago Please take the patch only if it's a positive warning. Thanks! userfaultfd.c | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-) --- a/mm/userfaultfd.c +++ b/mm/userfaultfd.c @@ -826,9 +826,7 @@ static int remap_pages_pte(struct mm_str WRITE_ONCE(src_page->index, linear_page_index(dst_vma, dst_addr)); - if (!pte_same(ptep_clear_flush(src_vma, src_addr, src_pte), - orig_src_pte)) - BUG(); + BUG_ON(!pte_same(ptep_clear_flush(src_vma, src_addr, src_pte), orig_src_pte)); orig_dst_pte = mk_pte(src_page, dst_vma->vm_page_prot); orig_dst_pte = maybe_mkwrite(pte_mkdirty(orig_dst_pte), @@ -878,9 +876,7 @@ static int remap_pages_pte(struct mm_str return -EAGAIN; } - if (pte_val(ptep_get_and_clear(src_mm, src_addr, src_pte)) != - pte_val(orig_src_pte)) - BUG(); + BUG_ON(pte_val(ptep_get_and_clear(src_mm, src_addr, src_pte)) != pte_val(orig_src_pte)); set_pte_at(dst_mm, dst_addr, dst_pte, orig_src_pte); if (dst_mm != src_mm) { _______________________________________________ kbuild mailing list -- [email protected] To unsubscribe send an email to [email protected]
