CC: [email protected]
In-Reply-To: <[email protected]>
References: <[email protected]>
TO: Alistair Popple <[email protected]>
TO: [email protected]
TO: [email protected]
CC: [email protected]
CC: [email protected]
CC: [email protected]
CC: [email protected]
CC: [email protected]
CC: [email protected]
CC: [email protected]
CC: [email protected]

Hi Alistair,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on s390/features]
[also build test WARNING on kselftest/next linus/master v5.13-rc5]
[cannot apply to hnaz-linux-mm/master next-20210609]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    
https://github.com/0day-ci/linux/commits/Alistair-Popple/Add-support-for-SVM-atomics-in-Nouveau/20210607-160056
base:   https://git.kernel.org/pub/scm/linux/kernel/git/s390/linux.git features
:::::: branch date: 3 days ago
:::::: commit date: 3 days ago
config: parisc-randconfig-s032-20210607 (attached as .config)
compiler: hppa64-linux-gcc (GCC) 9.3.0
reproduce:
        wget 
https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O 
~/bin/make.cross
        chmod +x ~/bin/make.cross
        # apt-get install sparse
        # sparse version: v0.6.3-341-g8af24329-dirty
        # 
https://github.com/0day-ci/linux/commit/e54198410efccc00d5c3075e55dc424809de198b
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review 
Alistair-Popple/Add-support-for-SVM-atomics-in-Nouveau/20210607-160056
        git checkout e54198410efccc00d5c3075e55dc424809de198b
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross C=1 
CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' W=1 ARCH=parisc 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <[email protected]>


sparse warnings: (new ones prefixed by >>)
>> mm/memory.c:726:21: sparse: sparse: context imbalance in 
>> 'restore_exclusive_pte' - different lock contexts for basic block
   mm/memory.c:772:1: sparse: sparse: context imbalance in 
'copy_nonpresent_pte' - different lock contexts for basic block
   mm/memory.c:981:9: sparse: sparse: context imbalance in 'copy_pte_range' - 
different lock contexts for basic block
   mm/memory.c: note: in included file (through include/linux/pgtable.h, 
arch/parisc/include/asm/io.h, include/linux/io.h, ...):
   arch/parisc/include/asm/pgtable.h:451:9: sparse: sparse: context imbalance 
in 'zap_pte_range' - different lock contexts for basic block
   mm/memory.c:1725:16: sparse: sparse: context imbalance in '__get_locked_pte' 
- different lock contexts for basic block
   mm/memory.c:1746:9: sparse: sparse: context imbalance in 
'insert_page_into_pte_locked' - different lock contexts for basic block
   mm/memory.c:1774:9: sparse: sparse: context imbalance in 'insert_page' - 
different lock contexts for basic block
   mm/memory.c:2066:9: sparse: sparse: context imbalance in 'insert_pfn' - 
different lock contexts for basic block
   mm/memory.c:2285:17: sparse: sparse: context imbalance in 'remap_pte_range' 
- different lock contexts for basic block
   mm/memory.c:2532:17: sparse: sparse: context imbalance in 
'apply_to_pte_range' - unexpected unlock
   mm/memory.c:3056:17: sparse: sparse: context imbalance in 'wp_page_copy' - 
different lock contexts for basic block
   mm/memory.c:3166:17: sparse: sparse: context imbalance in 'wp_pfn_shared' - 
unexpected unlock
   mm/memory.c:3229:19: sparse: sparse: context imbalance in 'do_wp_page' - 
different lock contexts for basic block
   mm/memory.c:3760:9: sparse: sparse: context imbalance in 'do_anonymous_page' 
- different lock contexts for basic block
   mm/memory.c:3928:9: sparse: sparse: context imbalance in 'do_set_pte' - 
different lock contexts for basic block
   mm/memory.c:4356:32: sparse: sparse: context imbalance in 'do_numa_page' - 
different lock contexts for basic block
   mm/memory.c:4533:9: sparse: sparse: context imbalance in 'handle_pte_fault' 
- different lock contexts for basic block
   mm/memory.c:4819:5: sparse: sparse: context imbalance in 
'follow_invalidate_pte' - different lock contexts for basic block
   mm/memory.c:4940:9: sparse: sparse: context imbalance in 'follow_pfn' - 
unexpected unlock

vim +/restore_exclusive_pte +726 mm/memory.c

28093f9f34cede Gerald Schaefer 2016-04-28  702  
e54198410efccc Alistair Popple 2021-06-07  703  static void 
restore_exclusive_pte(struct vm_area_struct *vma,
e54198410efccc Alistair Popple 2021-06-07  704                                  
  struct page *page, unsigned long address,
e54198410efccc Alistair Popple 2021-06-07  705                                  
  pte_t *ptep)
e54198410efccc Alistair Popple 2021-06-07  706  {
e54198410efccc Alistair Popple 2021-06-07  707          pte_t pte;
e54198410efccc Alistair Popple 2021-06-07  708          swp_entry_t entry;
e54198410efccc Alistair Popple 2021-06-07  709  
e54198410efccc Alistair Popple 2021-06-07  710          pte = 
pte_mkold(mk_pte(page, READ_ONCE(vma->vm_page_prot)));
e54198410efccc Alistair Popple 2021-06-07  711          if 
(pte_swp_soft_dirty(*ptep))
e54198410efccc Alistair Popple 2021-06-07  712                  pte = 
pte_mksoft_dirty(pte);
e54198410efccc Alistair Popple 2021-06-07  713  
e54198410efccc Alistair Popple 2021-06-07  714          entry = 
pte_to_swp_entry(*ptep);
e54198410efccc Alistair Popple 2021-06-07  715          if 
(pte_swp_uffd_wp(*ptep))
e54198410efccc Alistair Popple 2021-06-07  716                  pte = 
pte_mkuffd_wp(pte);
e54198410efccc Alistair Popple 2021-06-07  717          else if 
(is_writable_device_exclusive_entry(entry))
e54198410efccc Alistair Popple 2021-06-07  718                  pte = 
maybe_mkwrite(pte_mkdirty(pte), vma);
e54198410efccc Alistair Popple 2021-06-07  719  
e54198410efccc Alistair Popple 2021-06-07  720          set_pte_at(vma->vm_mm, 
address, ptep, pte);
e54198410efccc Alistair Popple 2021-06-07  721  
e54198410efccc Alistair Popple 2021-06-07  722          /*
e54198410efccc Alistair Popple 2021-06-07  723           * No need to take a 
page reference as one was already
e54198410efccc Alistair Popple 2021-06-07  724           * created when the 
swap entry was made.
e54198410efccc Alistair Popple 2021-06-07  725           */
e54198410efccc Alistair Popple 2021-06-07 @726          if (PageAnon(page))
e54198410efccc Alistair Popple 2021-06-07  727                  
page_add_anon_rmap(page, vma, address, false);
e54198410efccc Alistair Popple 2021-06-07  728          else
e54198410efccc Alistair Popple 2021-06-07  729                  /*
e54198410efccc Alistair Popple 2021-06-07  730                   * Currently 
device exclusive access only supports anonymous
e54198410efccc Alistair Popple 2021-06-07  731                   * memory so 
the entry shouldn't point to a filebacked page.
e54198410efccc Alistair Popple 2021-06-07  732                   */
e54198410efccc Alistair Popple 2021-06-07  733                  
WARN_ON_ONCE(!PageAnon(page));
e54198410efccc Alistair Popple 2021-06-07  734  
e54198410efccc Alistair Popple 2021-06-07  735          if (vma->vm_flags & 
VM_LOCKED)
e54198410efccc Alistair Popple 2021-06-07  736                  
mlock_vma_page(page);
e54198410efccc Alistair Popple 2021-06-07  737  
e54198410efccc Alistair Popple 2021-06-07  738          /*
e54198410efccc Alistair Popple 2021-06-07  739           * No need to 
invalidate - it was non-present before. However
e54198410efccc Alistair Popple 2021-06-07  740           * secondary CPUs may 
have mappings that need invalidating.
e54198410efccc Alistair Popple 2021-06-07  741           */
e54198410efccc Alistair Popple 2021-06-07  742          update_mmu_cache(vma, 
address, ptep);
e54198410efccc Alistair Popple 2021-06-07  743  }
e54198410efccc Alistair Popple 2021-06-07  744  

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/[email protected]

Attachment: .config.gz
Description: application/gzip

_______________________________________________
kbuild mailing list -- [email protected]
To unsubscribe send an email to [email protected]

Reply via email to