CC: [email protected] CC: [email protected] TO: Michael Chan <[email protected]> CC: Vasundhara Volam <[email protected]>
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master head: 6b00bc639f1f2beeff3595e1bab9faaa51d23b01 commit: fea6b3335527f41bc729466fb2a95e48a98827ac bnxt_en: Accumulate all counters. date: 11 months ago :::::: branch date: 3 hours ago :::::: commit date: 11 months ago config: x86_64-randconfig-m001-20210616 (attached as .config) compiler: gcc-9 (Debian 9.3.0-22) 9.3.0 If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot <[email protected]> Reported-by: Dan Carpenter <[email protected]> New smatch warnings: drivers/net/ethernet/broadcom/bnxt/bnxt.c:7654 bnxt_accumulate_all_stats() error: potentially dereferencing uninitialized 'ring0_stats'. Old smatch warnings: drivers/net/ethernet/broadcom/bnxt/bnxt.c:12283 bnxt_init_one() warn: missing error code 'rc' vim +/ring0_stats +7654 drivers/net/ethernet/broadcom/bnxt/bnxt.c fea6b3335527f4 Michael Chan 2020-07-27 7633 fea6b3335527f4 Michael Chan 2020-07-27 7634 static void bnxt_accumulate_all_stats(struct bnxt *bp) fea6b3335527f4 Michael Chan 2020-07-27 7635 { fea6b3335527f4 Michael Chan 2020-07-27 7636 struct bnxt_stats_mem *ring0_stats; fea6b3335527f4 Michael Chan 2020-07-27 7637 bool ignore_zero = false; fea6b3335527f4 Michael Chan 2020-07-27 7638 int i; fea6b3335527f4 Michael Chan 2020-07-27 7639 fea6b3335527f4 Michael Chan 2020-07-27 7640 /* Chip bug. Counter intermittently becomes 0. */ fea6b3335527f4 Michael Chan 2020-07-27 7641 if (bp->flags & BNXT_FLAG_CHIP_P5) fea6b3335527f4 Michael Chan 2020-07-27 7642 ignore_zero = true; fea6b3335527f4 Michael Chan 2020-07-27 7643 fea6b3335527f4 Michael Chan 2020-07-27 7644 for (i = 0; i < bp->cp_nr_rings; i++) { fea6b3335527f4 Michael Chan 2020-07-27 7645 struct bnxt_napi *bnapi = bp->bnapi[i]; fea6b3335527f4 Michael Chan 2020-07-27 7646 struct bnxt_cp_ring_info *cpr; fea6b3335527f4 Michael Chan 2020-07-27 7647 struct bnxt_stats_mem *stats; fea6b3335527f4 Michael Chan 2020-07-27 7648 fea6b3335527f4 Michael Chan 2020-07-27 7649 cpr = &bnapi->cp_ring; fea6b3335527f4 Michael Chan 2020-07-27 7650 stats = &cpr->stats; fea6b3335527f4 Michael Chan 2020-07-27 7651 if (!i) fea6b3335527f4 Michael Chan 2020-07-27 7652 ring0_stats = stats; fea6b3335527f4 Michael Chan 2020-07-27 7653 __bnxt_accumulate_stats(stats->hw_stats, stats->sw_stats, fea6b3335527f4 Michael Chan 2020-07-27 @7654 ring0_stats->hw_masks, fea6b3335527f4 Michael Chan 2020-07-27 7655 ring0_stats->len / 8, ignore_zero); fea6b3335527f4 Michael Chan 2020-07-27 7656 } fea6b3335527f4 Michael Chan 2020-07-27 7657 if (bp->flags & BNXT_FLAG_PORT_STATS) { fea6b3335527f4 Michael Chan 2020-07-27 7658 struct bnxt_stats_mem *stats = &bp->port_stats; fea6b3335527f4 Michael Chan 2020-07-27 7659 __le64 *hw_stats = stats->hw_stats; fea6b3335527f4 Michael Chan 2020-07-27 7660 u64 *sw_stats = stats->sw_stats; fea6b3335527f4 Michael Chan 2020-07-27 7661 u64 *masks = stats->hw_masks; fea6b3335527f4 Michael Chan 2020-07-27 7662 int cnt; fea6b3335527f4 Michael Chan 2020-07-27 7663 fea6b3335527f4 Michael Chan 2020-07-27 7664 cnt = sizeof(struct rx_port_stats) / 8; fea6b3335527f4 Michael Chan 2020-07-27 7665 __bnxt_accumulate_stats(hw_stats, sw_stats, masks, cnt, false); fea6b3335527f4 Michael Chan 2020-07-27 7666 fea6b3335527f4 Michael Chan 2020-07-27 7667 hw_stats += BNXT_TX_PORT_STATS_BYTE_OFFSET / 8; fea6b3335527f4 Michael Chan 2020-07-27 7668 sw_stats += BNXT_TX_PORT_STATS_BYTE_OFFSET / 8; fea6b3335527f4 Michael Chan 2020-07-27 7669 masks += BNXT_TX_PORT_STATS_BYTE_OFFSET / 8; fea6b3335527f4 Michael Chan 2020-07-27 7670 cnt = sizeof(struct tx_port_stats) / 8; fea6b3335527f4 Michael Chan 2020-07-27 7671 __bnxt_accumulate_stats(hw_stats, sw_stats, masks, cnt, false); fea6b3335527f4 Michael Chan 2020-07-27 7672 } fea6b3335527f4 Michael Chan 2020-07-27 7673 if (bp->flags & BNXT_FLAG_PORT_STATS_EXT) { fea6b3335527f4 Michael Chan 2020-07-27 7674 bnxt_accumulate_stats(&bp->rx_port_stats_ext); fea6b3335527f4 Michael Chan 2020-07-27 7675 bnxt_accumulate_stats(&bp->tx_port_stats_ext); fea6b3335527f4 Michael Chan 2020-07-27 7676 } fea6b3335527f4 Michael Chan 2020-07-27 7677 } fea6b3335527f4 Michael Chan 2020-07-27 7678 --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/[email protected]
.config.gz
Description: application/gzip
_______________________________________________ kbuild mailing list -- [email protected] To unsubscribe send an email to [email protected]
