CC: [email protected] In-Reply-To: <[email protected]> References: <[email protected]> TO: Vincent Donnefort <[email protected]> TO: [email protected] TO: [email protected] TO: [email protected] TO: [email protected] TO: [email protected] CC: [email protected] CC: [email protected] CC: [email protected] CC: [email protected] CC: [email protected]
Hi Vincent, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on v5.13] [also build test WARNING on next-20210708] [cannot apply to pm/linux-next linus/master] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/0day-ci/linux/commits/Vincent-Donnefort/Inefficient-OPPs/20210708-181000 base: 62fb9874f5da54fdb243003b386128037319b219 :::::: branch date: 7 hours ago :::::: commit date: 7 hours ago config: i386-randconfig-m021-20210707 (attached as .config) compiler: gcc-9 (Debian 9.3.0-22) 9.3.0 If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot <[email protected]> Reported-by: Dan Carpenter <[email protected]> smatch warnings: drivers/cpufreq/freq_table.c:383 set_freq_table_efficiencies() error: uninitialized symbol 'efficient'. vim +/efficient +383 drivers/cpufreq/freq_table.c da0c6dc00c69d0 Viresh Kumar 2016-06-27 353 ed02f77c75fde1 Vincent Donnefort 2021-07-08 354 static void set_freq_table_efficiencies(struct cpufreq_policy *policy) ed02f77c75fde1 Vincent Donnefort 2021-07-08 355 { ed02f77c75fde1 Vincent Donnefort 2021-07-08 356 struct cpufreq_frequency_table *pos, *table = policy->freq_table; ed02f77c75fde1 Vincent Donnefort 2021-07-08 357 enum cpufreq_table_sorting sort = policy->freq_table_sorted; ed02f77c75fde1 Vincent Donnefort 2021-07-08 358 int efficient, idx; ed02f77c75fde1 Vincent Donnefort 2021-07-08 359 ed02f77c75fde1 Vincent Donnefort 2021-07-08 360 /* Not supported */ ed02f77c75fde1 Vincent Donnefort 2021-07-08 361 if (sort == CPUFREQ_TABLE_UNSORTED) { ed02f77c75fde1 Vincent Donnefort 2021-07-08 362 cpufreq_for_each_entry_idx(pos, table, idx) ed02f77c75fde1 Vincent Donnefort 2021-07-08 363 pos->efficient = idx; ed02f77c75fde1 Vincent Donnefort 2021-07-08 364 return; ed02f77c75fde1 Vincent Donnefort 2021-07-08 365 } ed02f77c75fde1 Vincent Donnefort 2021-07-08 366 ed02f77c75fde1 Vincent Donnefort 2021-07-08 367 /* The highest frequency is always efficient */ ed02f77c75fde1 Vincent Donnefort 2021-07-08 368 cpufreq_for_each_entry_idx(pos, table, idx) { ed02f77c75fde1 Vincent Donnefort 2021-07-08 369 if (pos->frequency == CPUFREQ_ENTRY_INVALID) ed02f77c75fde1 Vincent Donnefort 2021-07-08 370 continue; ed02f77c75fde1 Vincent Donnefort 2021-07-08 371 ed02f77c75fde1 Vincent Donnefort 2021-07-08 372 efficient = idx; ed02f77c75fde1 Vincent Donnefort 2021-07-08 373 ed02f77c75fde1 Vincent Donnefort 2021-07-08 374 if (sort == CPUFREQ_TABLE_SORTED_DESCENDING) ed02f77c75fde1 Vincent Donnefort 2021-07-08 375 break; ed02f77c75fde1 Vincent Donnefort 2021-07-08 376 } ed02f77c75fde1 Vincent Donnefort 2021-07-08 377 ed02f77c75fde1 Vincent Donnefort 2021-07-08 378 for (;;) { ed02f77c75fde1 Vincent Donnefort 2021-07-08 379 pos = &table[idx]; ed02f77c75fde1 Vincent Donnefort 2021-07-08 380 ed02f77c75fde1 Vincent Donnefort 2021-07-08 381 if (pos->frequency != CPUFREQ_ENTRY_INVALID) { ed02f77c75fde1 Vincent Donnefort 2021-07-08 382 if (pos->flags & CPUFREQ_INEFFICIENT_FREQ) { ed02f77c75fde1 Vincent Donnefort 2021-07-08 @383 pos->efficient = efficient; ed02f77c75fde1 Vincent Donnefort 2021-07-08 384 } else { ed02f77c75fde1 Vincent Donnefort 2021-07-08 385 pos->efficient = idx; ed02f77c75fde1 Vincent Donnefort 2021-07-08 386 efficient = idx; ed02f77c75fde1 Vincent Donnefort 2021-07-08 387 } ed02f77c75fde1 Vincent Donnefort 2021-07-08 388 } ed02f77c75fde1 Vincent Donnefort 2021-07-08 389 ed02f77c75fde1 Vincent Donnefort 2021-07-08 390 if (sort == CPUFREQ_TABLE_SORTED_ASCENDING) { ed02f77c75fde1 Vincent Donnefort 2021-07-08 391 if (--idx < 0) ed02f77c75fde1 Vincent Donnefort 2021-07-08 392 break; ed02f77c75fde1 Vincent Donnefort 2021-07-08 393 } else { ed02f77c75fde1 Vincent Donnefort 2021-07-08 394 if (table[++idx].frequency == CPUFREQ_TABLE_END) ed02f77c75fde1 Vincent Donnefort 2021-07-08 395 break; ed02f77c75fde1 Vincent Donnefort 2021-07-08 396 } ed02f77c75fde1 Vincent Donnefort 2021-07-08 397 } ed02f77c75fde1 Vincent Donnefort 2021-07-08 398 } ed02f77c75fde1 Vincent Donnefort 2021-07-08 399 --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/[email protected]
.config.gz
Description: application/gzip
_______________________________________________ kbuild mailing list -- [email protected] To unsubscribe send an email to [email protected]
