CC: [email protected] CC: [email protected] TO: Alexander Lobakin <[email protected]> CC: Vladimir Oltean <[email protected]> CC: Florian Fainelli <[email protected]> CC: Woojung Huh <[email protected]> CC: [email protected] CC: Andrew Lunn <[email protected]> CC: Vivien Didelot <[email protected]> CC: Jakub Kicinski <[email protected]> CC: [email protected] CC: [email protected]
From: kernel test robot <[email protected]> drivers/net/dsa/microchip/ksz_common.c:418:3-35: WARNING: Function "for_each_available_child_of_node" should have of_node_put() before return around line 423. Semantic patch information: False positives can be due to function calls within the for_each loop that may encapsulate an of_node_put. Generated by: scripts/coccinelle/iterators/for_each_child.cocci CC: Alexander Lobakin <[email protected]> Reported-by: kernel test robot <[email protected]> Signed-off-by: kernel test robot <[email protected]> --- tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master head: de5540965853e514a85d3b775e9049deb85a2ff3 commit: 227d72063fccb2d19b30fb4197fba478514f7d83 dsa: simplify Kconfig symbols and dependencies :::::: branch date: 15 hours ago :::::: commit date: 4 months ago Please take the patch only if it's a positive warning. Thanks! ksz_common.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) --- a/drivers/net/dsa/microchip/ksz_common.c +++ b/drivers/net/dsa/microchip/ksz_common.c @@ -419,8 +419,10 @@ int ksz_switch_register(struct ksz_devic if (of_property_read_u32(port, "reg", &port_num)) continue; - if (!(dev->port_mask & BIT(port_num))) + if (!(dev->port_mask & BIT(port_num))) { + of_node_put(port); return -EINVAL; + } of_get_phy_mode(port, &dev->ports[port_num].interface); } _______________________________________________ kbuild mailing list -- [email protected] To unsubscribe send an email to [email protected]
