CC: [email protected] CC: [email protected] TO: Vishal Sagar <[email protected]> CC: Michal Simek <[email protected]> CC: Hyun Kwon <[email protected]> CC: Laurent Pinchart <[email protected]> CC: David Airlie <[email protected]> CC: Daniel Vetter <[email protected]> CC: [email protected] CC: [email protected]
From: kernel test robot <[email protected]> drivers/gpu/drm/xlnx/xlnx_sdi.c:1098:1-23: WARNING: Function "for_each_child_of_node" should have of_node_put() before goto around lines 1112. drivers/gpu/drm/xlnx/xlnx_sdi.c:1098:1-23: WARNING: Function "for_each_child_of_node" should have of_node_put() before goto around lines 1120. Semantic patch information: False positives can be due to function calls within the for_each loop that may encapsulate an of_node_put. Generated by: scripts/coccinelle/iterators/for_each_child.cocci Fixes: a43ca56eb122 ("drm: xlnx: sdi: Add clock framework support") CC: Vishal Sagar <[email protected]> Reported-by: kernel test robot <[email protected]> Signed-off-by: kernel test robot <[email protected]> --- tree: https://github.com/Xilinx/linux-xlnx xlnx_rebase_v5.10 head: f6f032f82f0a13def702a0154df535db88f43391 commit: a43ca56eb1228aed11dd81e74a8138684ca3bac9 [478/1756] drm: xlnx: sdi: Add clock framework support :::::: branch date: 9 hours ago :::::: commit date: 7 weeks ago Please take the patch only if it's a positive warning. Thanks! xlnx_sdi.c | 2 ++ 1 file changed, 2 insertions(+) --- a/drivers/gpu/drm/xlnx/xlnx_sdi.c +++ b/drivers/gpu/drm/xlnx/xlnx_sdi.c @@ -1109,6 +1109,7 @@ static int xlnx_sdi_probe(struct platfor dev_err(dev, "No remote port at %s\n", port->name); of_node_put(endpoint); ret = -EINVAL; + of_node_put(port); goto err_disable_vidin_clk; } @@ -1117,6 +1118,7 @@ static int xlnx_sdi_probe(struct platfor ret = of_property_read_u32(port, "reg", &index); if (ret) { dev_err(dev, "reg property not present - %d\n", ret); + of_node_put(port); goto err_disable_vidin_clk; } _______________________________________________ kbuild mailing list -- [email protected] To unsubscribe send an email to [email protected]
