CC: [email protected]
CC: [email protected]
TO: Robert Foss <[email protected]>
CC: Mauro Carvalho Chehab <[email protected]>
CC: [email protected]
CC: Andrey Konovalov <[email protected]>
CC: Hans Verkuil <[email protected]>

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git 
master
head:   d936eb23874433caa3e3d841cfa16f5434b85dcf
commit: 2f6f8af672038b34d71e16ce9b30c59cc987db2b media: camss: Refactor VFE 
power domain toggling
date:   4 months ago
:::::: branch date: 4 hours ago
:::::: commit date: 4 months ago
config: h8300-randconfig-m031-20210716 (attached as .config)
compiler: h8300-linux-gcc (GCC) 10.3.0

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <[email protected]>
Reported-by: Dan Carpenter <[email protected]>

smatch warnings:
drivers/media/platform/qcom/camss/camss.c:1252 camss_configure_pd() warn: 
missing error code 'ret'

vim +/ret +1252 drivers/media/platform/qcom/camss/camss.c

a1d7c116fcf77c drivers/media/platform/qcom/camss-8x16/camss.c Todor Tomov 
2017-08-08  1236  
2f6f8af672038b drivers/media/platform/qcom/camss/camss.c      Robert Foss 
2021-03-16  1237  static int camss_configure_pd(struct camss *camss)
2f6f8af672038b drivers/media/platform/qcom/camss/camss.c      Robert Foss 
2021-03-16  1238  {
2f6f8af672038b drivers/media/platform/qcom/camss/camss.c      Robert Foss 
2021-03-16  1239      int nbr_pm_domains = 0;
2f6f8af672038b drivers/media/platform/qcom/camss/camss.c      Robert Foss 
2021-03-16  1240      int last_pm_domain = 0;
2f6f8af672038b drivers/media/platform/qcom/camss/camss.c      Robert Foss 
2021-03-16  1241      int i;
2f6f8af672038b drivers/media/platform/qcom/camss/camss.c      Robert Foss 
2021-03-16  1242      int ret;
2f6f8af672038b drivers/media/platform/qcom/camss/camss.c      Robert Foss 
2021-03-16  1243  
2f6f8af672038b drivers/media/platform/qcom/camss/camss.c      Robert Foss 
2021-03-16  1244      if (camss->version == CAMSS_8x96 ||
2f6f8af672038b drivers/media/platform/qcom/camss/camss.c      Robert Foss 
2021-03-16  1245          camss->version == CAMSS_660)
2f6f8af672038b drivers/media/platform/qcom/camss/camss.c      Robert Foss 
2021-03-16  1246              nbr_pm_domains = PM_DOMAIN_GEN1_COUNT;
2f6f8af672038b drivers/media/platform/qcom/camss/camss.c      Robert Foss 
2021-03-16  1247  
2f6f8af672038b drivers/media/platform/qcom/camss/camss.c      Robert Foss 
2021-03-16  1248      for (i = 0; i < nbr_pm_domains; i++) {
2f6f8af672038b drivers/media/platform/qcom/camss/camss.c      Robert Foss 
2021-03-16  1249              camss->genpd[i] = 
dev_pm_domain_attach_by_id(camss->dev, i);
2f6f8af672038b drivers/media/platform/qcom/camss/camss.c      Robert Foss 
2021-03-16  1250              if (IS_ERR(camss->genpd[i])) {
2f6f8af672038b drivers/media/platform/qcom/camss/camss.c      Robert Foss 
2021-03-16  1251                      ret = PTR_ERR(camss->genpd[i]);
2f6f8af672038b drivers/media/platform/qcom/camss/camss.c      Robert Foss 
2021-03-16 @1252                      goto fail_pm;
2f6f8af672038b drivers/media/platform/qcom/camss/camss.c      Robert Foss 
2021-03-16  1253              }
2f6f8af672038b drivers/media/platform/qcom/camss/camss.c      Robert Foss 
2021-03-16  1254  
2f6f8af672038b drivers/media/platform/qcom/camss/camss.c      Robert Foss 
2021-03-16  1255              camss->genpd_link[i] = 
device_link_add(camss->dev, camss->genpd[i],
2f6f8af672038b drivers/media/platform/qcom/camss/camss.c      Robert Foss 
2021-03-16  1256                                                     
DL_FLAG_STATELESS | DL_FLAG_PM_RUNTIME |
2f6f8af672038b drivers/media/platform/qcom/camss/camss.c      Robert Foss 
2021-03-16  1257                                                     
DL_FLAG_RPM_ACTIVE);
2f6f8af672038b drivers/media/platform/qcom/camss/camss.c      Robert Foss 
2021-03-16  1258              if (!camss->genpd_link[i]) {
2f6f8af672038b drivers/media/platform/qcom/camss/camss.c      Robert Foss 
2021-03-16  1259                      dev_pm_domain_detach(camss->genpd[i], 
true);
2f6f8af672038b drivers/media/platform/qcom/camss/camss.c      Robert Foss 
2021-03-16  1260                      ret = -EINVAL;
2f6f8af672038b drivers/media/platform/qcom/camss/camss.c      Robert Foss 
2021-03-16  1261                      goto fail_pm;
2f6f8af672038b drivers/media/platform/qcom/camss/camss.c      Robert Foss 
2021-03-16  1262              }
2f6f8af672038b drivers/media/platform/qcom/camss/camss.c      Robert Foss 
2021-03-16  1263  
2f6f8af672038b drivers/media/platform/qcom/camss/camss.c      Robert Foss 
2021-03-16  1264              last_pm_domain = i;
2f6f8af672038b drivers/media/platform/qcom/camss/camss.c      Robert Foss 
2021-03-16  1265      }
2f6f8af672038b drivers/media/platform/qcom/camss/camss.c      Robert Foss 
2021-03-16  1266  
2f6f8af672038b drivers/media/platform/qcom/camss/camss.c      Robert Foss 
2021-03-16  1267      return 0;
2f6f8af672038b drivers/media/platform/qcom/camss/camss.c      Robert Foss 
2021-03-16  1268  
2f6f8af672038b drivers/media/platform/qcom/camss/camss.c      Robert Foss 
2021-03-16  1269  fail_pm:
2f6f8af672038b drivers/media/platform/qcom/camss/camss.c      Robert Foss 
2021-03-16  1270      for (i = 0; i < last_pm_domain; i++) {
2f6f8af672038b drivers/media/platform/qcom/camss/camss.c      Robert Foss 
2021-03-16  1271              device_link_del(camss->genpd_link[i]);
2f6f8af672038b drivers/media/platform/qcom/camss/camss.c      Robert Foss 
2021-03-16  1272              dev_pm_domain_detach(camss->genpd[i], true);
2f6f8af672038b drivers/media/platform/qcom/camss/camss.c      Robert Foss 
2021-03-16  1273      }
2f6f8af672038b drivers/media/platform/qcom/camss/camss.c      Robert Foss 
2021-03-16  1274  
2f6f8af672038b drivers/media/platform/qcom/camss/camss.c      Robert Foss 
2021-03-16  1275      return ret;
2f6f8af672038b drivers/media/platform/qcom/camss/camss.c      Robert Foss 
2021-03-16  1276  }
2f6f8af672038b drivers/media/platform/qcom/camss/camss.c      Robert Foss 
2021-03-16  1277  

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/[email protected]

Attachment: .config.gz
Description: application/gzip

_______________________________________________
kbuild mailing list -- [email protected]
To unsubscribe send an email to [email protected]

Reply via email to