CC: [email protected]
CC: [email protected]
TO: Denis Efremov <[email protected]>
CC: Julia Lawall <[email protected]>
CC: Vineet Gupta <[email protected]>
CC: "dean.yang_cp" <[email protected]>
CC: "Gustavo A. R. Silva" <[email protected]>
CC: [email protected]
CC: [email protected]

From: kernel test robot <[email protected]>

arch/arc/kernel/unwind.c:251:22-23: WARNING opportunity for swap()
arch/arc/kernel/unwind.c:254:18-19: WARNING opportunity for swap()


 Check for opencoded swap() implementation.

Generated by: scripts/coccinelle/misc/swap.cocci

CC: Denis Efremov <[email protected]>
Reported-by: kernel test robot <[email protected]>
Signed-off-by: kernel test robot <[email protected]>
---

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git 
master
head:   1d67c8d993baf8ab6be8a2154b1a94ec1311c869
commit: 7845daa8bd72efa8bbc1de122edfce6e058bbe41 coccinelle: misc: add swap 
script
:::::: branch date: 20 hours ago
:::::: commit date: 3 months ago

Please take the patch only if it's a positive warning. Thanks!

 unwind.c |    8 ++------
 1 file changed, 2 insertions(+), 6 deletions(-)

--- a/arch/arc/kernel/unwind.c
+++ b/arch/arc/kernel/unwind.c
@@ -247,12 +247,8 @@ static void swap_eh_frame_hdr_table_entr
        struct eh_frame_hdr_table_entry *e2 = p2;
        unsigned long v;
 
-       v = e1->start;
-       e1->start = e2->start;
-       e2->start = v;
-       v = e1->fde;
-       e1->fde = e2->fde;
-       e2->fde = v;
+       swap(e1->start, e2->start);
+       swap(e1->fde, e2->fde);
 }
 
 static void init_unwind_hdr(struct unwind_table *table,
_______________________________________________
kbuild mailing list -- [email protected]
To unsubscribe send an email to [email protected]

Reply via email to