CC: [email protected] In-Reply-To: <[email protected]> References: <[email protected]> TO: Dario Binacchi <[email protected]> TO: [email protected] CC: Gianluca Falavigna <[email protected]> CC: Dario Binacchi <[email protected]> CC: Andrew Lunn <[email protected]> CC: Jakub Kicinski <[email protected]> CC: "Marc Kleine-Budde" <[email protected]> CC: Oliver Hartkopp <[email protected]> CC: Vincent Mailhol <[email protected]> CC: Wolfgang Grandegger <[email protected]> CC: [email protected]
Hi Dario, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on mkl-can-next/testing] [also build test WARNING on net-next/master net/master linus/master v5.14-rc2 next-20210716] [cannot apply to linux/master sparc-next/master] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/0day-ci/linux/commits/Dario-Binacchi/can-c_can-cache-frames-to-operate-as-a-true-FIFO/20210718-112246 base: https://git.kernel.org/pub/scm/linux/kernel/git/mkl/linux-can-next.git testing :::::: branch date: 22 hours ago :::::: commit date: 22 hours ago config: x86_64-rhel-8.3-kselftests (attached as .config) compiler: gcc-10 (Ubuntu 10.3.0-1ubuntu1~20.04) 10.3.0 reproduce: # apt-get install sparse # sparse version: v0.6.3-341-g8af24329-dirty # https://github.com/0day-ci/linux/commit/7d5112592926ca750a2ade9bc5ae5499cd80c365 git remote add linux-review https://github.com/0day-ci/linux git fetch --no-tags linux-review Dario-Binacchi/can-c_can-cache-frames-to-operate-as-a-true-FIFO/20210718-112246 git checkout 7d5112592926ca750a2ade9bc5ae5499cd80c365 # save the attached .config to linux build tree make W=1 C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' O=build_dir ARCH=x86_64 SHELL=/bin/bash drivers/net/can/c_can/ fs/ceph/ If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot <[email protected]> sparse warnings: (new ones prefixed by >>) >> drivers/net/can/c_can/c_can_main.c:491:9: sparse: sparse: context imbalance >> in 'c_can_start_xmit' - different lock contexts for basic block vim +/c_can_start_xmit +491 drivers/net/can/c_can/c_can_main.c 1e51369d79f821 drivers/net/can/c_can/c_can_main.c Dario Binacchi 2021-07-16 452 881ff67ad45041 drivers/net/can/c_can/c_can.c Bhupesh Sharma 2011-02-13 453 static netdev_tx_t c_can_start_xmit(struct sk_buff *skb, 881ff67ad45041 drivers/net/can/c_can/c_can.c Bhupesh Sharma 2011-02-13 454 struct net_device *dev) 881ff67ad45041 drivers/net/can/c_can/c_can.c Bhupesh Sharma 2011-02-13 455 { 881ff67ad45041 drivers/net/can/c_can/c_can.c Bhupesh Sharma 2011-02-13 456 struct can_frame *frame = (struct can_frame *)skb->data; 35bdafb576c5c0 drivers/net/can/c_can/c_can.c Thomas Gleixner 2014-04-11 457 struct c_can_priv *priv = netdev_priv(dev); 1e51369d79f821 drivers/net/can/c_can/c_can_main.c Dario Binacchi 2021-07-16 458 struct c_can_tx_ring *tx_ring = &priv->tx; 7d5112592926ca drivers/net/can/c_can/c_can_main.c Dario Binacchi 2021-07-16 459 u32 idx, obj, cmd = IF_COMM_TX; 881ff67ad45041 drivers/net/can/c_can/c_can.c Bhupesh Sharma 2011-02-13 460 881ff67ad45041 drivers/net/can/c_can/c_can.c Bhupesh Sharma 2011-02-13 461 if (can_dropped_invalid_skb(dev, skb)) 881ff67ad45041 drivers/net/can/c_can/c_can.c Bhupesh Sharma 2011-02-13 462 return NETDEV_TX_OK; 35bdafb576c5c0 drivers/net/can/c_can/c_can.c Thomas Gleixner 2014-04-11 463 1e51369d79f821 drivers/net/can/c_can/c_can_main.c Dario Binacchi 2021-07-16 464 if (c_can_tx_busy(priv, tx_ring)) 1e51369d79f821 drivers/net/can/c_can/c_can_main.c Dario Binacchi 2021-07-16 465 return NETDEV_TX_BUSY; 1e51369d79f821 drivers/net/can/c_can/c_can_main.c Dario Binacchi 2021-07-16 466 1e51369d79f821 drivers/net/can/c_can/c_can_main.c Dario Binacchi 2021-07-16 467 idx = c_can_get_tx_head(tx_ring); 1e51369d79f821 drivers/net/can/c_can/c_can_main.c Dario Binacchi 2021-07-16 468 tx_ring->head++; 1e51369d79f821 drivers/net/can/c_can/c_can_main.c Dario Binacchi 2021-07-16 469 if (c_can_get_tx_free(tx_ring) == 0) 881ff67ad45041 drivers/net/can/c_can/c_can.c Bhupesh Sharma 2011-02-13 470 netif_stop_queue(dev); 1e51369d79f821 drivers/net/can/c_can/c_can_main.c Dario Binacchi 2021-07-16 471 7d5112592926ca drivers/net/can/c_can/c_can_main.c Dario Binacchi 2021-07-16 472 spin_lock_bh(&priv->tx_lock); 7d5112592926ca drivers/net/can/c_can/c_can_main.c Dario Binacchi 2021-07-16 473 if (idx < c_can_get_tx_tail(tx_ring)) 7d5112592926ca drivers/net/can/c_can/c_can_main.c Dario Binacchi 2021-07-16 474 cmd &= ~IF_COMM_TXRQST; /* Cache the message */ 7d5112592926ca drivers/net/can/c_can/c_can_main.c Dario Binacchi 2021-07-16 475 else 7d5112592926ca drivers/net/can/c_can/c_can_main.c Dario Binacchi 2021-07-16 476 spin_unlock_bh(&priv->tx_lock); 1e51369d79f821 drivers/net/can/c_can/c_can_main.c Dario Binacchi 2021-07-16 477 172f6d3a031b5e drivers/net/can/c_can/c_can.c Marc Kleine-Budde 2021-03-04 478 /* Store the message in the interface so we can call 35bdafb576c5c0 drivers/net/can/c_can/c_can.c Thomas Gleixner 2014-04-11 479 * can_put_echo_skb(). We must do this before we enable 35bdafb576c5c0 drivers/net/can/c_can/c_can.c Thomas Gleixner 2014-04-11 480 * transmit as we might race against do_tx(). 35bdafb576c5c0 drivers/net/can/c_can/c_can.c Thomas Gleixner 2014-04-11 481 */ 939415973fdfb2 drivers/net/can/c_can/c_can.c Thomas Gleixner 2014-04-11 482 c_can_setup_tx_object(dev, IF_TX, frame, idx); c7b74967799b1a drivers/net/can/c_can/c_can.c Oliver Hartkopp 2020-11-20 483 priv->dlc[idx] = frame->len; 1dcb6e57db8334 drivers/net/can/c_can/c_can.c Vincent Mailhol 2021-01-11 484 can_put_echo_skb(skb, dev, idx, 0); 7d5112592926ca drivers/net/can/c_can/c_can_main.c Dario Binacchi 2021-07-16 485 obj = idx + priv->msg_obj_tx_first; 7d5112592926ca drivers/net/can/c_can/c_can_main.c Dario Binacchi 2021-07-16 486 c_can_object_put(dev, IF_TX, obj, cmd); 35bdafb576c5c0 drivers/net/can/c_can/c_can.c Thomas Gleixner 2014-04-11 487 7d5112592926ca drivers/net/can/c_can/c_can_main.c Dario Binacchi 2021-07-16 488 if (spin_is_locked(&priv->tx_lock)) 7d5112592926ca drivers/net/can/c_can/c_can_main.c Dario Binacchi 2021-07-16 489 spin_unlock_bh(&priv->tx_lock); 881ff67ad45041 drivers/net/can/c_can/c_can.c Bhupesh Sharma 2011-02-13 490 881ff67ad45041 drivers/net/can/c_can/c_can.c Bhupesh Sharma 2011-02-13 @491 return NETDEV_TX_OK; 881ff67ad45041 drivers/net/can/c_can/c_can.c Bhupesh Sharma 2011-02-13 492 } 881ff67ad45041 drivers/net/can/c_can/c_can.c Bhupesh Sharma 2011-02-13 493 --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/[email protected]
.config.gz
Description: application/gzip
_______________________________________________ kbuild mailing list -- [email protected] To unsubscribe send an email to [email protected]
